From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Okam via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49809: [PATCH] Add macro 'pcase-setq' Date: Fri, 06 Aug 2021 22:33:36 +0000 Message-ID: References: <07ad5892-3343-4c35-00e3-9753bca5f67b@protonmail.com> Reply-To: Okam Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_Ye9asrvN9cDy2dRTpISh2z5pjx3HXKsqHPAg6RDcKTk" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32841"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49809@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 07 00:34:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mC8Pq-0008KS-Qn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Aug 2021 00:34:10 +0200 Original-Received: from localhost ([::1]:54350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mC8Pp-0001DJ-4X for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Aug 2021 18:34:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC8Pi-0001D7-Sq for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 18:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mC8Pi-0000ch-ME for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 18:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mC8Pi-000166-Fp for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 18:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Okam Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Aug 2021 22:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49809-submit@debbugs.gnu.org id=B49809.16282892354206 (code B ref 49809); Fri, 06 Aug 2021 22:34:02 +0000 Original-Received: (at 49809) by debbugs.gnu.org; 6 Aug 2021 22:33:55 +0000 Original-Received: from localhost ([127.0.0.1]:51492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mC8Pb-00015l-4B for submit@debbugs.gnu.org; Fri, 06 Aug 2021 18:33:55 -0400 Original-Received: from mail-4322.protonmail.ch ([185.70.43.22]:62761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mC8PX-00015S-7e for 49809@debbugs.gnu.org; Fri, 06 Aug 2021 18:33:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1628289223; bh=hG9XgZ7kk5TNk7cn4H4MQtu/jbdZi2qDa3y55mRHN0Q=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=MKuaEgaOioxJPlMywePP1ReLz0wdKcR5r8xThLY0ouprE6bdHsDtcYhSjyyzUaaSb WrFVkyfKxiJW0DeIMXP0NKtfKJUGKHbOlaIUJVIO8xlqSQz8K+FywbkyfHfIZc+L3C Wy9iPVzW55dHFwG7balxbrCyxZa8ZnkLdWz0SgFc= In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" X-ACL-Warn: , Okam Xref: news.gmane.io gmane.emacs.bugs:211353 Archived-At: This is a multi-part message in MIME format. --b1_Ye9asrvN9cDy2dRTpISh2z5pjx3HXKsqHPAg6RDcKTk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/4/21 7:06 PM, Stefan Monnier wrote: > I don't think we should try and combine them: it's not worth the > code complexity. Personally I'd even restrict the calling convention to > (pcase-setq PAT VAL), but if you want to accept the more general case > with multiple PAT+VAL, I'd prefer expanding it to a (progn (pcase-setq > PAT1 VAL1) ...). I think the resulting code would be simpler/cleaner. Done. >> +@defmac pcase-setq pattern value@dots{} >> +Bind variables to values in a @code{setq} form, destructuring each >> +@var{value} according to its respective @var{pattern}. >> +@end defmac > > I prefer keeping "bind" for the case where we create new variables > (i.e. let-bindings) rather than for assignments. This was changed to the phrase "assign values to variables". > > Looks good. But could you add a few corresponding tests to > `test/lisp/emacs-lisp/pcase-tests.el`, including tests for things like > > (pcase-setq `(,a ,b) nil) Added with others. Do you think that the added tests are sufficient? Thank you. --b1_Ye9asrvN9cDy2dRTpISh2z5pjx3HXKsqHPAg6RDcKTk Content-Type: text/x-patch; name=v2-0001-Add-macro-pcase-setq.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v2-0001-Add-macro-pcase-setq.patch RnJvbSAzOTFiZGI0ZWZjMjViMWMzYzUyMWIyN2Q2MjAzYTVkZTE3M2EyZDE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogRWFybCBIeWF0dCA8b2thbXNuQHByb3Rvbm1haWwuY29tPg0K RGF0ZTogU3VuLCAxIEF1ZyAyMDIxIDEyOjMzOjE0IC0wNDAwDQpTdWJqZWN0OiBbUEFUQ0ggdjJd IEFkZCBtYWNybyAncGNhc2Utc2V0cScNCg0KKiBsaXNwL2VtYWNzLWxpc3AvcGNhc2UuZWwgKHBj YXNlLXNldHEpOiBOZXcgbWFjcm8uDQoNClRoaXMgbWFjcm8gaXMgdGhlICdzZXRxJyBlcXVpdmFs ZW50IG9mICdwY2FzZS1sZXQnLg0KDQoqIGRvYy9saXNwcmVmL2NvbnRyb2wudGV4aSAoRGVzdHJ1 Y3R1cmluZyB3aXRoIHBjYXNlIFBhdHRlcm5zKToNCkRvY3VtZW50IHRoaXMgbWFjcm8uDQoNCiog dGVzdC9saXNwL2VtYWNzLWxpc3AvcGNhc2UtdGVzdHMuZWwgKHBjYXNlLXNldHEpOiBUZXN0IHRo aXMgbmV3IG1hY3JvLg0KLS0tDQogZG9jL2xpc3ByZWYvY29udHJvbC50ZXhpICAgICAgICAgICAg fCAgNSArKysrDQogZXRjL05FV1MgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgNCArKysr DQogbGlzcC9lbWFjcy1saXNwL3BjYXNlLmVsICAgICAgICAgICAgfCAzMSArKysrKysrKysrKysr KysrKysrKysrKysrDQogdGVzdC9saXNwL2VtYWNzLWxpc3AvcGNhc2UtdGVzdHMuZWwgfCAzNiAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KIDQgZmlsZXMgY2hhbmdlZCwgNzYgaW5zZXJ0 aW9ucygrKQ0KDQpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvY29udHJvbC50ZXhpIGIvZG9jL2xp c3ByZWYvY29udHJvbC50ZXhpDQppbmRleCA1MDI2ZDBhNGQ3Li42ZTRhNTIzNGUyIDEwMDY0NA0K LS0tIGEvZG9jL2xpc3ByZWYvY29udHJvbC50ZXhpDQorKysgYi9kb2MvbGlzcHJlZi9jb250cm9s LnRleGkNCkBAIC0xMzEyLDYgKzEzMTIsMTEgQEAgRGVzdHJ1Y3R1cmluZyB3aXRoIHBjYXNlIFBh dHRlcm5zDQogdXAgYmVpbmcgZXF1aXZhbGVudCB0byBAY29kZXtkb2xpc3R9IChAcHhyZWZ7SXRl cmF0aW9ufSkuDQogQGVuZCBkZWZtYWMNCiANCitAZGVmbWFjIHBjYXNlLXNldHEgcGF0dGVybiB2 YWx1ZUBkb3Rze30NCitBc3NpZ24gdmFsdWVzIHRvIHZhcmlhYmxlcyBpbiBhIEBjb2Rle3NldHF9 IGZvcm0sDQorZGVzdHJ1Y3R1cmluZyBlYWNoIEB2YXJ7dmFsdWV9IGFjY29yZGluZyB0byBpdHMg cmVzcGVjdGl2ZQ0KK0B2YXJ7cGF0dGVybn0uDQorQGVuZCBkZWZtYWMNCiANCiBAbm9kZSBJdGVy YXRpb24NCiBAc2VjdGlvbiBJdGVyYXRpb24NCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9O RVdTDQppbmRleCA5NWEyYzg3ZDA1Li4wZjExY2FmNTEyIDEwMDY0NA0KLS0tIGEvZXRjL05FV1MN CisrKyBiL2V0Yy9ORVdTDQpAQCAtNTUzLDYgKzU1MywxMCBAQCBUaGUgbmV3ICdjbC10eXBlJyBw YXR0ZXJuIGNvbXBhcmVzIHR5cGVzIHVzaW5nICdjbC10eXBlcCcsIHdoaWNoIGFsbG93cw0KIGNv bXBhcmluZyBzaW1wbGUgdHlwZXMgbGlrZSAnKGNsLXR5cGUgaW50ZWdlciknLCBhcyB3ZWxsIGFz IGZvcm1zIGxpa2UNCiAnKGNsLXR5cGUgKGludGVnZXIgMCAxMCkpJy4NCiANCisqKiogTmV3IG1h Y3JvICdwY2FzZS1zZXRxJw0KK1RoaXMgbWFjcm8gaXMgdGhlICdzZXRxJyBlcXVpdmFsZW50IG9m ICdwY2FzZS1sZXQnLCB3aGljaCBhbGxvd3MgZm9yDQorZGVzdHJ1Y3R1cmluZyBwYXR0ZXJucyBp biBhICdzZXRxJyBmb3JtLg0KKw0KICsrKw0KICoqIHByb2ZpbGVyLmVsDQogVGhlIHJlc3VsdHMg ZGlzcGxheWVkIGJ5ICdwcm9maWxlci1yZXBvcnQnIG5vdyBoYXZlIHRoZSB1c2FnZSBmaWd1cmVz DQpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL3BjYXNlLmVsIGIvbGlzcC9lbWFjcy1saXNw L3BjYXNlLmVsDQppbmRleCAwMDY1MTdkYjc1Li4xNGFmNzBhNjViIDEwMDY0NA0KLS0tIGEvbGlz cC9lbWFjcy1saXNwL3BjYXNlLmVsDQorKysgYi9saXNwL2VtYWNzLWxpc3AvcGNhc2UuZWwNCkBA IC0zMTcsNiArMzE3LDM3IEBAIHBjYXNlLWRvbGlzdA0KICAgICAgICAgIChwY2FzZS1sZXQqICgo LChjYXIgc3BlYykgLHRtcHZhcikpDQogICAgICAgICAgICAsQGJvZHkpKSkpKQ0KIA0KKzs7OyMj I2F1dG9sb2FkDQorKGRlZm1hY3JvIHBjYXNlLXNldHEgKHBhdCB2YWwgJnJlc3QgYXJncykNCisg ICJBc3NpZ24gdmFsdWVzIHRvIHZhcmlhYmxlcyBieSBkZXN0cnVjdHVyaW5nIHdpdGggYHBjYXNl Jy4NCisNCitcKGZuIFBBVFRFUk4gVkFMVUUgUEFUVEVSTiBWQUxVRSAuLi4pIg0KKyAgKGRlY2xh cmUgKGRlYnVnICgmcmVzdCBbcGNhc2UtUEFUIGZvcm1dKSkpDQorICAoY29uZA0KKyAgIChhcmdz DQorICAgIChsZXQgKChhcmctbGVuZ3RoIChsZW5ndGggYXJncykpKQ0KKyAgICAgICh1bmxlc3Mg KD0gMCAobW9kIGFyZy1sZW5ndGggMikpDQorICAgICAgICAoc2lnbmFsICd3cm9uZy1udW1iZXIt b2YtYXJndW1lbnRzDQorICAgICAgICAgICAgICAgIChsaXN0ICdwY2FzZS1zZXRxICgrIDIgYXJn LWxlbmd0aCkpKSkpDQorICAgIChsZXQgKChyZXN1bHQpKQ0KKyAgICAgICh3aGlsZSBhcmdzDQor ICAgICAgICAocHVzaCBgKHBjYXNlLXNldHEgLChwb3AgYXJncykgLChwb3AgYXJncykpDQorICAg ICAgICAgICAgICByZXN1bHQpKQ0KKyAgICAgIGAocHJvZ24NCisgICAgICAgICAocGNhc2Utc2V0 cSAscGF0ICx2YWwpDQorICAgICAgICAgLEAobnJldmVyc2UgcmVzdWx0KSkpKQ0KKyAgICgocGNh c2UtLXRyaXZpYWwtdXBhdC1wIHBhdCkNCisgICAgYChzZXRxICxwYXQgLHZhbCkpDQorICAgKHQN CisgICAgKHBjYXNlLWNvbXBpbGUtcGF0dGVybnMNCisgICAgIHZhbA0KKyAgICAgKGxpc3QgKGNv bnMgcGF0DQorICAgICAgICAgICAgICAgICAobGFtYmRhICh2YXJ2YWxzICZyZXN0IF8pDQorICAg ICAgICAgICAgICAgICAgIGAoc2V0cSAsQChtYXBjYW4gKGxhbWJkYSAodmFydmFsKQ0KKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxldCAoKHZhciAoY2FyIHZhcnZhbCkp DQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodmFsIChjYWRy IHZhcnZhbCkpKQ0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobGlz dCB2YXIgdmFsKSkpDQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmFydmFs cykpKSkpKSkpKQ0KIA0KIChkZWZ1biBwY2FzZS0tdHJpdmlhbC11cGF0LXAgKHVwYXQpDQogICAo YW5kIChzeW1ib2xwIHVwYXQpIChub3QgKG1lbXEgdXBhdCBwY2FzZS0tZG9udGNhcmUtdXBhdHMp KSkpDQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VtYWNzLWxpc3AvcGNhc2UtdGVzdHMuZWwgYi90 ZXN0L2xpc3AvZW1hY3MtbGlzcC9wY2FzZS10ZXN0cy5lbA0KaW5kZXggMDJkMzg3OGFkMC4uYzUz NjQ4MzgzYSAxMDA2NDQNCi0tLSBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL3BjYXNlLXRlc3RzLmVs DQorKysgYi90ZXN0L2xpc3AvZW1hY3MtbGlzcC9wY2FzZS10ZXN0cy5lbA0KQEAgLTExMCw0ICsx MTAsNDAgQEAgcGNhc2UtdGVzdHMtY2wtdHlwZQ0KICAgKHNob3VsZC1lcnJvciAocGNhc2UgMQ0K ICAgICAgICAgICAgICAgICAgICgoY2wtdHlwZSBub3RhdHlwZSkgJ2ludGVnZXIpKSkpDQogDQor KGVydC1kZWZ0ZXN0IHBjYXNlLXNldHEgKCkNCisgIChzaG91bGQgKGVxdWFsIChsaXN0IG5pbCBu aWwpDQorICAgICAgICAgICAgICAgICAobGV0IChhIGIpDQorICAgICAgICAgICAgICAgICAgIChw Y2FzZS1zZXRxIGAoLGEgLGIpIG5pbCkNCisgICAgICAgICAgICAgICAgICAgKGxpc3QgYSBiKSkp KQ0KKw0KKyAgKHNob3VsZCAoZXF1YWwgJygxIDIpDQorICAgICAgICAgICAgICAgICAobGV0IChh IGIpDQorICAgICAgICAgICAgICAgICAgIChwY2FzZS1zZXRxIGBbLGEgLGJdIFsxIDJdKQ0KKyAg ICAgICAgICAgICAgICAgICAobGlzdCBhIGIpKSkpDQorDQorICAoc2hvdWxkIChlcXVhbCAnKDEg MikNCisgICAgICAgICAgICAgICAgIChsZXQgKGEgYikNCisgICAgICAgICAgICAgICAgICAgKHBj YXNlLXNldHEgYSAxIGIgMikNCisgICAgICAgICAgICAgICAgICAgKGxpc3QgYSBiKSkpKQ0KKw0K KyAgKHNob3VsZCAoPSAyIChsZXQgKGEpDQorICAgICAgICAgICAgICAgICAocGNhc2Utc2V0cSBh IDEgYCgsYSkgJygyKSkNCisgICAgICAgICAgICAgICAgIGEpKSkNCisNCisgIChzaG91bGQgKGVx dWFsICcobmlsIFsxIDIgM10gNCkNCisgICAgICAgICAgICAgICAgIChsZXQgKGFycmF5IGxpc3Qt aXRlbSBhcnJheS1jb3B5KQ0KKyAgICAgICAgICAgICAgICAgICAocGNhc2Utc2V0cSAob3IgYCgs bGlzdC1pdGVtKSBhcnJheSkgWzEgMiAzXQ0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBhcnJheS1jb3B5IGFycmF5DQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IFRo aXMgcmUtc2V0cyBgYXJyYXknIHRvIG5pbC4NCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKG9yIGAoLGxpc3QtaXRlbSkgYXJyYXkpICcoNCkpDQorICAgICAgICAgICAgICAgICAgIChs aXN0IGFycmF5IGFycmF5LWNvcHkgbGlzdC1pdGVtKSkpKQ0KKw0KKyAgKGxldCAoKGEgbmlsKSkN CisgICAgKHNob3VsZC1lcnJvciAocGNhc2Utc2V0cSBhIDEgYikNCisgICAgICAgICAgICAgICAg ICA6dHlwZSAnKHdyb25nLW51bWJlci1vZi1hcmd1bWVudHMpKQ0KKyAgICAoc2hvdWxkIChlcSBh IG5pbCkpKQ0KKw0KKyAgKHNob3VsZC1lcnJvciAocGNhc2Utc2V0cSBhKQ0KKyAgICAgICAgICAg ICAgICA6dHlwZSAnKHdyb25nLW51bWJlci1vZi1hcmd1bWVudHMpKSkNCisNCiA7OzsgcGNhc2Ut dGVzdHMuZWwgZW5kcyBoZXJlLg0KLS0gDQoyLjI1LjENCg0K --b1_Ye9asrvN9cDy2dRTpISh2z5pjx3HXKsqHPAg6RDcKTk--