unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
blob e0a5691b0735a513fcbbb707d2d69aeaff6c0b60 7453 bytes (raw)
name: test/lisp/erc/erc-nicks-tests.el 	 # note: path name is non-authoritative(*)

  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
 
;;; erc-nicks-tests.el --- Tests for erc-nicks  -*- lexical-binding:t -*-

;; Copyright (C) 2023 Free Software Foundation, Inc.

;; This file is part of GNU Emacs.

;; GNU Emacs is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.

;; GNU Emacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
;; GNU General Public License for more details.

;; You should have received a copy of the GNU General Public License
;; along with GNU Emacs.  If not, see <https://www.gnu.org/licenses/>.

;;; Commentary:

;; TODO:
;;
;; * Add mock session (or scenario) with buffer snapshots, like those
;;   in erc-fill-tests.el.  (Should probably move helpers to a common
;;   library under ./resources.)

;;; Code:

(require 'ert)
(require 'erc-nicks)

(ert-deftest erc-nicks--get-luminance ()
  (should (eql 0.0 (erc-nicks--get-luminance "black")))
  (should (eql 1.0 (erc-nicks--get-luminance "white")))
  (should (eql 21.0 (/ (+ 0.05 1.0) (+ 0.05 0.0))))

  ;; RGB floats from a `display-graphic-p' session.
  (let ((a (erc-nicks--get-luminance ; #9439ad
            '(0.5803921568627451 0.2235294117647059 0.6784313725490196)))
        (b (erc-nicks--get-luminance ; #ae54c7
            '(0.6823529411764706 0.32941176470588235 0.7803921568627451)))
        (c (erc-nicks--get-luminance ; #d19ddf
            '(0.8196078431372549 0.615686274509804 0.8745098039215686)))
        (d (erc-nicks--get-luminance ; #f5e8f8
            '(0.9607843137254902 0.9098039215686274 0.9725490196078431))))
    ;; Low, med, high contrast comparisons against known values from
    ;; an external source.
    (should (eql 1.42 (/ (round (* 100 (/ (+ 0.05 b) (+ 0.05 a)))) 100.0)))
    (should (eql 2.78 (/ (round (* 100 (/ (+ 0.05 c) (+ 0.05 a)))) 100.0)))
    (should (eql 5.16 (/ (round (* 100 (/ (+ 0.05 d) (+ 0.05 a)))) 100.0)))))

(ert-deftest erc-nicks-invert ()
  (let ((erc-nicks--bg-mode-value 'dark))
    (should (equal (erc-nicks-invert "white") "white"))
    (should (equal (erc-nicks-invert "black") "#ffffffffffff"))
    (should (equal (erc-nicks-invert "green") "green")))
  (let ((erc-nicks--bg-mode-value 'light))
    (should (equal (erc-nicks-invert "white") "#000000000000"))
    (should (equal (erc-nicks-invert "black") "black"))
    (should (equal (erc-nicks-invert "green") "#ffff0000ffff"))))

(defun erc-nicks-tests--print-contrast (fn color)
  (let ((result (funcall fn color))
        (fg (if (eq 'dark erc-nicks--bg-mode-value) "white" "black"))
        (start (point)))
    (insert (format "%16s%-16s%16s%-16s\n"
                    (concat color "-")
                    (concat ">" result)
                    (concat color " ")
                    (concat " " result)))
    (put-text-property start (+ start 32) 'face
                       (list :foreground fg))
    (put-text-property (+ start 32) (+ start 48) 'face
                       (list :background color :foreground result))
    (put-text-property (+ start 48) (+ start 64) 'face
                       (list :background result :foreground color))
    result))

(ert-deftest erc-nicks-add-contrast ()
  (let ((erc-nicks--bg-luminance 1.0)
        (erc-nicks--bg-mode-value 'light)
        (show (lambda (c) (erc-nicks-tests--print-contrast
                           #'erc-nicks-add-contrast c))))

    (with-current-buffer (get-buffer-create "*erc-nicks-add-contrast*")
      (should (equal "#893a893a893a" (funcall show "white")))
      (should (equal "#893a893a893a" (funcall show "#893a893a893a")))
      (should (equal "#000000000000" (funcall show "black")))
      (should (equal "#ffff00000000" (funcall show "red")))
      (should (equal "#0000a12e0000" (funcall show "green")))
      (should (equal "#00000000ffff" (funcall show "blue")))

      ;; When the input is already near the desired ratio, the result
      ;; may not be in bounds, only close.  But the difference is
      ;; usually imperceptible.
      (unless noninteractive
        ;; Well inside (light slate gray)
        (should (equal "#777788889999" (funcall show "#777788889999")))
        ;; Slightly outside -> just outside
        (should (equal "#7c498bd39b5c" (funcall show "#88889999aaaa")))
        ;; Just outside -> just inside
        (should (equal "#7bcc8b479ac0" (funcall show "#7c498bd39b5c")))
        ;; Just inside
        (should (equal "#7bcc8b479ac0" (funcall show "#7bcc8b479ac0"))))

      (when noninteractive
        (kill-buffer)))))

(ert-deftest erc-nicks-cap-contrast ()
  (should (= 12.5 (cdr erc-nicks-contrast-ratio)))
  (let ((erc-nicks--bg-luminance 1.0)
        (erc-nicks--bg-mode-value 'light)
        (show (lambda (c) (erc-nicks-tests--print-contrast
                           #'erc-nicks-cap-contrast c))))

    (with-current-buffer (get-buffer-create "*erc-nicks-remove-contrast*")
      (should (equal (funcall show "black") "#34e534e534e5" )) ; 21.0 -> 12.14
      (should ; 12.32 -> 12.32 (same)
       (equal (funcall show "#34e534e534e5") "#34e534e534e5"))
      (should (equal (funcall show "white") "#ffffffffffff"))

      (unless noninteractive
        (should (equal (funcall show "DarkRed") "#8b8b00000000"))
        (should (equal (funcall show "DarkGreen") "#000064640000"))
        ;; 15.29 -> 12.38
        (should (equal (funcall show "DarkBlue") "#1cf11cf198b5"))

        ;; 12.50 -> 12.22
        (should (equal (funcall show "#33e033e033e0") "#34ab34ab34ab"))
        ;; 12.57 -> 12.28
        (should (equal (funcall show "#338033803380") "#344c344c344c"))
        ;; 12.67 -> 12.37
        (should (equal (funcall show "#330033003300") "#33cc33cc33cc")))

      (when noninteractive
        (kill-buffer)))))

;; Here is an example of how filters can steer us wrong (don't always
;; DTRT).  Two keys with similar names hash to very different values:
;;
;;   1) "awbLibera.Chat" -> #x1e3b5ca4edbc ; deep blue
;;   2) "twbLibera.Chat" -> #xdeb4c26934af ; yellow/orange
;;
;; But on a dark bg, (1) falls below `erc-nicks-invert's min threshold
;; and thus gets treated, becoming #xe1c4a35b1243, which is quite
;; close to and thus easily confused with (2).

(ert-deftest erc-nicks--hash ()
  (with-current-buffer (get-buffer-create "*erc-nicks--hash*")
    ;; Here, we're just using `erc-nicks-tests--show-contrast' for show.
    (let ((show (lambda (c) (erc-nicks-tests--print-contrast #'identity c))))

      ;; Similar nicks yielding similar colors is likely undesirable.
      (should (= (erc-nicks--hash "00000000") #xe4deaa6df385))
      (should (= (erc-nicks--hash "00000001") #xe4deaa6df386))
      (funcall show "#e4deaa6df385")
      (funcall show "#e4deaa6df386")

      ;; So we currently pad from the right to avoid this.
      (should (= (erc-nicks--hash "0Libera.Chat") #x32fdc0d63a92))
      (should (= (erc-nicks--hash "1Libera.Chat") #xc2c4f1c997f3))
      (funcall show "#32fdc0d63a92")
      (funcall show "#c2c4f1c997f3")

      (should (= (erc-nicks--hash "0       OFTC") #x6805b7521261))
      (should (= (erc-nicks--hash "1       OFTC") #xf7cce8456fc2))
      (funcall show "#6805b7521261")
      (funcall show "#f7cce8456fc2"))

    (when noninteractive
      (kill-buffer))))

;;; erc-nicks-tests.el ends here

debug log:

solving e0a5691b073 ...
found e0a5691b073 in https://yhetil.org/emacs-bugs/87v8gjrwwo.fsf__25148.7589253642$1684849113$gmane$org@neverwas.me/
found 756260d718d in https://yhetil.org/emacs-bugs/87ilcp1za1.fsf__10272.1162418433$1684420707$gmane$org@neverwas.me/

applying [1/2] https://yhetil.org/emacs-bugs/87ilcp1za1.fsf__10272.1162418433$1684420707$gmane$org@neverwas.me/
diff --git a/test/lisp/erc/erc-nicks-tests.el b/test/lisp/erc/erc-nicks-tests.el
new file mode 100644
index 00000000000..756260d718d


applying [2/2] https://yhetil.org/emacs-bugs/87v8gjrwwo.fsf__25148.7589253642$1684849113$gmane$org@neverwas.me/
diff --git a/test/lisp/erc/erc-nicks-tests.el b/test/lisp/erc/erc-nicks-tests.el
index 756260d718d..e0a5691b073 100644

Checking patch test/lisp/erc/erc-nicks-tests.el...
Applied patch test/lisp/erc/erc-nicks-tests.el cleanly.
Checking patch test/lisp/erc/erc-nicks-tests.el...
Applied patch test/lisp/erc/erc-nicks-tests.el cleanly.

skipping https://yhetil.org/emacs-bugs/87v8gjrwwo.fsf__25148.7589253642$1684849113$gmane$org@neverwas.me/ for e0a5691b073
index at:
100644 e0a5691b0735a513fcbbb707d2d69aeaff6c0b60	test/lisp/erc/erc-nicks-tests.el

(*) Git path names are given by the tree(s) the blob belongs to.
    Blobs themselves have no identifier aside from the hash of its contents.^

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).