From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Date: Wed, 16 Dec 2020 02:55:04 +0200 Message-ID: References: <87sg8b5k4b.fsf@gnus.org> <49481d0c-b101-8527-b468-ff295105c028@yandex.ru> <87wnxl50nn.fsf@gnus.org> <87r1ntzvw3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30938"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Lars Ingebrigtsen , 29193-done@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 16 01:57:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpL80-0007w9-14 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Dec 2020 01:57:16 +0100 Original-Received: from localhost ([::1]:43322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpL7y-0004jk-Ig for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Dec 2020 19:57:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpL7m-0004hW-FD for bug-gnu-emacs@gnu.org; Tue, 15 Dec 2020 19:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpL7m-0001jJ-89 for bug-gnu-emacs@gnu.org; Tue, 15 Dec 2020 19:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kpL7m-0006g7-5j for bug-gnu-emacs@gnu.org; Tue, 15 Dec 2020 19:57:02 -0500 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Dec 2020 00:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 29193 X-GNU-PR-Package: emacs Mail-Followup-To: 29193@debbugs.gnu.org, dgutov@yandex.ru, dgutov@yandex.ru Original-Received: via spool by 29193-done@debbugs.gnu.org id=D29193.160808016725606 (code D ref 29193); Wed, 16 Dec 2020 00:57:01 +0000 Original-Received: (at 29193-done) by debbugs.gnu.org; 16 Dec 2020 00:56:07 +0000 Original-Received: from localhost ([127.0.0.1]:59486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpL6t-0006ev-ML for submit@debbugs.gnu.org; Tue, 15 Dec 2020 19:56:07 -0500 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:38446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpL6n-0006eN-Ra for 29193-done@debbugs.gnu.org; Tue, 15 Dec 2020 19:56:06 -0500 Original-Received: by mail-wm1-f41.google.com with SMTP id g185so859720wmf.3 for <29193-done@debbugs.gnu.org>; Tue, 15 Dec 2020 16:56:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hGRbEbzStSsW7vbncO6ZUcIf00uO2WjE9Hccop1lZo8=; b=E4PA0K8ndC7RrJxm8+9CSPJxASptp6fbf4++n6AMsovkILMKOqdtNFULERdqXk3HND zy7d+V3lVidneyUTOf9O9sJ3k/SsBz8RofEBSbaSI8Xrmdy0vx61LODl47ewLQOrPcQm SZvFqmadQT97+X3sC/vqg4gK2Z9CUPGHJ84ziTODahUX5rFWuyTc0WA2iwTx/ubzxJb4 Totb97aaTZNebicQ02AbINb8sQmF1WAJEV5Nvx6NUyDKSJ6BispTHdz1hwZ5mCNq/FS1 EkN9JTgbqr7qIbNhHRy9vPxaRWUDShzmq4CoLb9tcRA+OPPqQ5q9/TjmfWyfL4CGesqH +DtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hGRbEbzStSsW7vbncO6ZUcIf00uO2WjE9Hccop1lZo8=; b=N9STcFRKGXYRljhOr9oZ9l7bGfqagVDYXE7z5fP5aTuoXANA+WW+7mr82vv2Of8lJ7 ymCgYQMAtgWytKVjrmZBcJqySdFLbxc1QlK5LXwiZ+7g8HBqSgtua1b/qUWwHfnyvWiD hjRaf1QoZd2zpPZXqI5xofjHdhITfEQBicibmYF4u9b4mc5kb9LtmdEI/36AqXg4LDSF K94Uiw5RvjZRfBVv8c6r+x3TY+aglrWx+JjiHsnDc8jRSORpQHH3VyaFkMqFhzSxvBva 8Dx1yJPViApn2JaaYtQMj8eaHgpsPLsD8fPNhHoQxpvwbLTJIpNckXWd3rZQOOWljDFC PHjg== X-Gm-Message-State: AOAM530H2pHLg6BiG6B2Y+6Fz+/AerWeyIBo56kGmkZI028bn2NdL/kP ypuEVe8zrxoGI57EmC1rqWgiW/XQsEYEGg== X-Google-Smtp-Source: ABdhPJwlEp31BsBNQBwz3GZOz3EgGt1zQrrYK04EQsez4nUKcZhsaskizVQT/t5CsYlbyh68SH3ADg== X-Received: by 2002:a7b:ca47:: with SMTP id m7mr935679wml.33.1608080155366; Tue, 15 Dec 2020 16:55:55 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j13sm171112wmi.36.2020.12.15.16.55.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 16:55:54 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196194 Archived-At: On 14.12.2020 13:03, João Távora wrote: > Feel free to push if you can't come up with anything better in ruby-mode. Pushed, and closing, thanks. Regarding "doing the fix in the proper place", the alternative would be changing the implementation of thing-at-point--end-of-sexp. But I'm not sure it's a well-defined function. It clearly special-cases characters with class "closing paren". And there's no clear counterpart for 'end' (even though it's a sexp closer in ruby-mode's syntax).