From: Drew Adams <drew.adams@oracle.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 19423-done@debbugs.gnu.org
Subject: bug#19423: 25.0.50; incompatible change to `make-obsolete' - added 3rd arg should be optional
Date: Sun, 21 Dec 2014 10:58:40 -0800 (PST) [thread overview]
Message-ID: <e02206f2-e555-4427-8d11-0c8710933e8b@default> (raw)
In-Reply-To: <867fxkdecx.fsf@yandex.ru>
> > In Emacs 23 someone unwisely changed it to mandatory, an
> > incompatible change that gratuitously breaks code that could
> > be used with older Emacs releases. Pain for no real gain.
>
> You should look at the code sometimes.
You should look at the byte-compiler warning that the user sees.
It tells her that only 2 args are present but 3 are *required*.
> The change is very much compatible: `make-obsolete' can still be
> called with only two arguments without error. The third one is only
> mandatory in the advertised calling convention.
See above. The byte-compiler tells you that it is mandatory.
> Even if it wasn't, it would be too late to fix the "problem": it
> wouldn't work in 23 and 24 anyway.
No, but it would work for Emacs 25, and releases prior to 23.
There is no good reason *not* to fix it, is there?
next prev parent reply other threads:[~2014-12-21 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 17:14 bug#19423: 25.0.50; incompatible change to `make-obsolete' - added 3rd arg should be optional Drew Adams
2014-12-21 17:19 ` Drew Adams
2014-12-21 18:53 ` Dmitry Gutov
2014-12-21 18:58 ` Drew Adams [this message]
2014-12-21 19:01 ` Drew Adams
2014-12-21 19:05 ` Dmitry Gutov
2014-12-21 20:33 ` Drew Adams
2014-12-21 20:39 ` Dmitry Gutov
2014-12-21 21:10 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e02206f2-e555-4427-8d11-0c8710933e8b@default \
--to=drew.adams@oracle.com \
--cc=19423-done@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).