From: Lennart Borgman <lennart.borgman@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 3467@emacsbugs.donarmstrong.com
Subject: bug#3467: 23.0.94; let + make-local-variable => let value made global
Date: Sun, 7 Jun 2009 03:11:23 +0200 [thread overview]
Message-ID: <e01d8a50906061811o172a9d01p4eda31a215ddd216@mail.gmail.com> (raw)
In-Reply-To: <e01d8a50906061311s77ad6eccm1bd0ad3e6d0a30ef@mail.gmail.com>
Rethinking. Everything is wrong in my solution and suggestion. Coming back.
On Sat, Jun 6, 2009 at 10:11 PM, Lennart
Borgman<lennart.borgman@gmail.com> wrote:
> On Sat, Jun 6, 2009 at 12:48 AM, Lennart
> Borgman<lennart.borgman@gmail.com> wrote:
>>
>> Sigh, and my suggestion was of course unnecessary stupid. What is
>> needed is of course to record values and frame+buffer localness and
>> dito values and reset them. Nothing less than this will ever work
>> correctly, or?
>>
>> And does not this apply to all uses of specbind + unbind_to?
>>
>> Can it be sufficient to just change specbind and unbind_to? Is there
>> anything else that will be affected by changes in the specbind stack?
>> Since info about buffer+frame is alwas needed should specbinding be
>> changed to the below form?
>>
>> struct specbinding
>> {
>> Lisp_Object symbol;
>> Lisp_Object old_value;
>> Lisp_Object old_buffer_value;
>> Lisp_Object old_frame_value;
>> specbinding_func func;
>> Lisp_Object unused; /* Dividing by 16 is faster than by 12 */
>> Lisp_Object unused;
>> Lisp_Object unused;
>> };
>
> Here is a bit modified suggestion and some code where I try to
> implement it. Please notice that I have not tested the code. It is
> very possible that I have misunderstood something so please look at
> the code.
>
> struct specbinding
> {
> Lisp_Object symbol;
> Lisp_Object old_value;
> specbinding_func func;
> // total 8 fields
> Lisp_Object need_test_local;
> Lisp_Object old_buffer;
> Lisp_Object old_buffer_value;
> Lisp_Object old_frame;
> Lisp_Object old_frame_value;
> //Lisp_Object unused; /* Dividing by 16 is faster than by 12 */
> };
>
next prev parent reply other threads:[~2009-06-07 1:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 21:14 bug#3467: 23.0.94; let + make-local-variable => let value made global Lennart Borgman
2009-06-05 14:21 ` Lennart Borgman
2009-06-05 14:36 ` Stefan Monnier
2009-06-05 15:04 ` Lennart Borgman
2009-06-05 22:48 ` Lennart Borgman
2009-06-05 23:08 ` Lennart Borgman
2009-06-05 23:32 ` Lennart Borgman
2009-06-06 20:11 ` Lennart Borgman
2009-06-07 1:11 ` Lennart Borgman [this message]
2009-06-12 22:24 ` Lennart Borgman
2009-06-27 0:24 ` bug#3467: 23.0.94; let + make-local-variable => let value made Stefan Monnier
2009-06-06 20:05 ` bug#3467: 23.0.94; let + make-local-variable => let value made global Richard Stallman
2009-06-06 20:13 ` Lennart Borgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e01d8a50906061811o172a9d01p4eda31a215ddd216@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=3467@emacsbugs.donarmstrong.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).