From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#28385: ert "should" macros to not be globally visible Date: Thu, 07 Sep 2017 14:24:02 -0400 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1504808782 32256 195.159.176.226 (7 Sep 2017 18:26:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 7 Sep 2017 18:26:22 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) To: 28385@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 07 20:26:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dq1Uc-0006TC-3x for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Sep 2017 20:25:34 +0200 Original-Received: from localhost ([::1]:41683 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dq1Uj-00085R-7A for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Sep 2017 14:25:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dq1UD-0007oJ-NU for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2017 14:25:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dq1U6-0002lE-99 for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2017 14:25:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45963) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dq1U6-0002l4-6T for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2017 14:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dq1U5-0008Gp-UX for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2017 14:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2017 18:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28385 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: submit@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.150480865731731 (code B ref -1); Thu, 07 Sep 2017 18:25:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Sep 2017 18:24:17 +0000 Original-Received: from localhost ([127.0.0.1]:54644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dq1TM-0008Fj-Pz for submit@debbugs.gnu.org; Thu, 07 Sep 2017 14:24:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dq1TJ-0008FP-6q for submit@debbugs.gnu.org; Thu, 07 Sep 2017 14:24:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dq1T9-0002Qg-H7 for submit@debbugs.gnu.org; Thu, 07 Sep 2017 14:24:08 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dq1T9-0002QX-Dn for submit@debbugs.gnu.org; Thu, 07 Sep 2017 14:24:03 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dq1T9-0002WN-1W; Thu, 07 Sep 2017 14:24:03 -0400 X-Spook: Power Jet Steve Case Drug BART kibo Home grown EuroFed X-Ran: tN+mXz`1g)}(r!,vY%gE|5:~c%^(rT;bM{yeQ{4%yhQ;5W/:`iwT]RX|#Wdl~0FV2&mjkr X-Hue: green X-Attribution: GM X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136663 Archived-At: Package: emacs Version: 25.2 Severity: wishlist emacs -Q -l ert Now "should", "should-not", and "should-error" are globally defined as macros (with no "ert-" prefix). They are only useful inside ert-deftests. Perhaps they should steal a trick from the similar "skip-unless", which is not globally visible. The global definition is "ert--skip-unless", and the ert-deftest macro basically makes "skip-unless" an alias for this inside the body of a test. This seems cleaner.