From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.bugs Subject: Re: ediff-regions-internal can't handle (non-overlapping) regions in the same buffer Date: Fri, 09 Dec 2005 09:47:40 -0700 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1134156831 21315 80.91.229.2 (9 Dec 2005 19:33:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 9 Dec 2005 19:33:51 +0000 (UTC) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 09 20:33:44 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Eknzl-0008Aw-S2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Dec 2005 20:33:30 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Eko07-0005Xu-Ao for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Dec 2005 14:33:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EklWa-00036j-EW for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2005 11:55:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EklWT-000357-V7 for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2005 11:55:09 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EklWT-00034x-7s for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2005 11:55:05 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1EklXg-0006uQ-U0 for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2005 11:56:21 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1EklRl-0007Sh-Hz for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2005 17:50:13 +0100 Original-Received: from 207.167.42.60 ([207.167.42.60]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 09 Dec 2005 17:50:13 +0100 Original-Received: from ihs_4664 by 207.167.42.60 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 09 Dec 2005 17:50:13 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: bug-gnu-emacs@gnu.org Original-Lines: 18 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 207.167.42.60 User-Agent: Mozilla Thunderbird 0.9 (X11/20041105) X-Accept-Language: en-us, en In-Reply-To: X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:14567 Archived-At: Kevin Rodgers wrote: > I'm working on a way to take advantage of Ediff's fine highlighting > feature within Diff mode buffers. But calling ediff-regions-internal > programmatically with BUFFER-A the same as BUFFER-B doesn't work, > leaving only the region between BEG-B and END-B highighted. This is > because ediff-extract-diffs first resets point in both buffers (changing > point in BUFFER-A unintentionally), then builds the diff vector by > moving by lines in each buffer. > > The fix is simple, and it allows ediff-regions-internal to work with > non-overlapping regions in the same buffer: Don't set point in each > buffer until necessary: Sorry, that patch breaks Ediff horribly. I'll get to work on a proper fix. -- Kevin