unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 30285@debbugs.gnu.org, jidanni@jidanni.org
Subject: bug#30285: dired-do-chmod vs. top line of dired
Date: Wed, 31 Jan 2018 11:04:46 -0800 (PST)	[thread overview]
Message-ID: <dfc3956f-fc5c-4567-adf8-9c2878ab7a17@default> (raw)
In-Reply-To: <alpine.DEB.2.20.1801311844520.25546@calancha-pc>

> > Obviously, for `dired-do-*' commands we still need to
> > handle the case where files or dirs are marked.  And
> > in that case the command should DTRT even if called from
> > a non-file line, i.e., one of the problematic places
> > we've been discussing - it should not raise an error
> > in that context.
>
> IIRC, my latest patch handle those situations pretty well.
> Could you tested it and provide feedback about how to
> improve it?
> 
> > For `dired-do-*' commands that already call
> > `dired-get-marked-files' the clear solution, I think,
> > is to just test that return value and raise an error
> > if it is nil.
> >
> > If there are `dired-do-*' commands that do not call
> > `dired-get-marked-files' then we have a choice how to
> > solve the problem.  But it might well be that even then
> > the best solution is to use `dired-get-marked-files'.
>
> Since you are reluctant to the addition of the new predicate.
> That's fine.
>
> May I ask you to provide an alternative  patch to compare
> with mine? Then, people here might do further feedback based
> on those 2 alternatives.

Sorry; I don't have time to work on this.  I've already
provided my suggestions - hope they help. Whatever you
decide is fine by me.  Thx.





  reply	other threads:[~2018-01-31 19:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29 12:32 bug#30285: dired-do-chmod vs. top line of dired 積丹尼 Dan Jacobson
2018-01-29 15:14 ` Tino Calancha
2018-01-29 16:05   ` Eli Zaretskii
2018-01-29 23:21     ` Tino Calancha
2018-01-29 23:42       ` Drew Adams
2018-01-30  3:53         ` Tino Calancha
2018-01-30  4:43           ` Drew Adams
2018-01-30 15:15             ` Drew Adams
2018-01-31  9:49               ` Tino Calancha
2018-01-31 19:04                 ` Drew Adams [this message]
2018-01-31 21:35         ` Juri Linkov
2018-01-31 23:20           ` Drew Adams
2018-02-01  8:16           ` Tino Calancha
2018-02-01  9:17             ` Tino Calancha
2018-02-01 16:10             ` Drew Adams
2018-02-04 23:12               ` Tino Calancha
2018-02-05 16:45                 ` Drew Adams
2018-02-01 20:07             ` Juri Linkov
2018-02-01 20:50               ` Drew Adams
2018-02-01 21:35                 ` Juri Linkov
2018-02-01 22:23                   ` Drew Adams
2018-02-03 22:23                     ` Juri Linkov
2018-02-04 10:02                       ` martin rudalics
2018-02-04 21:44                         ` Juri Linkov
2018-02-06 21:32                         ` Juri Linkov
2018-02-04 23:08                   ` Tino Calancha
2018-02-05 21:01                     ` Juri Linkov
2018-02-05 21:52                       ` Drew Adams
2018-01-29 15:24 ` 積丹尼 Dan Jacobson
2018-01-29 23:14   ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfc3956f-fc5c-4567-adf8-9c2878ab7a17@default \
    --to=drew.adams@oracle.com \
    --cc=30285@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).