unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Kangas <stefan@marxist.se>, Eli Zaretskii <eliz@gnu.org>
Cc: 39848@debbugs.gnu.org
Subject: bug#39848: 26.3; Provide better help for menu-bar, e.g., Options > Line Wrapping in This Buffer
Date: Sun, 1 Mar 2020 09:34:47 -0800 (PST)	[thread overview]
Message-ID: <df8fe907-69c4-4bd3-97fd-58a3ea0b4c72@default> (raw)
In-Reply-To: <8736as67qh.fsf@stefankangas.se>

> unarchive 13841
> forcemerge 13841 39848
> thanks
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > This is already fixed in Emacs 27.
> 
> Indeed, so I'm merging this bug with the previous one.

Yes, thanks.  I didn't realize this is essentially
a duplicate.

Is this taken care of _generally_, as requested
in #39848, or is it just taken care of for items
in this menu?

If fixed generally, then I guess it can be closed.

---

However, I do have a remark about what I see in
Emacs 27 (a dev snapshot from 2019-12-28):

 <menu-bar> <options> <line-wrapping> <window-wrap> runs the command
 menu-bar--wrap-long-lines-window-edge (found in global-map), which is
 an interactive compiled Lisp function in 'menu-bar.el'.

 It is bound to <menu-bar> <options> <line-wrapping> <window-wrap>.

 (menu-bar--wrap-long-lines-window-edge)

 Wrap long lines at window edge.

Command `menu-bar--wrap-long-lines-window-edge'
is precisely the kind of command that a user
might use, either directly or in lisp code.

So I really don't see why it's considered
"internal" (double-hyphen name).

I also don't see why it's in menu-bar.el or
it has prefix `menu-bar-'.  There's nothing
menu-specific about it.

Not only that, but unlike what menu `Options'
has generally been for, this item does not
just toggle a single user option value.  It
toggles two options and turns off a minor
mode.

Perhaps there are other considerations, but
at least on the face of it this command (and
its sister commands here) doesn't seem to
belong in menu-bar.el, and it may not belong
in menu `Options' either.






  reply	other threads:[~2020-03-01 17:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-01  0:46 bug#39848: 26.3; Provide better help for menu-bar, e.g., Options > Line Wrapping in This Buffer Drew Adams
2020-03-01  3:41 ` Eli Zaretskii
2020-03-01  4:04   ` Stefan Kangas
2020-03-01 17:34     ` Drew Adams [this message]
2020-03-01 17:53       ` Eli Zaretskii
     [not found] <<62a1ef4d-e9fa-4757-977d-dcb9d3e4aa52@default>
     [not found] ` <<834kv8eo7q.fsf@gnu.org>
     [not found]   ` <<8736as67qh.fsf@stefankangas.se>
     [not found]     ` <<df8fe907-69c4-4bd3-97fd-58a3ea0b4c72@default>
     [not found]       ` <<83pndwynak.fsf@gnu.org>
2020-03-01 21:50         ` Drew Adams
2020-03-02  8:00           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df8fe907-69c4-4bd3-97fd-58a3ea0b4c72@default \
    --to=drew.adams@oracle.com \
    --cc=39848@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).