unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Christoph Scholtes <cschol2112@googlemail.com>, 9867@debbugs.gnu.org
Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook
Date: Fri, 23 Aug 2019 10:42:32 +0200	[thread overview]
Message-ID: <ddc46ca9-abcf-0a7d-9f29-573f6a7cac56@gmx.at> (raw)
In-Reply-To: <87a7c0cnn2.fsf@gnus.org>

 > That's true, but is there a use case for the hook function having to
 > know what window it's quitting?

I don't know.  But you could replace 'with-current-buffer' with
'with-selected-window' to avoid worrying about that (and better check
if WINDOW is not already selected before doing that internal state
saving rigmarole).  Or, as I suggested earlier, run the hook only when
quitting the selected window.

martin





  reply	other threads:[~2019-08-23  8:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25  4:04 bug#9867: 24.0.90; quit-window should provide quit-window-hook Christoph Scholtes
2019-08-20  2:22 ` Lars Ingebrigtsen
2019-08-20  8:19   ` martin rudalics
2019-08-20 14:25     ` Eli Zaretskii
2019-08-21 20:23       ` Lars Ingebrigtsen
2019-08-21 20:18     ` Lars Ingebrigtsen
2019-08-22  8:08       ` martin rudalics
2019-08-23  0:08         ` Lars Ingebrigtsen
2019-08-23  7:46           ` martin rudalics
2019-08-23  8:05             ` Lars Ingebrigtsen
2019-08-23  8:42               ` martin rudalics [this message]
2019-08-25  5:24                 ` Lars Ingebrigtsen
2019-08-25  8:11                   ` martin rudalics
2019-08-30  9:40                     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddc46ca9-abcf-0a7d-9f29-573f6a7cac56@gmx.at \
    --to=rudalics@gmx.at \
    --cc=9867@debbugs.gnu.org \
    --cc=cschol2112@googlemail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).