From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#60691: 29.0.60; Slow tree-sitter font-lock in ruby-ts-mode Date: Wed, 11 Jan 2023 14:12:06 +0200 Message-ID: References: <867cxv3dnn.fsf@mail.linkov.net> <51ee2f6f-6e1d-eccd-f536-461d916cc94d@yandex.ru> <86leman71u.fsf@mail.linkov.net> <4ed5051c-ea5a-91b1-6b8c-5349a3495a16@yandex.ru> <86tu0yqnwr.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3481"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: Yuan Fu , 60691@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 11 13:13:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFZyv-0000i1-L0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Jan 2023 13:13:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFZyb-0002m5-E1; Wed, 11 Jan 2023 07:13:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFZyY-0002lj-RK for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 07:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFZyY-0006Qo-G9 for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 07:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFZyY-0002iZ-1w for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 07:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Jan 2023 12:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60691 X-GNU-PR-Package: emacs Original-Received: via spool by 60691-submit@debbugs.gnu.org id=B60691.167343914010371 (code B ref 60691); Wed, 11 Jan 2023 12:13:02 +0000 Original-Received: (at 60691) by debbugs.gnu.org; 11 Jan 2023 12:12:20 +0000 Original-Received: from localhost ([127.0.0.1]:41850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFZxr-0002hD-UR for submit@debbugs.gnu.org; Wed, 11 Jan 2023 07:12:20 -0500 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:56299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFZxo-0002gv-6u for 60691@debbugs.gnu.org; Wed, 11 Jan 2023 07:12:18 -0500 Original-Received: by mail-wm1-f47.google.com with SMTP id l26so10940024wme.5 for <60691@debbugs.gnu.org>; Wed, 11 Jan 2023 04:12:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=r/dqXjaqPACUM8T6HzTmldIJgBC3gYahWG0LRqnobaE=; b=E1NuJ7q9CT91Z5wPrmAGiQYwFVMrXE3FCF9rH/ty3V8nBu3aaGPbd4slClsF2WLMxU JAnDJ/6YR/+W3DJ+1CMdWhq3+wl6yUd2SkDUGrT/oEisCM+JjGqr6Vje73vFpCO/nirx IvcqkRnSCjGPD4Tl5+Y/CADiBiscwHuM/mOtcnyixNjw7xxaOw+ax07xYH6h8S4075ey dGubsj4IsOSGGWQ1KKoKJkAHMw4s8WqY1dr4VN4PQ9858nkhpmjz7uCn+Fs7ld1r6YvG QrbBcUOQXNxVkbe+LVayPElKm54E/KN/x/kX6aGEYWnpS9JQpp+e1rZlFXFhmg7y1hwH 3P9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r/dqXjaqPACUM8T6HzTmldIJgBC3gYahWG0LRqnobaE=; b=jVzrMFEbpLDp03pnJDZmfiA95j7zr+Clzc5ic15W4fZSFM0cMtDrKsb27Iu4OLG7Sl 9PJMcAbRap5vswhPjztES1BXta43ETlZT2kGOLhXSkUIqOBFfN9hX5a6je+Cd5x6JHUD frIaqMtLcow5fEvRLo/OyInoixpm7VW1/JcEci3U93lvb8WDC97DAFY6XOfYqLziBrNC Aujaz11KNCh4YR34EcL1fM/kzOG8molU61kD8t5FCB44FsGCLA0ULIB6NqqSRNwwuABd +p6BXeTQA0bCAGnelpXQ/bXXNJV2CFe17ivANYsPCahWO7JLz44Zgawgs6bNO+LSdda1 rKug== X-Gm-Message-State: AFqh2kq69iy+F0qzBM2mWHYKRhqFPtIKoW2d+N8mtmqgdl0HSGxLy8Vd qu0JrHEYgn+r1e3UT1pxEs4= X-Google-Smtp-Source: AMrXdXuO5Z0p/z3o7HMYwqaVdRD/nYqwEHixlgivPZSyu6BqB1biVzoSO7OxSjc/p2z6+KqzAtUyKg== X-Received: by 2002:a05:600c:4e48:b0:3cf:69f4:bfd4 with SMTP id e8-20020a05600c4e4800b003cf69f4bfd4mr53607359wmq.7.1673439129168; Wed, 11 Jan 2023 04:12:09 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l36-20020a05600c1d2400b003d9fb59c16fsm5362760wms.11.2023.01.11.04.12.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 04:12:08 -0800 (PST) Content-Language: en-US In-Reply-To: <86tu0yqnwr.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253140 Archived-At: On 10/01/2023 19:50, Juri Linkov wrote: >>>> Is it common to try to highlight 1000 or even 100 files in one diff? >>> 100 is rare, but tens is pretty common, so this problem affects >>> only this specific case. >> >> So it's a 0,8-3s delay in those cases? That's not ideal. > > The delay is noticeable, alas. Right. I'm somewhat worried for the processing speed xref--collect-matches too. But that's probably only going to be noticeable after we add syntax-propertize-function to ruby-ts-mode. >>> I noticed that while most library files are small, e.g. >>> libtree-sitter-c.so is 401,528 bytes, >>> libtree-sitter-ruby.so is 2,130,616 bytes >>> that means that it has more complex logic >>> that might explain its performance. >> >> ruby is indeed one of the larger ones. Among the ones I have here compiled, >> it's exceeded only by cpp. 2.29 MB vs 2.12 MB. > > The winner is libtree-sitter-julia.so with 7.25 MB. > But regarding libtree-sitter-cpp.so I confirm it's 2.3 MB. > And c++-ts-mode is even faster than c-ts-mode. Yep. > On the same admin/alloc-colors.c: > > c-mode > (33.378821569 1500 17.632000617) > > c-ts-mode > (2.1949608069999997 34 0.4119784769999981) > > c++-ts-mode > (2.0979403910000003 34 0.39749122499999956) > > So size doesn't matter.