bug#74255: 30.0.91; artist-mode right to left input introduces gaps

bug#74255: 30.0.91; artist-mode right to left input introduces gaps

[Van Ly via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]


Hello,

Drawing a rectangle in artist-mode going in the directions

 . down
 . left to right
 . up
 . right to left

introduces gaps unexpectedly at the final closing top side.  See,

=> http://sdf.org/~van.ly/img/emacs-30-0-91-artist-mode-rectangle-draw.jpeg .

To demonstrate,

 1. start, emacs -Q
 2. open buffer and activate artist-mode
    a. C-x b a RET
    b. M-x artist-mode
 3. draw line going down
    a. C-c .
    b. type +, type 40 .
 4. draw line going left to right
    a. C-c >
    b. type +, type 40 .
 5. draw line going up
    a. C-c ^
    b. type +, type 40 .
 6. draw line going right to left
    a. C-c <
    b. type +, type 40 .
    c. gaps are introduced between sequences of .

Expected result is a rectangle with no gaps on the top side.



[-- Attachment #2: bug gnu emacs report --]
[-- Type: application/octet-stream, Size: 4584 bytes --]

From: xxx@xxx.mail-host-address-is-not-set
To: bug-gnu-emacs@gnu.org
Subject: 30.0.91; x
X-Debbugs-Cc: 
--text follows this line--




In GNU Emacs 30.0.91 (build 2, x86_64--netbsd, X toolkit, cairo version
 1.18.0) of 2024-09-27 built on xxx
Windowing system distributor 'The X.Org Foundation', version 11.0.12101014
System Description: NetBSD xxx 10.0_STABLE NetBSD 10.0_STABLE (GENERIC) #1: Thu Nov  7 15:18:42 AEDT 2024  xxx@xxx:/xxx/sys/arch/amd64/compile/GENERIC amd64

Configured using:
 'configure --srcdir=/u/xxx/src/emacs/30.0.91 --localstatedir=/var
 --disable-autodepend --with-native-compilation --without-ns --with-rsvg
 --without-imagemagick --without-xaw3d --without-toolkit-scroll-bars
 --x-includes=/usr/X11R7/include --x-libraries=/usr/X11R7/lib
 --with-x-toolkit=lu --prefix=/usr/local --build=x86_64--netbsd
 --host=x86_64--netbsd --infodir=/usr/pkg/info --mandir=/usr/pkg/man
 --enable-option-checking=yes 'CFLAGS=-O2 -I/usr/pkg/include/cairo
 -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/freetype2
 -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0
 -I/usr/pkg/lib/glib-2.0/include -I/usr/X11R7/include
 -I/usr/pkg/include/harfbuzz -I/usr/X11R7/include/libdrm'
 'CPPFLAGS=-DTERMINFO -I/usr/pkg/include -I/usr/include
 -I/usr/pkg/include/freetype2 -I/usr/pkg/include/glib-2.0
 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include
 -I/usr/X11R7/include -I/usr/pkg/include/harfbuzz
 -I/usr/X11R7/include/libdrm' 'LDFLAGS=-Wl,-R/usr/pkg/gcc13/lib
 -Wl,-zrelro -L/usr/pkg/lib -lcairo -L/usr/lib -Wl,-R/usr/lib
 -Wl,-R/usr/pkg/lib -L/usr/X11R7/lib -Wl,-R/usr/X11R7/lib
 -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -lgnutls''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GNUTLS GSETTINGS HARFBUZZ JPEG LCMS2
LIBOTF LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE PDUMPER PNG RSVG SOUND
SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM LUCID
ZLIB

Important settings:
  value of $LC_COLLATE: en_AU.UTF-8
  value of $LC_CTYPE: en_AU.UTF-8
  value of $LC_MESSAGES: en_AU.UTF-8
  value of $LC_MONETARY: en_AU.UTF-8
  value of $LC_NUMERIC: en_AU.UTF-8
  value of $LC_TIME: en_AU.UTF-8
  value of $LANG: en_AU.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Picture:left

Minor modes in effect:
  artist-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils compile
text-property-search comint subr-x ansi-osc ansi-color ring comp-run
bytecomp byte-compile comp-common rx artist picture reporter rect rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt
fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode
register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind kqueue lcms2 dynamic-setting system-font-setting
font-render-setting cairo x-toolkit xinput2 x multi-tty move-toolbar
make-network-process native-compile emacs)

Memory information:
((conses 16 70114 8809) (symbols 48 7285 0) (strings 32 19750 5112)
 (string-bytes 1 596978) (vectors 16 12952)
 (vector-slots 8 152439 5489) (floats 8 37 1) (intervals 56 345 0)
 (buffers 992 12))

[-- Attachment #3: Type: text/plain, Size: 9 bytes --]



-- 
vl

bug#74255: 30.0.91; artist-mode right to left input introduces gaps

[Eli Zaretskii]

> Date: Fri, 08 Nov 2024 12:06:55 +0000
> From:  Van Ly via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Drawing a rectangle in artist-mode going in the directions
> 
>  . down
>  . left to right
>  . up
>  . right to left
> 
> introduces gaps unexpectedly at the final closing top side.  See,
> 
> => http://sdf.org/~van.ly/img/emacs-30-0-91-artist-mode-rectangle-draw.jpeg .
> 
> To demonstrate,
> 
>  1. start, emacs -Q
>  2. open buffer and activate artist-mode
>     a. C-x b a RET
>     b. M-x artist-mode
>  3. draw line going down
>     a. C-c .
>     b. type +, type 40 .
>  4. draw line going left to right
>     a. C-c >
>     b. type +, type 40 .
>  5. draw line going up
>     a. C-c ^
>     b. type +, type 40 .
>  6. draw line going right to left
>     a. C-c <
>     b. type +, type 40 .
>     c. gaps are introduced between sequences of .
> 
> Expected result is a rectangle with no gaps on the top side.

This was because in Emacs 25 picture-mode started to use string-width,
which is inaccurate when TAB characters are inserted into the buffer.

Now fixed on the emacs-30 release branch.