From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Date: Mon, 8 Feb 2021 17:54:17 +0200 Message-ID: References: <87czxc5cku.fsf@protesilaos.com> <83tuqnnc3s.fsf@gnu.org> <87pn1b4zxp.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10194"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 46358@debbugs.gnu.org To: Protesilaos Stavrou , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 08 22:34:54 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9EBK-0002XV-L0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 22:34:54 +0100 Original-Received: from localhost ([::1]:47206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9EBJ-0002eu-L9 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 16:34:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l98sQ-0003Yu-E5 for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 10:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l98sQ-0006BM-6n for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 10:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l98sQ-0002p5-4m for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 10:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2021 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 46358-submit@debbugs.gnu.org id=B46358.161279967010810 (code B ref 46358); Mon, 08 Feb 2021 15:55:02 +0000 Original-Received: (at 46358) by debbugs.gnu.org; 8 Feb 2021 15:54:30 +0000 Original-Received: from localhost ([127.0.0.1]:51734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l98ru-0002oI-7q for submit@debbugs.gnu.org; Mon, 08 Feb 2021 10:54:30 -0500 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:37063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l98rq-0002o3-Dt for 46358@debbugs.gnu.org; Mon, 08 Feb 2021 10:54:29 -0500 Original-Received: by mail-wr1-f45.google.com with SMTP id v15so17742186wrx.4 for <46358@debbugs.gnu.org>; Mon, 08 Feb 2021 07:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wEpQdkFTQSZ6r3tp6V6Sq2lIo3c4ksaxm6W6+qskI5Q=; b=SaAKGuwJIU5GekZINqFR39i+8fRPLdF9SznBbDNB/nVAsRGo3WIP/uaxL+vdUe497z sODSZu3CcfJgZLape7RmXb66bj7HxjEUnXWZaNBdM5ecnCb2+saLpbfoJlSRy974WDcr TV8usXRLU4Llae662lilVLYH6MNiabU+yN2if0N4zRjxhtVGF+pBB7vAcO0PrCjV6bYk JGpkwktiMDG7m6YyzvJe4HfSnQBpcR9qWuf2CNkugXKeOa0Yt0DVBLpe7TOzjt4DSrxP XXxJh6FJVy3AiRzIKTPWrhGhqVei5TaeMcUra6beaWFvpq5dACtZl2egkDZJpkOGZB5C pI+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wEpQdkFTQSZ6r3tp6V6Sq2lIo3c4ksaxm6W6+qskI5Q=; b=o6bKj87v99Q8U2yDqcAT8UV4vACAwenhMLfxWaqWmlwk8HdkcU5/JoYk34EFgdthhK 0L4L7osE+PIcf3E2lLUXGtH4obEJ63EeDkMeat2zB5slppmr0vUXubPdgnDPd1uShvrS /UIM4gOQ3BJEVnDIPBfYzvOFtwtyfPW/noKDxiHfaVz8Q7T/yIpF0hiahJmJC3uJtSoL 1QyTv4e/id6TJq2GOn/5KZKNbFtKlV6iPj0mvG/6d9bWI4/4Jwv3ie/rJjb6wUAVMdJi iVtr5NH45R3aYxNZdcmh4swHZl5vIqeRTHiRKiLOAJuj+yZugiASIjiFLilVVQHbqKac E73Q== X-Gm-Message-State: AOAM531C6AIV2O+XqNAHDx6vvq7Qk2bOYkN7heNpaO8hsQN9oHQrjRif itaCjGIh9oHE5w6zwoamlZGgvgKTOgU= X-Google-Smtp-Source: ABdhPJxR5g/bGFV7WCvYC0xNhZuZE4i1JbQ36pLvW3rDcMhNnOrxrNBmJoZdp/Zeg3ofT0WZYualNQ== X-Received: by 2002:a5d:4a0d:: with SMTP id m13mr20633245wrq.395.1612799660204; Mon, 08 Feb 2021 07:54:20 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f7sm28991672wre.78.2021.02.08.07.54.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Feb 2021 07:54:19 -0800 (PST) In-Reply-To: <87pn1b4zxp.fsf@protesilaos.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199623 Archived-At: On 07.02.2021 18:15, Protesilaos Stavrou wrote: > On 2021-02-07, 17:15 +0200, Eli Zaretskii wrote: > >>> From: Protesilaos Stavrou >>> Date: Sun, 07 Feb 2021 13:42:09 +0200 >>> >>> In the attached patch, I do the following: >>> >>> 1. Define new faces. Each has semantic value in that it applies to >>> constructs implied by its name. >> >> Thanks. Would it be possible to use color names rather than #RRGGBB >> values? The latter makes it very hard to figure out the color that >> will be used by the face. > > I will keep this in mind for the next time. For this case I removed all > color specifications (please find the revised patch attached to this > message). Thanks, this is better. I'm not opposed to changing colors, but this probably should be done systematically across many faces in the default theme, rather than in one specific UI element. Shouldn't it? >>> 4. Use new color combinations which conform with the WCAG AAA standard >>> for color contrast against pure white/black (this standard pertains >>> to legibility and is the highest of its kind). >> >> Not sure what that means in practical terms: most Emacs users I've >> watched working (myself included) use some background color other than >> pure black or white. Doesn't that change the contrast and the optimal >> colors? > > You are right: I should have clarified that I meant the default white > background and its inverse. Other themes would indeed have to adapt > things to their needs. True. >>> With regard to point 2, I only use Git and thus cannot test the other >>> backends with the requisite degree of confidence. Do you think I should >>> try regardless? Or should we just support the Git backend and hope that >>> someone else will work on [some of] the other backends? >> >> If you can easily try other backends, it will be appreciated. But it >> is not mandatory, IMO. > > I will inspect their code and try to identify whatever looks the same as > vc-git. Then I will prepare a separate patch. FWIW, Git is the only backend that has a complex dir-printer method. The rest look pretty much like vc-hg-dir-printer, but 'font-lock-comment-face' in there should be changed to some new face too. >> Personally, I think inheriting from the existing faces will be less >> drastic, so it's probably better. > > Very well! I am doing just that in the revised patch. So there should > be no visual difference between this and the prior state, except for one > case: the empty Git stash header, which will ultimately inherit from > 'shadow' (before there was a "FIXME" to disambiguate it from other > header values). Some questions: - vc-dir-ignored face doesn't seem to be used the 'ignored' entries in the list. Wasn't that its main point? - vc-git-dir-printer defaults entries to the 'vc-dir-status-edited' face, whereas vc-default-dir-printer defaults to vc-dir-header-value' (statuses that are not 'up-to-date', 'missing', 'conflict' or 'edited'). Which is the intended behavior? Which one do we want?