unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#66051: 30.0.50; shell-indirect-setup-hook has wrong :type
@ 2023-09-17 12:58 Mauro Aranda
  2023-09-17 13:01 ` Mauro Aranda
  0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-09-17 12:58 UTC (permalink / raw)
  To: 66051

shell-indirect-setup-hook is a hook, but its :type says it's a boolean.






^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#66051: 30.0.50; shell-indirect-setup-hook has wrong :type
  2023-09-17 12:58 bug#66051: 30.0.50; shell-indirect-setup-hook has wrong :type Mauro Aranda
@ 2023-09-17 13:01 ` Mauro Aranda
  2023-09-17 13:09   ` Stefan Kangas
  0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-09-17 13:01 UTC (permalink / raw)
  To: 66051

[-- Attachment #1: Type: text/plain, Size: 39 bytes --]

tags 66051 patch
quit


Patch attached.

[-- Attachment #2: 0001-Fix-shell-indirect-setup-hook-type-Bug-66051.patch --]
[-- Type: text/x-patch, Size: 837 bytes --]

From aac10ddb2d97562d1f03ef19c2e5b56446678001 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Sun, 17 Sep 2023 10:00:20 -0300
Subject: [PATCH] Fix shell-indirect-setup-hook :type (Bug#66051)

* lisp/shell.el (shell-indirect-setup-hook): It's a hook, not a
boolean.
---
 lisp/shell.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/shell.el b/lisp/shell.el
index 084113c673a..21ffdc63a05 100644
--- a/lisp/shell.el
+++ b/lisp/shell.el
@@ -327,9 +327,8 @@ shell-indirect-setup-hook
 buffer as the current buffer after its setup is done.  This can
 be used to further customize fontification and other behavior of
 the indirect buffer."
-  :type 'boolean
+  :type 'hook
   :group 'shell
-  :safe 'booleanp
   :version "29.1")
 
 (defcustom shell-highlight-undef-enable nil
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#66051: 30.0.50; shell-indirect-setup-hook has wrong :type
  2023-09-17 13:01 ` Mauro Aranda
@ 2023-09-17 13:09   ` Stefan Kangas
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2023-09-17 13:09 UTC (permalink / raw)
  To: Mauro Aranda, 66051-done

Version: 29.1

Mauro Aranda <maurooaranda@gmail.com> writes:

> Patch attached.

Thanks, installed on emacs-29 (commit b74d9e8bad9).





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-17 13:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-17 12:58 bug#66051: 30.0.50; shell-indirect-setup-hook has wrong :type Mauro Aranda
2023-09-17 13:01 ` Mauro Aranda
2023-09-17 13:09   ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).