From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#41974: 28.0.50; Some vc commands refuse to work when called on non-file buffer Date: Sun, 21 Jun 2020 03:07:40 +0300 Message-ID: References: <87a70x8f7g.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="62909"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 To: Juri Linkov , 41974@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 21 02:08:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmnWs-000GHy-79 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jun 2020 02:08:10 +0200 Original-Received: from localhost ([::1]:42154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmnWq-0001cy-RP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Jun 2020 20:08:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmnWk-0001cZ-2f for bug-gnu-emacs@gnu.org; Sat, 20 Jun 2020 20:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jmnWj-0002e2-Od for bug-gnu-emacs@gnu.org; Sat, 20 Jun 2020 20:08:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jmnWj-0002WE-JD for bug-gnu-emacs@gnu.org; Sat, 20 Jun 2020 20:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jun 2020 00:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41974 X-GNU-PR-Package: emacs Original-Received: via spool by 41974-submit@debbugs.gnu.org id=B41974.15926980709666 (code B ref 41974); Sun, 21 Jun 2020 00:08:01 +0000 Original-Received: (at 41974) by debbugs.gnu.org; 21 Jun 2020 00:07:50 +0000 Original-Received: from localhost ([127.0.0.1]:58956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnWY-0002Vq-EH for submit@debbugs.gnu.org; Sat, 20 Jun 2020 20:07:50 -0400 Original-Received: from mail-wr1-f67.google.com ([209.85.221.67]:46513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnWX-0002Vd-9Q for 41974@debbugs.gnu.org; Sat, 20 Jun 2020 20:07:49 -0400 Original-Received: by mail-wr1-f67.google.com with SMTP id x6so13179013wrm.13 for <41974@debbugs.gnu.org>; Sat, 20 Jun 2020 17:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e0dvIuaj6xwaa21z8pyuyViS/WPr7kLBfINqlLXiPPs=; b=FpXANJazLnTQDglE0IwkGaWJJ8cB0HZHqptZOZQYq2OAeLfX4nms+XJX57BNwIVxsk GgO7n+dyZczJjeUIT7fhHTovRLaGXKgJb9byp6lM51RHuDO6PORsQL6nUfXHfsU8WuAr cru76EBCFMEYxqQsWVF6AYZuNjxXdr1eEu38C6r+gJht15E074Injw+Cmfw9WFCm06xo w2mcwTw5kdYmMAuBckXq3AP3ok/MACmHok5UvaCOcXEQJQfWEqw9/VBlrhfaZrm9qzfq 7e66DtKp2nf7ym5rS2Cz7a/B0HiaHlqmi86k+47RORNlTTOB5HSKRR0q+ab8dGbRcjMx 30OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e0dvIuaj6xwaa21z8pyuyViS/WPr7kLBfINqlLXiPPs=; b=cvK6+Jfm91HZSwswVa7RdqvrkxDaVQplPDevjW9sUKu0f/GLPmU6coxkY5JWBWrWsN rXxQ/HgtspsjQzutFSUMsL5Pb9v7bltcSyhgb6Xnh3NV6mi8nHOPpsmzN00B9Bt0j2+F 9y8Rq4QUrrCz3r5D6eDKj+xcVY+vIf03ENCJRk3+Ep+dD5w7QLS/b3VyfTjTSBFVQ4Qj vL8mKI6pz+P5gqQQPdxQgdnNP3UJnGWkfxI30esIA0U/RzJBfByc977nbwMXYGe6f+Vh jOg/0wexNFGOUiq9G6CrtGHWp2lHYroQ6dGAe6EYozb+JaZmYJyOFm0sRd/u/XDxL8aq 64Hg== X-Gm-Message-State: AOAM532DLIsUOEUB0AbZXIHp72mLOg4+B1xDn3WJHcDtiIXYFp7HKRzd UaDL/h5K2xy4aM3ZeXkmz3SEfZQi X-Google-Smtp-Source: ABdhPJyIdctC3fsGTEMIxhwqzN/xF98XXrpgNfETyX+HH6NQTy56AF84ylmE6KbSX6YkK3Ary9uzDg== X-Received: by 2002:a5d:60c3:: with SMTP id x3mr10901413wrt.48.1592698063147; Sat, 20 Jun 2020 17:07:43 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id z9sm11116972wmi.41.2020.06.20.17.07.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jun 2020 17:07:42 -0700 (PDT) In-Reply-To: <87a70x8f7g.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182225 Archived-At: On 21.06.2020 02:55, Juri Linkov wrote: > I think this restriction should be lifted, so vc commands should > work even when called on non-file buffers whose default-directory > is inside the vc project. Agreed. Does this patch help, or does it miss more cases? diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 9b12d44978..36013fcdc9 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2563,7 +2563,7 @@ vc-print-branch-log (vc-read-revision "Branch to log: "))) (when (equal branch "") (error "No branch specified")) - (let* ((backend (vc-responsible-backend default-directory)) + (let* ((backend (vc-deduce-backend)) (rootdir (vc-call-backend backend 'root default-directory))) (vc-print-log-internal backend (list rootdir) branch t