unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 45264@debbugs.gnu.org
Subject: bug#45264: 26.3; `face-remap-set-base' seems to be bugged
Date: Tue, 15 Dec 2020 16:31:31 -0800 (PST)	[thread overview]
Message-ID: <dbc9cd7f-c4da-4137-a972-aada49e0f1f1@default> (raw)

See https://emacs.stackexchange.com/a/62301/105

(defface foo '((t (:background "red"))) "...")

(face-remap-set-base 'font-lock-keyword-face 'foo)

The &rest arg SPECS is `(foo)', which is, as required, a list of
(one) face.

But the code actually expects `foo' itself to be a list.  It raises
an error, because it sets SPECS to just `foo' and then tries to
take the car of it.

(while (and (consp specs)
            (not (null (car specs)))
            (null (cdr specs)))
  (setq specs (car specs))) ; <=========

(if (or (null specs)
    (and (eq (car specs) face) ; <=========
         (null (cdr specs))))

Is there a doc bug (both manual and doc string)?  Or is there a code
bug?  Or am I missing something?


In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32)
 of 2019-08-29
Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd
Windowing system distributor `Microsoft Corp.', version 10.0.18362
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''





             reply	other threads:[~2020-12-16  0:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16  0:31 Drew Adams [this message]
2020-12-19 10:20 ` bug#45264: 26.3; `face-remap-set-base' seems to be bugged Eli Zaretskii
     [not found] <<dbc9cd7f-c4da-4137-a972-aada49e0f1f1@default>
     [not found] ` <<833602umgb.fsf@gnu.org>
2020-12-19 18:32   ` Drew Adams
2020-12-19 18:58     ` Eli Zaretskii
     [not found] <<<dbc9cd7f-c4da-4137-a972-aada49e0f1f1@default>
     [not found] ` <<<833602umgb.fsf@gnu.org>
     [not found]   ` <<4efb5c63-6636-449f-8e2b-4b8533a9cc8c@default>
     [not found]     ` <<83a6u9tyh1.fsf@gnu.org>
2020-12-19 19:28       ` Drew Adams
2020-12-19 19:40         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbc9cd7f-c4da-4137-a972-aada49e0f1f1@default \
    --to=drew.adams@oracle.com \
    --cc=45264@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).