From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Tue, 2 Mar 2021 23:37:45 +0200 Message-ID: References: <87im69uzlt.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39458"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: Theodor Thornhill , juri@linkov.net, 46859@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 02 22:40:01 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHCkL-000A9D-3q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 22:40:01 +0100 Original-Received: from localhost ([::1]:51754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHCkJ-0005Y6-Vo for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 16:40:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHCiQ-0003OX-8e for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 16:38:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHCiP-0006qF-Ty for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 16:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHCiP-0008C6-Rp for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 16:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Mar 2021 21:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.161472107831489 (code B ref 46859); Tue, 02 Mar 2021 21:38:01 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 2 Mar 2021 21:37:58 +0000 Original-Received: from localhost ([127.0.0.1]:54410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHCiL-0008Bn-H5 for submit@debbugs.gnu.org; Tue, 02 Mar 2021 16:37:58 -0500 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:36205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHCiJ-0008Ba-Je for 46859@debbugs.gnu.org; Tue, 02 Mar 2021 16:37:56 -0500 Original-Received: by mail-wr1-f43.google.com with SMTP id u14so21441765wri.3 for <46859@debbugs.gnu.org>; Tue, 02 Mar 2021 13:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4f3UzxTDdTbybWja9EjOzou+OxvJlKdmUPRaaJ/bOg4=; b=QXCsAHlz7F6ySL10wrJp4phTU/fDLtj5hVhK5t/4E7DtnVVuiV/nvjG203NfEWM6+2 vAR6gGoe3KUdckv67mFmN9ntcdmINFaQrQrFiRDpOWGa7kjXOkNz9+LEe+/35sgoySRK hl9SHwT7MDiW6waKobo2mSYCwFcXi+1vUJopxReb3+Hwx2TCFHSUBz+azSD8oUp6Ih1u lQHfBeiQq1t1Zv4MWk5SFTkgQwxSCxB6G3jgCD+Az12vm8v0Ld2ZjDrdiSeDNXAfBdX0 EheKQYw9nuajoTLJjTbH0+1jVl3yzr41+mzM0vBoyzl+HwvRpja+vwgvlvyyLoZIQJfy zMEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4f3UzxTDdTbybWja9EjOzou+OxvJlKdmUPRaaJ/bOg4=; b=OvaBONbTwazQTFMiKS1EWaqn8/0OpXXSaJCMp1V2ool+b+Kg65Fun0fr+ReHr9eBHb 6DQtTo4q24xbndEvt958efZ/ZJojX05fDqyXONnb7kgA8eO3ysLsCESNqEeORafarau9 42/ybha04Rn5bLGSV60oYP6g32S7mevfiK+tXAB5PJvxkXlGkgnRHRDq8Su6On/4dF+f 3iby74RBgHtVj9tgBl5p7zlFRpd4wYGiwYTED9xXIUaNYC8pDpEL3oQO62dMq6/nz7W/ 4jnLWs2z20JqA/yUJ1/+etFKiG9Rt8J9BB/PubUrxumlaFKmBqtPS9Tw6PSUV1q38zFW Sn8Q== X-Gm-Message-State: AOAM531bfcTX+WcVTsUSANvhlxIsHoitFAJGcEwk9IiAOnxSqTLYzV59 gpIcNL64d/glj0mMUHnCxM2ptf+mbYM= X-Google-Smtp-Source: ABdhPJxCOZHFQL9YthPfZOJOvw9nbaiGO5n2iti1sOtpZtdz+YAMoa6fz40/f0tPkrtven4lXZ+g2w== X-Received: by 2002:a5d:6951:: with SMTP id r17mr23417396wrw.279.1614721069548; Tue, 02 Mar 2021 13:37:49 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id g202sm3824467wme.20.2021.03.02.13.37.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Mar 2021 13:37:49 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201242 Archived-At: Hi Theodor, On 02.03.2021 23:13, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Yeah, maybe. However, without benchmarking, it is quite clear that > adding your option is faster than my patch, since ripgrep has to search > the whole minified file. I assume it short circuits, so that results > are delivered quicker to emacs. Maybe this bug can be closed. Could you try benchmarking both approaches? If the performance improvement from yours is at all comparable with Juri's, I'm inclined to prefer that direction for reasons described in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44983#71. In both cases Ripgrep (or Grep) will search the whole file. The -M flag just affects its output.