From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tobias Bading Newsgroups: gmane.emacs.bugs Subject: bug#63395: HiDPI/GTK: menubar height scaled twice in xg_update_frame_menubar() Date: Tue, 9 May 2023 20:22:53 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6668"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: 63395@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 09 20:24:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwS0e-0001Qg-DB for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 May 2023 20:24:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwS0K-0004uW-TS; Tue, 09 May 2023 14:24:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwS0J-0004nQ-7k for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 14:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwS0I-0004yn-Uo for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 14:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwS0I-00047o-CC for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 14:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tobias Bading Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 May 2023 18:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63395 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.168365658315776 (code B ref -1); Tue, 09 May 2023 18:24:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 May 2023 18:23:03 +0000 Original-Received: from localhost ([127.0.0.1]:44443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwRzL-00046O-3Y for submit@debbugs.gnu.org; Tue, 09 May 2023 14:23:03 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:53008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwRzI-00045l-Mw for submit@debbugs.gnu.org; Tue, 09 May 2023 14:23:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwRzI-0004E3-C1 for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 14:23:00 -0400 Original-Received: from mout.web.de ([212.227.17.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwRzF-0004qy-9D for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 14:23:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1683656574; i=tbading@web.de; bh=amhMj0n/oaDK7rApYyjB56SERzKblqUfjJvE62UQgv0=; h=X-UI-Sender-Class:Date:To:From:Subject; b=pBmdfHO+NF6I2HZurfQ/spWbsjgvjAx37me6ZzK2VbvxBMmFrtajddd02ylg1PFM+ qNx+/52twmkUfM8E8wZYpmv4Xk5Nvjf1+qY0gMJWaeqfHVrGBXGJcuvm5lPklq1WK2 ziAfO+1Ezq3cK8+saWHvewlkG/JsYtxWUUPP9BrCymSvG0ShXIa3dZbNsrDBuolMPj TPl1CHUWZS8IbOLQ+KE8UvhyYHx3y7KOz7mteKVGBbAl2IsEumw8itJ2LT+AcbdkrD k/aDT/wwALzkGsaWQb1vjTcj54sVCXdegaHBVJCTuhZrEcGwelR0jgDqeMtRJ4iCSe OvxnRYgwj3uhQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from [192.168.2.103] ([84.143.147.50]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MlbLM-1qdnDA11RS-00in4Q for ; Tue, 09 May 2023 20:22:54 +0200 Content-Language: en-US X-Provags-ID: V03:K1:1B0bxynfrjdCewSY4BZi/8rJzpEeNw/TpR0FuGNM1LztV4/0wLW v3NisH2QUb+1CZZTshK3kzjVioBrff1xxXnBm9hoD5aXCb/Z9fW5HhjB29tzdjGqViUi7W1 gMeOgFsHNDfPy3k9q/UNPVraVvMU2yLuJqADeOTgFloeUX4mPxWddi51OPMzpWnH9x+HO4e MtKUZokN752SkfC8IxXzA== UI-OutboundReport: notjunk:1;M01:P0:OTgSawGWtAU=;2h/XTyXGQPr4ac8OA9jrLzyn9wC vJkYTmTuKDk0iSIqbngfRLROviGhnMjWwZx+lWHCgjc8XYrB0IsChqPdm37kBA66MYaHgGo9U nYuMYi3E/3865K5uqLTdVurTzSEkIhXRsGRxwNeYnKRv7buDWf9kLH+kIYSzy5xuy1/TNYccL DC7xBHz7ylAuAmFg58957JYEFjpoiRjFjTALq4gH3AXIDemqyo0vzMqJCiSdUOv9hh9WXdOWb Hz+w9lwWwLQwJkG2DckTRpdDiYIB01WBS3MylAp1+rVm9JtuockVehG+3jnMVjiidWUZC4tBD 6iZYyXwVN5PbPgVJevMEM7p31SqhuS1veEBliZRT/dYCBT7ap4J4az3rTLIAhsYrnNIiN7iLS kK6Kr3tvrcMJ5f/H/6QPGwniyN8MiVayIyRx6XzyUX4lk0qePrMJmn6Ur3YWpAlHuZrbv9/uj 8Cb8+sdSUuKXqjdJVjVs0Yyk6DVdaRM557wu8cYR2zaH/Gu3PRNQUVQZMJsOajI/AY4rUUxUR lLCE7qxbYXyXs+CxYJiwu/oHL+H8K5MaWI8sQGweP6jGFkprOjoo1dmERM8CN8gFm+laqG7Xr JHkzMWRYLL1ZTKeQXfrCBrfa8M05hiniNwBpMDcyC52XsrBEKTrexCFA5g8HRMXcX8pOvJfoM S4jnGK8L9dtSvvplOHeTpfZD2rr3E0dpp52zV6xZdSmRVxRJ4WzvHvk0u8+HVAeeYJyoGuHy8 wH5xP9ZfwW2uXLr3RniPVv4AwEEsR4Wox8DXFVo1tkJjBtyiPJJ/Iheund9HRmFPKqNy2pYa Received-SPF: pass client-ip=212.227.17.12; envelope-from=tbading@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261440 Archived-At: It looks like =2D-- %< --- commit 401ccb0b9c697fd3af026a72b6621a692e206aea Author:=C2=A0=C2=A0=C2=A0=C2=A0 Po Lu AuthorDate: Wed Jan 26 13:53:20 2022 +0800 Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Po Lu CommitDate: Wed Jan 26 13:53:20 2022 +0800 =C2=A0=C2=A0=C2=A0 Fix GTK menu bar height reporting when scaled =C2=A0=C2=A0=C2=A0 * src/gtkutil.c (xg_update_frame_menubar): Multiply req= uisition =C2=A0=C2=A0=C2=A0 height by GDK scale. M=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 src/gtkutil.c =2D-- >% --- tried to correct a problem that was already fixed by =2D-- %< --- commit a05bafffdcb88df74408a8402cafc9829407c1e5 Author:=C2=A0=C2=A0=C2=A0=C2=A0 Tobias Bading AuthorDate: Wed Nov 27 16:51:26 2019 +0100 Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Robert Pluim CommitDate: Tue Dec 3 08:54:31 2019 +0100 =C2=A0=C2=A0=C2=A0 Fix incorrect GTK menus on HiDPI monitors with scaling = factor > 1 =C2=A0=C2=A0=C2=A0 This should fix Bug#31223, Bug#28106, Bug#23672 as well= as Ubuntu bug =C2=A0=C2=A0=C2=A0 https://bugs.launchpad.net/ubuntu/+source/emacs25/+bug/= 1695228 =C2=A0=C2=A0=C2=A0 Also fixes the formerly unscaled Y value returned by =C2=A0=C2=A0=C2=A0 frame-monitor-workarea (and display-monitor-attributes-= list). =C2=A0=C2=A0=C2=A0 For details on why some GTK menus were empty please see= thread =C2=A0=C2=A0=C2=A0 https://lists.gnu.org/archive/html/emacs-devel/2019-11/= msg01061.html =C2=A0=C2=A0=C2=A0 * src/gtkutil.c (menubar_map_cb, xg_update_frame_menuba= r): Scale up =C2=A0=C2=A0=C2=A0 req.height so that the menu bar's height is in device p= ixels as =C2=A0=C2=A0=C2=A0 expected. =C2=A0=C2=A0=C2=A0 (xg_event_is_for_menubar): Scale down rec.x and rec.y s= o that =C2=A0=C2=A0=C2=A0 gtk_widget_intersect() works as intended. =C2=A0=C2=A0=C2=A0 * src/xfns.c (Fx_display_monitor_attributes_list): Scal= e work.x and =C2=A0=C2=A0=C2=A0 work.y up to be in device pixels. =C2=A0=C2=A0=C2=A0 Copyright-paperwork-exempt: yes M=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 src/gtkutil.c M=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 src/xfns.c =2D-- >% --- In emacs-29 as well as master req.height in xg_update_frame_menubar() is n= ow multiplied with xg_get_scale(f) twice. As a result my window manager (Comp= iz from Ubuntu 20.04.6 LTS) assumes that the Emacs frame wouldn=E2=80=99t fit= into the monitor=E2=80=99s workarea and ignores my requested position. Reverting 401ccb0b9c697fd3af026a72b6621a692e206aea fixes this for me.