bug#17193: 24.4.50; `menu-bar-make-toggle': allow :keys

bug#17193: 24.4.50; `menu-bar-make-toggle': allow :keys

[Drew Adams]

Enhancement request:

`menu-bar-make-toggle' is a macro that expands to `(menu-item ...)'.
This is a request to allow it to accept, and take into account,
additional `menu-item' features, such as `:keys'.  Currently, it seems
there is no way to pass :keys to `menu-bar-make-toggle' so that the keys
will appear in (i.e., next to) the menu item.


In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-03-30 on ODIEONE
Bzr revision: 116912 rgm@gnu.org-20140331004905-epgjyxkpa4nv54bm
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

bug#17193: 24.4.50; `menu-bar-make-toggle': allow :keys

[Drew Adams]

I should have made clear in the Subject line, as well as in the
message body, that the request is not just about :keys but includes
support for (i.e., taking account of) :enable, :visible, and so on.

IOW, the macro should allow `menu-item' features such as these
keywords to be passed on to `menu-item', so that they take effect.

bug#17193: 24.4.50; `menu-bar-make-toggle': allow :keys

[Drew Adams]

> I should have made clear in the Subject line, as well as in the
> message body, that the request is not just about :keys but includes
> support for (i.e., taking account of) :enable, :visible, and so on.
> 
> IOW, the macro should allow `menu-item' features such as these
> keywords to be passed on to `menu-item', so that they take effect.

This is apparently already what `menu-bar-make-mm-toggle' does,
for example.

[But the doc string for `menu-bar-make-mm-toggle' is not very
clear about this.  It simply calls this PROPS, saying "PROPS are
additional properties."  It really should make clear what is
involved: these are things passed to `menu-item'.  "Properties"
by itself means nothing in the context of that doc string.
Something really needs to point to `menu-item', which is fully
documented.]