unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Po Lu <luangruo@yahoo.com>
Cc: 50993@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#50993: 29.0.50; Problems when dragging the mouse over the toolbar
Date: Mon, 11 Oct 2021 18:29:06 +0200	[thread overview]
Message-ID: <dad767c3-c20e-801c-0139-eabf4f05ce0b@gmx.at> (raw)
In-Reply-To: <878ryzafqk.fsf@yahoo.com>

 > Thanks, with your explanation it does seem to work now, but if the mouse
 > is released over the toolbar then it seems to never stop tracking the
 > mouse, unless I click it again.

Maybe, I didn't check.  How about brute force like the below?

martin

diff --git a/src/keyboard.c b/src/keyboard.c
index bc6f97586d..ba625c4f77 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -5122,7 +5122,8 @@ make_lispy_position (struct frame *f, Lisp_Object x, Lisp_Object y,
  #endif
        )
      {
-      posn = EQ (window_or_frame, f->tab_bar_window) ? Qtab_bar : Qtool_bar;
+      if (NILP (track_mouse))
+	posn = EQ (window_or_frame, f->tab_bar_window) ? Qtab_bar : Qtool_bar;
        /* Kludge alert: for mouse events on the tab bar and tool bar,
  	 keyboard.c wants the frame, not the special-purpose window
  	 we use to display those, and it wants frame-relative





  reply	other threads:[~2021-10-11 16:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87r1d2b9e2.fsf.ref@yahoo.com>
2021-10-03 12:06 ` bug#50993: 29.0.50; Problems when dragging the mouse over the toolbar Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-10 17:41   ` Eli Zaretskii
2021-10-10 19:10     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-10 19:23       ` Eli Zaretskii
2021-10-10 21:53         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-11  0:34           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-11  7:19             ` martin rudalics
2021-10-11  7:24               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-11  9:21                 ` martin rudalics
2021-10-11 10:40                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-11 12:31                     ` martin rudalics
2021-10-11 12:49                       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-11 16:29                         ` martin rudalics [this message]
2021-10-12  0:09                           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-12  8:12                             ` martin rudalics
2021-10-12 14:01                               ` Eli Zaretskii
2021-10-12 14:25                                 ` martin rudalics
2021-10-12 15:55                                   ` Eli Zaretskii
2021-10-12 17:27                                     ` martin rudalics
2021-10-12 19:23                                       ` Juri Linkov
2021-10-13  8:36                                         ` martin rudalics
2021-10-13 12:51                                           ` Eli Zaretskii
2021-10-14  9:12                                             ` martin rudalics
2021-10-13 19:07                                           ` Juri Linkov
2021-10-14  9:13                                             ` martin rudalics
2021-10-14  9:35                                               ` Eli Zaretskii
2021-10-14 16:09                                               ` Juri Linkov
2021-10-14 17:01                                                 ` martin rudalics
2021-10-14 17:10                                                   ` Juri Linkov
2021-10-14 17:47                                                     ` martin rudalics
2021-10-14 18:02                                                       ` Juri Linkov
2021-10-17 17:49                                                       ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dad767c3-c20e-801c-0139-eabf4f05ce0b@gmx.at \
    --to=rudalics@gmx.at \
    --cc=50993@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).