unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: kimitto@gmail.com
To: bug-gnu-emacs@gnu.org
Subject: completing-read in pcvs.el
Date: Thu, 24 Jul 2008 08:12:52 -0700 (PDT)	[thread overview]
Message-ID: <daac5102-0213-4a4c-b59e-09bf20d73958@w1g2000prk.googlegroups.com> (raw)


(emacs-version)
"GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600)
 of 2007-07-08 on CUBE"

completing-read()'s second arg requires alist (or hash-table,
obarray),
but in pcvs.el uses a list.

Calling cvs-mode-set-flags() makes error
if uning a tiny original completion elisp.

Fix it, please.


Best regards,
Kimito Yada


diff -u c\:/meadow/lisp/pcvs.el c\:/meadow/lisp/pcvs.mod.el
--- c:/meadow/lisp/pcvs.el	2007-07-08 14:28:00.001000000 +0900
+++ c:/meadow/lisp/pcvs.mod.el	2008-07-24 23:52:23.020236800 +0900
@@ -2217,8 +2217,8 @@
   (interactive
    (list (completing-read
 	  "Which flag: "
-	  '("cvs" "diff" "update" "status" "log" "tag" ;"rtag"
-	    "commit" "remove" "undo" "checkout")
+	  '(("cvs") ("diff") ("update") ("status") ("log") ("tag") ;("rtag")
+	    ("commit") ("remove") ("undo") ("checkout"))
 	  nil t)))
   (let* ((sym (intern (concat "cvs-" flag "-flags"))))
     (let ((current-prefix-arg '(16)))




             reply	other threads:[~2008-07-24 15:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24 15:12 kimitto [this message]
2008-09-05 15:09 ` bug#894: completing-read in pcvs.el Stefan Monnier
2008-09-09  3:55   ` bug#939: " kimito yada
2008-09-09 13:32     ` bug#945: " Stefan Monnier
2008-09-09 14:46       ` bug#948: " kimito yada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daac5102-0213-4a4c-b59e-09bf20d73958@w1g2000prk.googlegroups.com \
    --to=kimitto@gmail.com \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).