From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Fri, 7 Feb 2020 02:00:38 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="64435"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 To: Wolfgang Scherer , 39452@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 07 00:01:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1izq99-000GfQ-8B for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Feb 2020 00:01:19 +0100 Original-Received: from localhost ([::1]:47620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izq98-0001uV-AJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Feb 2020 18:01:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34739) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izq8u-0001qU-CH for bug-gnu-emacs@gnu.org; Thu, 06 Feb 2020 18:01:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izq8r-0005WC-UY for bug-gnu-emacs@gnu.org; Thu, 06 Feb 2020 18:01:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42757) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1izq8r-0005Vx-P6 for bug-gnu-emacs@gnu.org; Thu, 06 Feb 2020 18:01:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1izq8r-0000ut-OF for bug-gnu-emacs@gnu.org; Thu, 06 Feb 2020 18:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Feb 2020 23:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.15810300483497 (code B ref 39452); Thu, 06 Feb 2020 23:01:01 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 6 Feb 2020 23:00:48 +0000 Original-Received: from localhost ([127.0.0.1]:48730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izq8d-0000uL-RN for submit@debbugs.gnu.org; Thu, 06 Feb 2020 18:00:48 -0500 Original-Received: from mail-lj1-f193.google.com ([209.85.208.193]:35329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izq8c-0000u9-PA for 39452@debbugs.gnu.org; Thu, 06 Feb 2020 18:00:47 -0500 Original-Received: by mail-lj1-f193.google.com with SMTP id q8so82069ljb.2 for <39452@debbugs.gnu.org>; Thu, 06 Feb 2020 15:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=P8dqNSF0NtKg8hBDXsGGEWpWTkgLd9Ij6+a3v1oqTs4=; b=dXMTNKLxHpbUCyTBsr0UEecjplXBihHbU7bPkAbteIa05AiY+20HJKwyHNeU/TEjQD UC+izek37hv+zLh3YPY5K/oJOZXudYiXkMXGn8NdHUFnK/CuTs/c+/iwdSmQnh6EZLKo 2mriTdLnidqquTuGrAFpjG4moBNykvxdI7EzQFQzcCiC0ttouMt0/WON+68Jhe9dVW1k OQIG4QqprPJXbvlq3HHDTz1EyDZ5d0hNE1rhk8jU4PU0YCTX8HlAyXsMNr7qJ/e52HXC v+Z8Qaz1IUWSJSRbwlI+Q3frT2DiCXijrrZTss7qgxDKeM7U/WFzjr/bTIMTutOgDoB/ CgPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=P8dqNSF0NtKg8hBDXsGGEWpWTkgLd9Ij6+a3v1oqTs4=; b=TvmGzpsqPILLG9pkJH2P/CxASdXJ8HismcxjUm+UkgrIXK4RFRu3iIwUvzsp8EaVcp e4x2LPYYQlMzChRb45aBpDPbNh9+f6Bboq9MdFRZjX1tz+mehJZnjkV0GK/OA94eyGSK IWr1NMQX/1Ze/5v9TfRS8JJzmVOXpRN8EQIdf4lkhj5wtxd2ThzxLuetW/X/nTfF/Win pX0xem/90A5zCQIJFKR4xUXfVgWTKs939Yd0EvLn1QW7rx3zlMeFtv4m4Jy6GWA5+y5J o3YhOCHvS0PLng/3K0nzD0R7Eop3QbxLNWwRHCbjOWccWeReG8vZtCp8m30zX7pCIKB2 Tq4A== X-Gm-Message-State: APjAAAXl7qOLU6sXsYV6zB0m4IYjClQKvMQAIQiZueLweoxYIkse/6SH fGnpjRz4TQQCGRq42jlbETv065ii5VQ= X-Google-Smtp-Source: APXvYqxgn0lpeu4HcDcHrxEDq+a0bE9txhK1Mj0tF7ByHkpkou6AKK1payb+xM5DBgJF+64aDQ9mLw== X-Received: by 2002:a2e:94c8:: with SMTP id r8mr3491655ljh.28.1581030040033; Thu, 06 Feb 2020 15:00:40 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id 144sm270422lfi.67.2020.02.06.15.00.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Feb 2020 15:00:39 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175730 Archived-At: Hi Wolfgang, On 06.02.2020 16:59, Wolfgang Scherer wrote: > When a filename contains shell wildcard characters matching one or more files, e.g. `test[56].xx` matching both `test5.xx` and `test6.xx`: > >   -rw-r--r--  1 ws ws    0 Feb  6 08:51 test[56].xx >   -rw-r--r--  1 ws ws    0 Feb  6 08:51 test5.xx >   -rw-r--r--  1 ws ws    0 Feb  6 08:51 test6.xx > > The command `vc-git-state` does not work correctly. > > The attched patch fixes this: > > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index 2caa287..0314e5e 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -330,7 +330,7 @@ in the order given by `git status'." >              ,@(when (version<= "1.7.6.3" (vc-git--program-version)) >                  '("--ignored")) >              "--")) > -        (status (apply #'vc-git--run-command-string file args))) > +        (status (apply #'vc-git--run-command-string (shell-quote-argument file) args))) >      (if (null status) >          ;; If status is nil, there was an error calling git, likely because >          ;; the file is not in a git repo. > Thanks for the report and the patch. I wonder how many other backends commands are broken for files like that: we basically never shell-quote file names.