From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Michael Heerdegen <michael_heerdegen@web.de>, 14734@debbugs.gnu.org
Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
Date: Sun, 20 Oct 2013 16:27:07 -0700 (PDT) [thread overview]
Message-ID: <da5fe6e3-ebd1-436b-bb02-600fa035ea90@default> (raw)
In-Reply-To: <jwva9m91u58.fsf-monnier+emacs@gnu.org>
> the old advice.el was made to work on top of the new nadvice.el (the
> total size of the new advice.el and nadvice.el is about the same as
> the old advice.el).
But the new advice, and now the old advice too, since it is on top of
the new, does NOT work. Specifically, there is this regression wrt
doc strings.
This should not be a `wont-fix' bug. It should be fixed.
It should be fixed in the advice system that is documented in the
manuals, which for now is still the "old" system (there is nothing
about the nadvice stuff in the manuals).
If the "new" system will at some point replace the old and itself be
documented differently, instead of being only, as you say now,
internal, then it too will need to be fixed wrt its handling of the
doc string.
prev parent reply other threads:[~2013-10-20 23:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 17:08 bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Drew Adams
2013-06-27 18:15 ` Stefan Monnier
2013-06-27 18:40 ` Drew Adams
2013-06-28 17:39 ` Drew Adams
2013-06-28 20:44 ` Dmitry Gutov
2013-06-28 21:56 ` Drew Adams
2013-06-28 22:19 ` Michael Heerdegen
2019-09-23 21:07 ` bug#13581: " Lars Ingebrigtsen
2013-06-28 22:27 ` Michael Heerdegen
2013-06-28 23:21 ` Stefan Monnier
2013-06-29 1:37 ` Drew Adams
2013-06-29 2:09 ` Stefan Monnier
2013-06-29 2:28 ` Drew Adams
2013-06-29 3:24 ` Stefan Monnier
2013-06-29 20:29 ` Juanma Barranquero
2013-06-30 1:39 ` Stefan Monnier
2013-07-05 14:50 ` Drew Adams
2013-07-05 14:57 ` Juanma Barranquero
2013-07-05 22:44 ` Stefan Monnier
2013-07-06 1:40 ` Drew Adams
2013-07-06 9:18 ` Stefan Monnier
2013-07-06 20:22 ` Drew Adams
2013-10-20 23:27 ` Drew Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da5fe6e3-ebd1-436b-bb02-600fa035ea90@default \
--to=drew.adams@oracle.com \
--cc=14734@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).