From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#60285: xref-query-replace-in-results could show an arrow pointing to the current item being replaced Date: Thu, 5 Jan 2023 01:48:21 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7803"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 60285@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 05 00:49:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDDVZ-0001mb-4y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Jan 2023 00:49:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDDVH-0002ii-SQ; Wed, 04 Jan 2023 18:49:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDDVG-0002iZ-P0 for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 18:49:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDDVG-0000Az-EC for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 18:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDDVG-0000Ya-33 for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 18:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2023 23:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60285 X-GNU-PR-Package: emacs Original-Received: via spool by 60285-submit@debbugs.gnu.org id=B60285.16728761112053 (code B ref 60285); Wed, 04 Jan 2023 23:49:02 +0000 Original-Received: (at 60285) by debbugs.gnu.org; 4 Jan 2023 23:48:31 +0000 Original-Received: from localhost ([127.0.0.1]:49868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDDUk-0000X2-O1 for submit@debbugs.gnu.org; Wed, 04 Jan 2023 18:48:31 -0500 Original-Received: from mail-ed1-f44.google.com ([209.85.208.44]:39722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDDUj-0000WY-1R for 60285@debbugs.gnu.org; Wed, 04 Jan 2023 18:48:29 -0500 Original-Received: by mail-ed1-f44.google.com with SMTP id b88so43530404edf.6 for <60285@debbugs.gnu.org>; Wed, 04 Jan 2023 15:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=gUZWf7P7ux5WkKwRw+z/ecBmvAUZSGiKzRJD3WOyvCI=; b=Qc91N8hyznTzDR2JkdUkqlTD5OqATFzehme1R60hmql7zzpdy116fIG/lLhrh5FSLf VOgWSSm2w4bN+awysyqLMSoR2LTEPwEvzfU8CbHB7D+wYILkhcf+35QM4Xuq43t2Mi++ x1OuNM0EGCZ95cu9o5CG00P0gnGGy7+b8VeaRFwBOSbodnJ2BO/PhrfYQACrSByJUKo/ 3Tl6wUkPIexEbKWKQbbWshFNTAerHxtiowdzeMKrI29hNm/1e2+yZCECOWhkWEUhO0NI uUZbOPg4Vg0c85SHyecQAcCt5YGUxqCs1ePNcZAIOe3fvkjxsQXmtcMcUfNGC6TSYTOH NMcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gUZWf7P7ux5WkKwRw+z/ecBmvAUZSGiKzRJD3WOyvCI=; b=0lDNUOOBdh8kzsWNhJNqvJUKmnFyjCIUVNjohjY0e9b3DsVR/kw5baPubaNbUOevu0 ZCVozb1/qwHhlOPjK4XPguChUxw3TZEUWhWIKyIGgP9oHUpmxyk9lKWYF8OYdzh9mjns Kqj6w5tU6MPGe9gj0e2ngMMI6ZAgw6OEnL+TTjCr7vMuuJv0k+Um8ANVPvcwEUCH5+CO uOszw6i8ByhqZyV3grT/Ejqthh8xzCjz03te4AxDgLkof32+o/d473HSF+Hu70ytttAl epJPRria16nJ5FLW3V0kbFzmFd4qIRp1Ewlw1vu8dW7x0EkALi/kZjPFZP4jpX8FJmTq HpBQ== X-Gm-Message-State: AFqh2krM2WRtMskGV6vKCCa9mzY1UtEiy0S4myWu9rQeOlBEopW6tuau Yc+JtyIiTGfRXEozzMROD/E= X-Google-Smtp-Source: AMrXdXvYK5BEeT3foq7haSpwElyCteF4O0hyNXoiHzoogUyPIqbou8u48b3vx25PVfvoWoi2S/ub1w== X-Received: by 2002:a50:ec85:0:b0:492:8c77:7da9 with SMTP id e5-20020a50ec85000000b004928c777da9mr161711edr.9.1672876103146; Wed, 04 Jan 2023 15:48:23 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m16-20020a056402051000b0048eb0886b00sm2812618edv.42.2023.01.04.15.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 15:48:22 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252547 Archived-At: On 01/01/2023 13:23, Daniel Martín wrote: > Dmitry Gutov writes: > >> On 23/12/2022 21:16, Daniel Martín via Bug reports for GNU Emacs, the >> Swiss army knife of text editors wrote: >>> Severity: wishlist >>> When you use xref-query-replace-in-results to replace some >>> references, >>> it'd be great if the xref buffer showed an overlay arrow (see >>> xref--set-arrow) pointing to the reference being edited. That'd give >>> better context about the reference that is being edited and the global >>> progress of the query replace operation. >> SGTM. >> >> Here's a patch which seems to work. It's a little tricky, though, and >> I'm at a loss with better variable names in some places. >> >> Wish we had some unit tests here. > Thanks. It works well, but there are some corner cases. Thanks for testing. > For example, > as you can undo or go to the previous match during the query replace, > the arrow should point to the previous result, if possible. Hmm, I'm not sure how to implement that. Some new hook inside perform-replace? Maybe Juri has some ideas.