From: Ken Brown <kbrown@cornell.edu>
To: Jim Porter <jporterbugs@gmail.com>,
Sean Whitton <spwhitton@email.arizona.edu>,
Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 56025@debbugs.gnu.org
Subject: bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin
Date: Mon, 27 Jun 2022 17:19:55 -0400 [thread overview]
Message-ID: <d9c54b14-0612-07c1-62eb-793e9aa918b6@cornell.edu> (raw)
In-Reply-To: <b4019955-4632-95f7-cd6a-4412e56d8dd6@gmail.com>
On 6/27/2022 3:18 PM, Jim Porter wrote:
> On 6/27/2022 6:25 AM, Ken Brown wrote:
>> Thanks to all of you for working on this while I was gone. Unfortunately, the
>> problem is still present on Cygwin. In my haste to get away, I neglected to
>> mention that there is apparently a timing issue in Eshell on Cygwin, so that
>> even three EOFs do not always suffice to kill the process.
>>
>> My test case is to run
>>
>> echo bar | sh -c rev
>>
>> in Eshell. For reasons I don't understand, EOF almost always has to be sent
>> more than 3 times times before the "sh" process dies. The maximum I've
>> observed is 93. Inserting "(sit-for 0.01)" after each EOF eliminates the need
>> for extra EOFs; this is why I referred to the problem as a timing issue.
>>
>> I propose the following workaround:
>>
>> --- a/lisp/eshell/esh-io.el
>> +++ b/lisp/eshell/esh-io.el
>> @@ -284,10 +284,16 @@ eshell-close-target
>> ;; end-of-file to the reading process. However, some platforms
>> ;; (e.g. Solaris) actually require sending a *third* EOF. Since
>> ;; sending extra EOFs while the process is running shouldn't break
>> - ;; anything, we'll just send the maximum we'd ever need. See
>> - ;; bug#56025 for further details.
>> - (let ((i 0))
>> - (while (and (<= (cl-incf i) 3)
>> + ;; anything, we'll send up to three on all platforms.
>> +
>> + ;; There's an extra wrinkle on Cygwin where, apparently due to an
>> + ;; unknown timing issue, it sometimes takes more than three EOFs
>> + ;; to kill the process. (This only happens in Eshell, not in an
>> + ;; ordinary Cygwin shell.) We work around this problem by sending
>> + ;; up to 1000 EOFs on Cygwin. See bug#56025 for further details.
>> + (let ((i 0)
>> + (n (if (eq system-type 'cygwin) 1000 3)))
>> + (while (and (<= (cl-incf i) n)
>> (eq (process-status target) 'run))
>> (process-send-eof target))))
>
> I'd be very hesitant to do this, since as you mention above, this seems like a
> timing issue, and it's entirely possible that there are other, more widespread
> issues on Cygwin here. We'd also want to check the system that the process is
> actually running on; otherwise, remoting into a Cygwin system (via Tramp) would
> still exhibit the problem. I'll see if I can get a Cygwin environment up to test
> things out in the next week-ish.
OK, thanks. Let me know if you need any help with that.
> If there's no other way that we can come up with here, I'd lean towards a
> defcustom so that users can tweak this if needed.
Sounds good.
Ken
next prev parent reply other threads:[~2022-06-27 21:19 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 18:30 bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin Ken Brown
2022-06-16 19:30 ` Sean Whitton
2022-06-16 22:01 ` Ken Brown
2022-06-17 13:39 ` Ken Brown
2022-06-18 0:57 ` Sean Whitton
2022-06-18 2:07 ` Ken Brown
2022-06-18 2:35 ` Ken Brown
2022-06-18 3:50 ` Jim Porter
2022-06-18 17:52 ` Ken Brown
2022-06-18 19:02 ` Jim Porter
2022-06-18 20:51 ` Ken Brown
2022-06-18 22:00 ` Jim Porter
2022-06-18 23:46 ` Sean Whitton
2022-06-19 16:02 ` Ken Brown
2022-06-24 1:18 ` Ken Brown
2022-06-24 4:40 ` Sean Whitton
2022-06-24 6:07 ` Eli Zaretskii
2022-06-24 16:53 ` Jim Porter
2022-06-24 22:23 ` Sean Whitton
2022-06-24 23:03 ` Jim Porter
2022-06-25 5:34 ` Eli Zaretskii
2022-06-25 16:13 ` Jim Porter
2022-06-25 16:53 ` Eli Zaretskii
2022-06-26 16:27 ` Lars Ingebrigtsen
2022-06-26 17:12 ` Sean Whitton
2022-06-26 17:22 ` Jim Porter
2022-06-26 21:11 ` Sean Whitton
2022-06-27 13:25 ` Ken Brown
2022-06-27 15:51 ` Michael Albinus
2022-06-27 16:22 ` Ken Brown
2022-06-27 19:13 ` bug#56025: [EXT]Re: " Sean Whitton
2022-06-27 21:17 ` Ken Brown
2022-06-27 19:18 ` Jim Porter
2022-06-27 21:19 ` Ken Brown [this message]
2022-07-01 3:52 ` Jim Porter
2022-07-01 3:58 ` Jim Porter
2022-07-06 22:33 ` Ken Brown
2022-07-07 4:35 ` Jim Porter
2022-07-07 4:42 ` Jim Porter
2022-07-07 12:42 ` Ken Brown
2022-07-17 2:35 ` bug#56025: [WIP PATCH] " Jim Porter
2022-07-17 6:03 ` Eli Zaretskii
2022-07-17 17:44 ` Jim Porter
2022-07-17 18:26 ` Eli Zaretskii
2022-07-17 18:51 ` Jim Porter
2022-07-18 8:09 ` Michael Albinus
2022-07-19 1:58 ` Jim Porter
2022-07-19 7:59 ` Michael Albinus
2022-07-17 21:59 ` Ken Brown
2022-07-18 5:26 ` Jim Porter
2022-07-22 4:16 ` bug#56025: [PATCH v2] " Jim Porter
2022-07-22 19:00 ` Ken Brown
2022-07-24 4:05 ` Jim Porter
2022-07-24 5:19 ` bug#56025: [PATCH v3] " Jim Porter
2022-07-24 5:29 ` bug#56025: [PATCH v4] " Jim Porter
2022-07-24 9:08 ` Lars Ingebrigtsen
2022-07-24 9:48 ` Eli Zaretskii
2022-07-24 21:04 ` Ken Brown
2022-07-24 9:47 ` Eli Zaretskii
2022-07-24 17:36 ` bug#56025: [PATCH v5] " Jim Porter
2022-07-24 20:30 ` Ken Brown
2022-07-31 1:01 ` Jim Porter
2022-08-06 1:10 ` Jim Porter
2022-08-06 12:17 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9c54b14-0612-07c1-62eb-793e9aa918b6@cornell.edu \
--to=kbrown@cornell.edu \
--cc=56025@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=larsi@gnus.org \
--cc=spwhitton@email.arizona.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).