From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#57129: 29.0.50; Improve behavior of conditionals in Eshell Date: Tue, 16 Aug 2022 12:11:24 -0700 Organization: UCLA Computer Science Department Message-ID: References: <1871347.6tgchFWduM@nimes> <838rnofgad.fsf@gnu.org> <4165399.mogB4TqSGs@nimes> <83wnb8dukz.fsf@gnu.org> <83o7wkdqsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------MG8oHTZLRs6SzariwQEGHrDK" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33853"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: bug-gnulib@gnu.org, larsi@gnus.org, bruno@clisp.org, 57129@debbugs.gnu.org, jporterbugs@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 16 21:12:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oO1z0-0008cC-FZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Aug 2022 21:12:10 +0200 Original-Received: from localhost ([::1]:42624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oO1yz-0001Fq-CO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Aug 2022 15:12:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oO1ys-0001FS-7E for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 15:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oO1yr-0000Rm-Uh for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 15:12:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oO1yr-0006ur-Oa for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 15:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Aug 2022 19:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57129 X-GNU-PR-Package: emacs Original-Received: via spool by 57129-submit@debbugs.gnu.org id=B57129.166067709526549 (code B ref 57129); Tue, 16 Aug 2022 19:12:01 +0000 Original-Received: (at 57129) by debbugs.gnu.org; 16 Aug 2022 19:11:35 +0000 Original-Received: from localhost ([127.0.0.1]:48346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO1yQ-0006u9-PV for submit@debbugs.gnu.org; Tue, 16 Aug 2022 15:11:35 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO1yO-0006tw-N3 for 57129@debbugs.gnu.org; Tue, 16 Aug 2022 15:11:33 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6A7C01600AF; Tue, 16 Aug 2022 12:11:26 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id QpVnuqTvpy5M; Tue, 16 Aug 2022 12:11:25 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2FEA41600B0; Tue, 16 Aug 2022 12:11:25 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id eUZlkWXG9RXQ; Tue, 16 Aug 2022 12:11:25 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E8DE11600AF; Tue, 16 Aug 2022 12:11:24 -0700 (PDT) Content-Language: en-US In-Reply-To: <83o7wkdqsh.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239993 Archived-At: This is a multi-part message in MIME format. --------------MG8oHTZLRs6SzariwQEGHrDK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/16/22 10:47, Eli Zaretskii wrote: > (Why are you talking about MS-DOS?) I mistakenly thought it was an MS-DOS problem because tempname.c ordinarily would use clock_gettime on MinGW. I didn't know Emacs 'configure' deliberately suppresses MinGW's clock_gettime. > Thanks, but why not use 'random' instead? Emacs does have it on all > platforms, including MS-Windows. AFAIU, it's better than 'rand'. If the code used 'random' then the Gnulib 'tempname' module would need to add a dependency on the Gnulib 'random' module, which would in turn add a cascading dependency on Gnulib's 'random_r' module. It's better to avoid this dependency if we can easily do so. Come to think of it, we don't need to use 'rand' either, since tempname.c already has a good-enough pseudorandom generator. I installed into Gnulib the attached patch, which I hope fixes the Emacs problem without changing glibc's generated code (once this gets migrated back into glibc). >> If I understand things correctly this should make the names random >> enough on MS-DOS, though Emacs itself still needs a patch as I mentioned >> a few minutes ago. > > Why would Emacs need that patch? In another part of this thread you rejected that patch, on the grounds that fixing the unlikely Emacs bug is more trouble than it's worth. So I'll drop that suggestion. --------------MG8oHTZLRs6SzariwQEGHrDK Content-Type: text/x-patch; charset=UTF-8; name="0001-tempname-generate-better-names-for-MinGW-Emacs.patch" Content-Disposition: attachment; filename*0="0001-tempname-generate-better-names-for-MinGW-Emacs.patch" Content-Transfer-Encoding: base64 RnJvbSA1MTJlNDRhZGFlYmIzMDk2ZGRkMWJmNTY0ZTY3OWQwNmUwMzAxNjE2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDE2IEF1ZyAyMDIyIDEyOjA2OjQ4IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gdGVtcG5hbWU6IGdlbmVyYXRlIGJldHRlciBuYW1lcyBmb3IgTWluR1cgRW1hY3MKTUlN RS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04 CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCk9uIE1pbkdXLCBHTlUgRW1hY3Mg ZGlzYWJsZXMgY2xvY2tfZ2V0dGltZSwgd2hpY2ggcmVsaWFibHkgYnJlYWtzCnNvbWUgb2Yg Z2VuX3RlbXBuYW1l4oCZcyBvcHRpbWlzdGljIGNhbGxlcnMuICBXb3JrIGFyb3VuZCB0aGUK cHJvYmxlbSBieSBtYWtpbmcgdGhlIGdlbmVyYXRlZCBuYW1lcyBsZXNzIHByZWRpY3RhYmxl LiAgV2UgZG9u4oCZdApuZWVkIGNyeXB0b2dyYXBoaWMgcmFuZG9tbmVzcyBoZXJlLCBqdXN0 IGVub3VnaCB1bnByZWRpY3RhYmlsaXR5CnRvIGtlZXAgRW1hY3MgaGFwcHkgbW9zdCBvZiB0 aGUgdGltZS4KKiBsaWIvdGVtcG5hbWUuYyAoSEFTX0NMT0NLX0VOVFJPUFkpOiBOZXcgbWFj cm8uCihyYW5kb21fYml0cyk6IFVzZSBpdC4KKHRyeV90ZW1wbmFtZV9sZW4pOiBPbiBzeXN0 ZW1zIGxhY2tpbmcgY2xvY2sgZW50cm9weSwgbWFpbnRhaW4Kc3RhdGUgc28gdGhhdCBnZW5f ZmlsZW5hbWUgZ2VuZXJhdGVzIGxlc3MtcHJlZGljdGFibGUgbmFtZXMgb24Kc3VjY2Vzc2l2 ZSBzdWNjZXNzZnVsIGNhbGxzLgotLS0KIENoYW5nZUxvZyAgICAgIHwgMTQgKysrKysrKysr KysrKysKIGxpYi90ZW1wbmFtZS5jIHwgMTggKysrKysrKysrKysrKysrKystCiAyIGZpbGVz IGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQg YS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYjYzOWQxNzA5ZC4uZWI5NjI4MTU5MSAx MDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDIyLTA4LTE2ICBQYXVsIEVnZ2VydCAgPGVnZ2VydEBjcy51Y2xhLmVkdT4KKworCXRl bXBuYW1lOiBnZW5lcmF0ZSBiZXR0ZXIgbmFtZXMgZm9yIE1pbkdXIEVtYWNzCisJT24gTWlu R1csIEdOVSBFbWFjcyBkaXNhYmxlcyBjbG9ja19nZXR0aW1lLCB3aGljaCByZWxpYWJseSBi cmVha3MKKwlzb21lIG9mIGdlbl90ZW1wbmFtZeKAmXMgb3B0aW1pc3RpYyBjYWxsZXJzLiAg V29yayBhcm91bmQgdGhlCisJcHJvYmxlbSBieSBtYWtpbmcgdGhlIGdlbmVyYXRlZCBuYW1l cyBsZXNzIHByZWRpY3RhYmxlLiAgV2UgZG9u4oCZdAorCW5lZWQgY3J5cHRvZ3JhcGhpYyBy YW5kb21uZXNzIGhlcmUsIGp1c3QgZW5vdWdoIHVucHJlZGljdGFiaWxpdHkKKwl0byBrZWVw IEVtYWNzIGhhcHB5IG1vc3Qgb2YgdGhlIHRpbWUuCisJKiBsaWIvdGVtcG5hbWUuYyAoSEFT X0NMT0NLX0VOVFJPUFkpOiBOZXcgbWFjcm8uCisJKHJhbmRvbV9iaXRzKTogVXNlIGl0Lgor CSh0cnlfdGVtcG5hbWVfbGVuKTogT24gc3lzdGVtcyBsYWNraW5nIGNsb2NrIGVudHJvcHks IG1haW50YWluCisJc3RhdGUgc28gdGhhdCBnZW5fZmlsZW5hbWUgZ2VuZXJhdGVzIGxlc3Mt cHJlZGljdGFibGUgbmFtZXMgb24KKwlzdWNjZXNzaXZlIHN1Y2Nlc3NmdWwgY2FsbHMuCisK IDIwMjItMDgtMTYgIFNpbW9uIEpvc2Vmc3NvbiAgPHNpbW9uQGpvc2Vmc3Nvbi5vcmc+CiAK IAltYWludGFpbmVyLW1ha2VmaWxlOiBDaGVjayBmb3IgaW5jb3JyZWN0IERJU1RDSEVDS19D T05GSUdVUkVfRkxBR1MKZGlmZiAtLWdpdCBhL2xpYi90ZW1wbmFtZS5jIGIvbGliL3RlbXBu YW1lLmMKaW5kZXggZTY1MjAxOTFkNy4uNWFkZmU2MjlhOCAxMDA2NDQKLS0tIGEvbGliL3Rl bXBuYW1lLmMKKysrIGIvbGliL3RlbXBuYW1lLmMKQEAgLTc3LDYgKzc3LDEyIEBAIHR5cGVk ZWYgdWludF9mYXN0NjRfdCByYW5kb21fdmFsdWU7CiAjZGVmaW5lIEJBU0VfNjJfRElHSVRT IDEwIC8qIDYyKioxMCA8IFVJTlRfRkFTVDY0X01BWCAqLwogI2RlZmluZSBCQVNFXzYyX1BP V0VSICg2MkxMICogNjIgKiA2MiAqIDYyICogNjIgKiA2MiAqIDYyICogNjIgKiA2MiAqIDYy KQogCisjaWYgX0xJQkMgfHwgKGRlZmluZWQgQ0xPQ0tfTU9OT1RPTklDICYmIEhBVkVfQ0xP Q0tfR0VUVElNRSkKKyMgZGVmaW5lIEhBU19DTE9DS19FTlRST1BZIHRydWUKKyNlbHNlCisj IGRlZmluZSBIQVNfQ0xPQ0tfRU5UUk9QWSBmYWxzZQorI2VuZGlmCisKIHN0YXRpYyByYW5k b21fdmFsdWUKIHJhbmRvbV9iaXRzIChyYW5kb21fdmFsdWUgdmFyLCBib29sIHVzZV9nZXRy YW5kb20pCiB7CkBAIC04NCw3ICs5MCw3IEBAIHJhbmRvbV9iaXRzIChyYW5kb21fdmFsdWUg dmFyLCBib29sIHVzZV9nZXRyYW5kb20pCiAgIC8qIFdpdGhvdXQgR1JORF9OT05CTE9DSyBp dCBjYW4gYmUgYmxvY2tlZCBmb3IgbWludXRlcyBvbiBzb21lIHN5c3RlbXMuICAqLwogICBp ZiAodXNlX2dldHJhbmRvbSAmJiBfX2dldHJhbmRvbSAoJnIsIHNpemVvZiByLCBHUk5EX05P TkJMT0NLKSA9PSBzaXplb2YgcikKICAgICByZXR1cm4gcjsKLSNpZiBfTElCQyB8fCAoZGVm aW5lZCBDTE9DS19NT05PVE9OSUMgJiYgSEFWRV9DTE9DS19HRVRUSU1FKQorI2lmIEhBU19D TE9DS19FTlRST1BZCiAgIC8qIEFkZCBlbnRyb3B5IGlmIGdldHJhbmRvbSBkaWQgbm90IHdv cmsuICAqLwogICBzdHJ1Y3QgX190aW1lc3BlYzY0IHR2OwogICBfX2Nsb2NrX2dldHRpbWU2 NCAoQ0xPQ0tfTU9OT1RPTklDLCAmdHYpOwpAQCAtMjY3LDYgKzI3MywxMyBAQCB0cnlfdGVt cG5hbWVfbGVuIChjaGFyICp0bXBsLCBpbnQgc3VmZml4bGVuLCB2b2lkICphcmdzLAogICAg ICBhbGlnbm1lbnQuICAqLwogICByYW5kb21fdmFsdWUgdiA9ICgodWludHB0cl90KSAmdikg LyBhbGlnbm9mIChtYXhfYWxpZ25fdCk7CiAKKyNpZiAhSEFTX0NMT0NLX0VOVFJPUFkKKyAg LyogQXJyYW5nZSBnZW5fdGVtcG5hbWUgdG8gcmV0dXJuIGxlc3MgcHJlZGljdGFibGUgZmls ZSBuYW1lcyBvbgorICAgICBzeXN0ZW1zIGxhY2tpbmcgY2xvY2sgZW50cm9weSA8aHR0cHM6 Ly9idWdzLmdudS5vcmcvNTcxMjk+LiAgKi8KKyAgc3RhdGljIHJhbmRvbV92YWx1ZSBwcmV2 X3Y7CisgIHYgXj0gcHJldl92OworI2VuZGlmCisKICAgLyogSG93IG1hbnkgcmFuZG9tIGJh c2UtNjIgZGlnaXRzIGNhbiBjdXJyZW50bHkgYmUgZXh0cmFjdGVkIGZyb20gVi4gICovCiAg IGludCB2ZGlnaXRzID0gMDsKIApAQCAtMzE4LDYgKzMzMSw5IEBAIHRyeV90ZW1wbmFtZV9s ZW4gKGNoYXIgKnRtcGwsIGludCBzdWZmaXhsZW4sIHZvaWQgKmFyZ3MsCiAgICAgICBpZiAo ZmQgPj0gMCkKICAgICAgICAgewogICAgICAgICAgIF9fc2V0X2Vycm5vIChzYXZlX2Vycm5v KTsKKyNpZiAhSEFTX0NMT0NLX0VOVFJPUFkKKyAgICAgICAgICBwcmV2X3YgPSB2OworI2Vu ZGlmCiAgICAgICAgICAgcmV0dXJuIGZkOwogICAgICAgICB9CiAgICAgICBlbHNlIGlmIChl cnJubyAhPSBFRVhJU1QpCi0tIAoyLjM0LjEKCg== --------------MG8oHTZLRs6SzariwQEGHrDK--