unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Maciej Kalandyk <m.kalandyk@outlook.com>
Cc: 67703@debbugs.gnu.org
Subject: bug#67703: Fix python-ts-mode syntax higlighting as to account for default arguments
Date: Sun, 10 Dec 2023 02:15:36 -0800	[thread overview]
Message-ID: <d9566e0a-e2bb-43fe-b85f-054583850714@gmail.com> (raw)
In-Reply-To: <83bkaywpe6.fsf@gnu.org>



On 12/9/23 10:19 PM, Eli Zaretskii wrote:
> [Please use Reply All to keep the bug tracker on the CC list.]
>
> Forwarding to the bug tracker:
>
>> From: Maciej Kalandyk <m.kalandyk@outlook.com>
>> Date: Sun, 10 Dec 2023 00:57:15 +0000
>> msip_labels:
>>
>> in this code without patch
>>
>> def test(x=None):
>>       return x
>>
>> x=None in function signature won't be highlighted as definition
Ok, the fix makes sense. Basically, in such a function:


"a" is fontified but "b" isn't, the patch will fontify "b".

One thing though, the patch contains some indentation changes to 
unrelated code.

Yuan





  reply	other threads:[~2023-12-10 10:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08  4:36 bug#67703: Fix python-ts-mode syntax higlighting as to account for default arguments Maciej Kalandyk
2023-12-08  6:51 ` Eli Zaretskii
     [not found]   ` <AM0PR10MB3586579D3A383D635692D5F88088A@AM0PR10MB3586.EURPRD10.PROD.OUTLOOK.COM>
2023-12-10  6:19     ` Eli Zaretskii
2023-12-10 10:15       ` Yuan Fu [this message]
2023-12-10 16:35 ` Maciej Kalandyk
2023-12-10 23:16   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9566e0a-e2bb-43fe-b85f-054583850714@gmail.com \
    --to=casouri@gmail.com \
    --cc=67703@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=m.kalandyk@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).