From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Raeburn Newsgroups: gmane.emacs.bugs Subject: bug#45872: 27.1; rcirc nick tracking Date: Mon, 26 Jul 2021 17:46:58 -0400 Organization: Red Hat, Inc. Message-ID: References: <87zh1bwbin.fsf@redhat.com> <87im11dzcz.fsf@gnus.org> <87czr99r23.fsf@posteo.net> <87wnpfzroo.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20078"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 Cc: Lars Ingebrigtsen , 45872@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 26 23:56:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m88aD-00052x-VY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Jul 2021 23:56:22 +0200 Original-Received: from localhost ([::1]:45308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m88aD-0006Jq-2O for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Jul 2021 17:56:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m88SA-0003iX-0k for bug-gnu-emacs@gnu.org; Mon, 26 Jul 2021 17:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40106) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m88S9-0006Mn-Mu for bug-gnu-emacs@gnu.org; Mon, 26 Jul 2021 17:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m88S9-00013D-H1 for bug-gnu-emacs@gnu.org; Mon, 26 Jul 2021 17:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Raeburn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Jul 2021 21:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45872 X-GNU-PR-Package: emacs Original-Received: via spool by 45872-submit@debbugs.gnu.org id=B45872.16273360303973 (code B ref 45872); Mon, 26 Jul 2021 21:48:01 +0000 Original-Received: (at 45872) by debbugs.gnu.org; 26 Jul 2021 21:47:10 +0000 Original-Received: from localhost ([127.0.0.1]:51652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m88RK-000120-4G for submit@debbugs.gnu.org; Mon, 26 Jul 2021 17:47:10 -0400 Original-Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m88RH-00011s-ED for 45872@debbugs.gnu.org; Mon, 26 Jul 2021 17:47:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627336027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XX8wZfAPd908/oxMkTlDfsU78RIOyHWWVWYmbevDUfk=; b=HoFOnSqMfmBVZ3/8KwV2kVRSqgcBqCyLjUZyvz6nKLZJovEIkm9oHjwvzNhvIliqwwbnzo IgfjmAsS5mhdUC/48mbK7ba7M3CaKfnEGw91W0XOnkAiqedbY7SdyqIoHAMgX7r8PWmv28 4guAZSFQ/HBODZd9e6c3SVwXGiQIq5g= Original-Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-271-prAnVOZXNOmkqfaZOi5YJA-1; Mon, 26 Jul 2021 17:47:05 -0400 X-MC-Unique: prAnVOZXNOmkqfaZOi5YJA-1 Original-Received: by mail-wm1-f69.google.com with SMTP id o32-20020a05600c5120b0290225ef65c35dso199107wms.2 for <45872@debbugs.gnu.org>; Mon, 26 Jul 2021 14:47:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=XX8wZfAPd908/oxMkTlDfsU78RIOyHWWVWYmbevDUfk=; b=U4/zdPKpS07qX3wq1pJYsX89aZBaEk1TGtw1MG4SNsNV0ZNHDvZ7hOsZXrplDAY8do 5Wg5znyWTCLCe7GiLc+UvufbMWvxi8S1dy12hyaekvxMe40UqvyMWPzyYoTeuW85LzcD Mr34CQKJTKOIicajD313UTxebfy41lizsTBkc3jDo2NIU+8mGRAXmJDdL6JJqy/jmeDy Y/6E1vLLLYrmtDWYRIRuGC847CxWnMViAcfnAviyVmr+VgT726mgQubqxfFjgA/eSutd dZikvQUjPaLTlygj80n9TMuGtSSNH+DfQdKypc/8WbjlyVHiPr25w4oXn18lwy9eP8G9 y8Kg== X-Gm-Message-State: AOAM533jSlbi5YqnmeG9FcgdMIIz+yUreRf3K95iejbip/1m15lVw8/V i5f+Ed2Q/x4xlL4H4UzHSx8VqnfR5+o2LHMMPJEJ0QsmJ0dsaPt04Wjkig5uTkKbSuj5pdGe+Pu LDVJRCeWNSAFsPh8= X-Received: by 2002:a05:6000:1367:: with SMTP id q7mr7519629wrz.395.1627336024680; Mon, 26 Jul 2021 14:47:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyUxS9MG90MCISfwXJlldW0jhUMpfUDgGaGUN8pxKwBodme9ZbawEed0MygM31Y7F2zTPtSA== X-Received: by 2002:a05:6000:1367:: with SMTP id q7mr7519617wrz.395.1627336024459; Mon, 26 Jul 2021 14:47:04 -0700 (PDT) Original-Received: from [192.168.23.129] (c-24-60-138-149.hsd1.ma.comcast.net. [24.60.138.149]) by smtp.gmail.com with ESMTPSA id a14sm929156wrf.97.2021.07.26.14.47.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jul 2021 14:47:04 -0700 (PDT) In-Reply-To: <87wnpfzroo.fsf@posteo.net> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=raeburn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210767 Archived-At: On 7/24/21 10:56 AM, Philip Kaludercic wrote: > Ken Raeburn writes: > I forgot to update this ticket... I found that rcirc-buffer-alist > included a nick that had text properties set, and scanning the list > didn't find a match. I used advice-add to postprocess the list after > rcirc-handler-NICK using string-equal to work around it, and that > seems to do the job (as long as I can stay connected). > > I haven't checked in a while to see if it's been fixed. If not, a > better fix might be stripping out the text properties before putting a > nick into the list. > That shouldn't be an issue, but I wonder where the text properties come > from. Could you find out what text properties these were that were > confusing rcirc? It's setting font-lock-face to rcirc-other-nick. Oh... but I'm mixing this up with some other issue, I think. My apologies... the text properties are stored, but they're just a distraction. The access methods like assoc-string do ignore them. Looking back at the 27.1 code I'm still running, I don't think there's anything even trying to update rcirc-buffer-alist in response to NICK. Rename the buffer, yes, but not change the key it's listed under. If a buffer johnsmith@irc.server is initially stored in the alist under the key "johnsmith" (or #("johnsmith" 0 9 (font-lock-face (rcirc-other-nick)))) then it'll still be stored under that key even if the buffer is renamed to johnsmith|away@irc.server. So one failure to rename the buffer is those cases where the key in rcirc-buffer-alist doesn't match, because a previous rename didn't update the key, and the handle hasn't been renamed back to its original value as stored in as a key in the alist. If the buffer rename back to remove the "|away" is missed, then I can't use the johnsmith|away@irc.server buffer to talk to johnsmith@irc.server any more, as I described in my original report. The handle info stored in the buffer is out of date. I can use "/msg johnsmith" and it'll create a new johnsmith@irc.server buffer, but another NICK message might try to rename that to johnsmith|away@irc.server again and would fail. Ken