From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#6227: Color isearch regexp submatches differently Date: Sat, 19 Sep 2020 15:19:30 -0700 (PDT) Message-ID: References: <87bpca15ja.fsf@mail.jurta.org> <87wruv1ohr.fsf@mail.jurta.org> <877hmvtn9t.fsf@mail.jurta.org> <874ohyppfs.fsf@mail.jurta.org> <8739ww1tjp.fsf@mail.jurta.org> <87d3vyaodq.fsf@mail.jurta.org> <87hbla4nl4.fsf@mail.jurta.org> <87mu1llak3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37050"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lennart Borgman , 6227@debbugs.gnu.org To: Lars Ingebrigtsen , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 20 00:20:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJlDH-0009XB-Oh for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 00:20:11 +0200 Original-Received: from localhost ([::1]:33750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJlDG-0001CI-Qj for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 18:20:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJlD9-00019z-1j for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 18:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJlD8-0008HT-Lp for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 18:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJlD8-0004wy-HK for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 18:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Sep 2020 22:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6227-submit@debbugs.gnu.org id=B6227.160055399119006 (code B ref 6227); Sat, 19 Sep 2020 22:20:02 +0000 Original-Received: (at 6227) by debbugs.gnu.org; 19 Sep 2020 22:19:51 +0000 Original-Received: from localhost ([127.0.0.1]:48346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJlCw-0004wU-RM for submit@debbugs.gnu.org; Sat, 19 Sep 2020 18:19:51 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:38048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJlCt-0004wB-KF for 6227@debbugs.gnu.org; Sat, 19 Sep 2020 18:19:49 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08JMDpVG179342; Sat, 19 Sep 2020 22:19:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=CuA8zFbe/Xf0LwgQTXzP7hC0LLRpjksLAbOogYL7uJs=; b=dSIsg+FAZLbOMyHlZu+ZPG31pIS5BrAcZOE4qCxN25RCBWBR1d2BTgF5GZFQtSNeIGtJ sO1yFJXeKXFcEj1ihtV29TsGng8bBvbStf0qfhUhkgwAj2k4+QeoROZN3rjDGrMdBgPs rG+sNXDQjr+Y6KB8+OP9a+2Dtn3/EjFTLZFY2ylqnlirArVXPQUaKpNWIe9nffWUEqU7 /hYDOCL56yUD2qQGvxWavMYwwmHD90/j4bsSAew0R4/2ZtT6qSW+d0qB0ROsxXs1ZxE8 zn39ZZdo5m0wg7r4+myHsTp8JU3TKlkzFSv5WPI6RJvKgriqu90joay3kP5jYWJBkLgV XQ== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 33n9dqsem4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 19 Sep 2020 22:19:41 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08JMJelQ167513; Sat, 19 Sep 2020 22:19:40 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 33na011p16-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 19 Sep 2020 22:19:40 +0000 Original-Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08JMJV5S010755; Sat, 19 Sep 2020 22:19:32 GMT In-Reply-To: <87mu1llak3.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9749 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 mlxscore=0 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009190193 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9749 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 phishscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 impostorscore=0 clxscore=1011 lowpriorityscore=0 suspectscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009190192 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188446 Archived-At: > I guess we should add a few more faces before applying? >=20 > Anybody else got any comments on this? Haven't tried the patch. But Isearch+ does this. It uses 8 faces, for the first 8 regexp levels (groups). (The code could be go further, repeating those 8 faces if needed for more groups, but I haven't found that that's needed.) For lazy-highlighting, the odd groups are highlighted differently from the even groups. The odd groups use face `isearchp-lazy-odd-regexp-groups'. That simple lazy highlighting actually helps quite a bit, I find. =20 There is also a user option for whether to highlight groups: `isearchp-highlight-regexp-group-levels-flag'. And a toggle command for that option: `M-s h R' (prefix `M-s' is for all Isearch stuff, `h' is for highlighting, and `R' is for regexp groups).