From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#20664: 25.0.50; Customize: Link option or face name to the source definition Date: Thu, 17 Sep 2020 20:30:59 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11871"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Oleh Krehel , 20664@debbugs.gnu.org To: Mauro Aranda , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 22:34:44 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJ0c8-0002yc-EX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 22:34:44 +0200 Original-Received: from localhost ([::1]:38612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJ0c7-0002ul-GD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 16:34:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJ0bS-0002tj-VN for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 16:34:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55906) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJ0bS-0002BD-Ee for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 16:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJ0bS-00083x-By for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 16:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 20:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20664 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 20664-submit@debbugs.gnu.org id=B20664.160037479330934 (code B ref 20664); Thu, 17 Sep 2020 20:34:02 +0000 Original-Received: (at 20664) by debbugs.gnu.org; 17 Sep 2020 20:33:13 +0000 Original-Received: from localhost ([127.0.0.1]:39219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ0af-00082s-L4 for submit@debbugs.gnu.org; Thu, 17 Sep 2020 16:33:13 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:42716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ0ad-00082d-7p for 20664@debbugs.gnu.org; Thu, 17 Sep 2020 16:33:12 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08HKOfVE029483; Thu, 17 Sep 2020 20:33:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=OvfOyatoKsUiWZXb50RCTZcRZ7UrSXqDHSs2GPEkxeA=; b=MBgtYtahop5yl+CZnRCoapjFJbE0P38JQgFpZIwHjkz82ZvLeoVz+xSPaA0MRTTF+7Vv 29SEWgIxv3dPFUQCUQWrZ2bTTZmiZ/g1hj+EME8ILoZPbOn3F/a2/5qovYQaV+Xpe9um FsSVcRwUjUX0/pQkLtiVdaPMJMU3TJgKZVgQYkjnSAUrtiCWS0RLIqLVdlb4ixjprLLH pB07yjHmmGAgHfBEayNgJZtJcedQYtk4Ak4PbWW+DUUPHEWMKEFvb2hlltb72xzwiwKx YHitbQUZN1snSxYctCMGK0jzFMDJRd1v1NvL71K111wtoFvzDC76bkVY9pRKijKvx0YK Lw== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 33j91dwbbn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 17 Sep 2020 20:33:05 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08HKU6LS005599; Thu, 17 Sep 2020 20:31:04 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 33khpnm6ts-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Sep 2020 20:31:04 +0000 Original-Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08HKV1Q7012656; Thu, 17 Sep 2020 20:31:01 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9747 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009170151 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9747 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 mlxlogscore=999 clxscore=1011 adultscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009170150 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188254 Archived-At: >> Makes sense to me.=C2=A0 I tweaked it a bit before applying, though -- u= sed >> insert-text-button for convenience. > > Why a button.el button, and not a link widget? Using a > button.el button makes it look like TAB is inconsistent, > because it skips the button, so you can't get to the > button by just pressing TAB. > > And given there are links to which you can get to by > pressing TAB, not being able to reach this one makes > it feel like something is wrong. [Caveat: I haven't tried the updated code.] Yes, it's important that the fix fit well with Customize, both from a UI/user point of view and from a coding point of view. Please also do make sure that `mouse-1-click-follows-link' is effective, i.e., that it has its expected effect when either nil or non-nil. (I have it set to nil, BTW.)