From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#62426: [PATCH] eshell: Add 'rgrep' builtin. Date: Fri, 24 Mar 2023 17:04:56 -0700 Message-ID: References: <87jzz5eucl.fsf@mailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19659"; mail-complaints-to="usenet@ciao.gmane.io" To: Antero Mejr , 62426@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 13:28:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg30K-0004vg-6E for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 13:28:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg309-00086U-4S; Sat, 25 Mar 2023 08:28:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg307-00085z-Ju for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:28:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg307-0005Pj-BS for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg305-0004w5-VO for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 12:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62426-submit@debbugs.gnu.org id=B62426.167974724418924 (code B ref 62426); Sat, 25 Mar 2023 12:28:01 +0000 Original-Received: (at 62426) by debbugs.gnu.org; 25 Mar 2023 12:27:24 +0000 Original-Received: from localhost ([127.0.0.1]:42021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2zU-0004v9-70 for submit@debbugs.gnu.org; Sat, 25 Mar 2023 08:27:24 -0400 Original-Received: from mail-oa1-f42.google.com ([209.85.160.42]:35397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2zT-0004uv-6J for 62426@debbugs.gnu.org; Sat, 25 Mar 2023 08:27:23 -0400 Original-Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-177ca271cb8so4525252fac.2 for <62426@debbugs.gnu.org>; Sat, 25 Mar 2023 05:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679747229; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=Q71FraRDOOfXG7Dqk7odgslW2mKbY26+dLyxB0XyodY=; b=ZNMWYnFpf8f7aYTVAa7ehVJtunynS8Iju5txvWDoeoLKvQdcQmkH2PLmQxA3RDKCX+ pJ4TGxvNGVaVfP1EyCB8X73V2MxvqeR7w6FAASQoOa0p0uiuiLB6l9khDP2nMxSAb4TQ HO0Cv38HCIbAiAM3iiU72mOIfkZyLdZQdPPo9Y2eVZi4TFZpyNBAXKsefCFjK/2dM1Zm up7LDNoytcbijBd20gqmX5WNqaCEJF8K4d0S6IK9XvTNM3MiM7pWLmKTe3jECfv+znll 5C8jSGv4ZrL8NbHkar9WFGFNodjfQir45NnZgefxGLJgBHc4Eobi2oH7f/5D+UohtIFl AMcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679747229; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q71FraRDOOfXG7Dqk7odgslW2mKbY26+dLyxB0XyodY=; b=n86RVQ926SGmBRlb6VM95ll9fZDlTlgPh8EbrGg2zEWH5d6Zml7jXH6kktflgtVEnK lpXm+wcTVFigr9e3rnrOB/AXPBGDi9x58GxRch6cQ6HGzOfTpbJdbDjoArCjpW8W4/ZL YO0XYpFVkAWiOLzV8rWfAO8S6QOxWYcn7K31Wh7FzPrXdi7XMXrPcGEaNBbQy0dRkZ/z ya3JNZEtPl/e0M34e+t7rvmyV5Z6dhC9imYsI6L0PWMRir9Reck5V6wgrgACCquk/jAc ruEWsmYsNRIjfDX/PhBnbPRNLL4UzAcaoehx1wwa5AsshPKmvcmz7qXChjrE9r6fdzN0 GH7g== X-Gm-Message-State: AAQBX9eR1YAmDUjPe1FGvExGkt4Gf/gmqYEiXMEsUctFpHNodZqzZeNg r+nDBKhlQ9yAIJHOukhHzjci+WRCb2M= X-Google-Smtp-Source: AKy350Y3topRkQSB+y0752DChVB7lgnbLYWJ/CziNDMCxrzOZPNmmKZvKU8P0bs1rPqdIut60snSXA== X-Received: by 2002:a17:90b:1e4a:b0:23b:7188:4b88 with SMTP id pi10-20020a17090b1e4a00b0023b71884b88mr4473451pjb.46.1679702696972; Fri, 24 Mar 2023 17:04:56 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id s12-20020a632c0c000000b004fadb547d0csm13755705pgs.61.2023.03.24.17.04.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 17:04:56 -0700 (PDT) Content-Language: en-US In-Reply-To: <87jzz5eucl.fsf@mailbox.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258551 Archived-At: On 3/24/2023 2:02 PM, Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > > eshell has builtins for agrep/egrep/fgrep that use the Emacs grep > feature, but rgrep is not included so it behaves differently. This patch > adds the rgrep builtin. Thanks, I think it would make sense to add an rgrep built-in to Eshell. However, I'm not sure if this is the best way for it to work. Personally, I'd have expected this to use the 'rgrep' function in Emacs Lisp (which uses find + grep to do its job). That's a bit different from /usr/bin/rgrep, but I find it a lot more useful since it ignores "uninteresting" files by default. For example, 'M-x rgrep' in a Git repo ignores the .git/ subdir, but /usr/bin/rgrep includes that subdir. Hence, I'd almost always prefer Emacs' version of rgrep. That said, it might be a bit strange for Eshell's rgrep to work this way, when Eshell's agrep/egrep/fgrep work like the external versions. This seems like a tricky case...