From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Peter Oliver Newsgroups: gmane.emacs.bugs Subject: bug#63318: Variable ediff-auto-refine doesn't always default to "on" Date: Mon, 8 May 2023 11:26:47 +0100 (BST) Message-ID: References: <83pm7egf0o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="-1463811583-1042395094-1683455828=:3752" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39929"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63318@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 08 12:27:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvy5S-000ABM-M1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 May 2023 12:27:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvy5A-0000Nz-B2; Mon, 08 May 2023 06:27:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvy58-0000Nn-Ev for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 06:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvy58-0002Qc-6J for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 06:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvy57-0005MF-LY for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 06:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Peter Oliver Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 May 2023 10:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63318-submit@debbugs.gnu.org id=B63318.168354161820585 (code B ref 63318); Mon, 08 May 2023 10:27:01 +0000 Original-Received: (at 63318) by debbugs.gnu.org; 8 May 2023 10:26:58 +0000 Original-Received: from localhost ([127.0.0.1]:39260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvy53-0005Lx-Tk for submit@debbugs.gnu.org; Mon, 08 May 2023 06:26:58 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:45179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvy52-0005Lg-1e for 63318@debbugs.gnu.org; Mon, 08 May 2023 06:26:56 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3f1950f569eso28212845e9.2 for <63318@debbugs.gnu.org>; Mon, 08 May 2023 03:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mavit.org.uk; s=google; t=1683541610; x=1686133610; h=content-id:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GztFei+LI99MG9NPr53W2yD0lI/5Q27SS4OhKt1N4DM=; b=AZz9Hjjw77YD3CNb7nad2fKg6dTumelrRyBQN03bsQr7hC0Tb362+pVC4Uf4TF6oAv GplYSWPg0fTVfojGeM43Dym4Iz8nd3EzF4GnJHXT8P7KmiWFqYlty20MUqQK+PXHF99F 7qfNASn1GAcALIgjRNDJdOdsCubufUm07mtHM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683541610; x=1686133610; h=content-id:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GztFei+LI99MG9NPr53W2yD0lI/5Q27SS4OhKt1N4DM=; b=AQjilXfYaw0rbd+qIYAZoc2APg3JguQFs+fohho1y1wDe6NYooAvgWxsU0DgP7iwYA Lx+tso3YluCwj31hCpYCy1Mg3/nH9gu1aAMZbt7cyDvYO5Bu9ewyvJv9vYDJbxLnS8ah fQc8zrBl3zFneLGFhYDmCyjdxCnLx2kunTJXwlM0dgY4k7Vpno6/o8vhkZkYwbbM28U9 ZRyWHA2LgUuDxuGZX6evSHw3cWRF/LL6jRQiIep4WjoI/aFdkHIjnNElrZO3dgaX9DO6 YfqfIL1S52hyM8Pi5RVc0b6DaBL+b3UjqNrz5jaON21m+MkVZHZZORxnATxC+h2JCXZ/ SGvw== X-Gm-Message-State: AC+VfDyR1D+6Cnl+FVWA0NpRCvsOynNJOCzwLe53Sdy1I7Z66ZmEeYCr thmTv8S9+XLw/HKw5N/Dp3cK+A== X-Google-Smtp-Source: ACHHUZ7MA2Tdh0sZnmjX/S6eg/rEQireo9V1cVGemsWGWDr/Pfj5FcvC4eVhA+JSPElVdSNt6we+NQ== X-Received: by 2002:a7b:cb57:0:b0:3f1:7a4a:7f9 with SMTP id v23-20020a7bcb57000000b003f17a4a07f9mr6801604wmj.7.1683541610096; Mon, 08 May 2023 03:26:50 -0700 (PDT) Original-Received: from froglet.home.mavit.org.uk (dudl-14-b2-v4wan-165814-cust1925.vm31.cable.virginm.net. [82.34.135.134]) by smtp.gmail.com with ESMTPSA id c20-20020a7bc014000000b003ef64affec7sm16357670wmb.22.2023.05.08.03.26.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 03:26:49 -0700 (PDT) Original-Received: from froglet.home.mavit.org.uk (localhost [127.0.0.1]) by froglet.home.mavit.org.uk (8.17.1/8.17.1) with ESMTPS id 348AQmWT007610 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 8 May 2023 11:26:48 +0100 Original-Received: from localhost (mavit@localhost) by froglet.home.mavit.org.uk (8.17.1/8.17.1/Submit) with ESMTP id 348AQlst007607; Mon, 8 May 2023 11:26:47 +0100 X-Authentication-Warning: froglet.home.mavit.org.uk: mavit owned process doing -bs In-Reply-To: <83pm7egf0o.fsf@gnu.org> Content-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261300 Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811583-1042395094-1683455828=:3752 Content-Type: text/plain; CHARSET=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Content-ID: <7fd3f068-4384-1679-fe9a-6f37b3ccb798@froglet.home.mavit.org.uk> On Sat, 6 May 2023, Eli Zaretskii wrote: >> Date: Fri, 5 May 2023 21:21:50 +0100 (BST) >> From: Peter Oliver >> >> Document that variable ediff-auto-refine doesn't always default to "on". > > Wouldn't it be better to instead fix this, so that the default is > always "on"? > > Why doesn't Ediff turn on ediff-auto-refine for all terminals? > AFAICT, it only needs faces (basically, colors), and we support that > on all terminals nowadays? So I think we should simply change the > default value (which will also solve bug#63317). Or what am I > missing? I assumed that this complication was present because there exist displays on which auto-refinement isn’t desirable. If that’s no-longer the case, then great, simplifying the default to always be “on” certainly sounds like the best way to go to me. Attached is a patch to do that instead. -- Peter Oliver ---1463811583-1042395094-1683455828=:3752 Content-Type: text/plain; charset=US-ASCII; name=0001-Always-default-ediff-auto-refine-to-on.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0001-Always-default-ediff-auto-refine-to-on.patch RnJvbSA1MDA4NTBhODJlMDc5NjFkZDk4MTg3NDI4YTVhMTc2OGY1ZTc3Njgy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogUGV0ZXIgT2xpdmVy IDxnaXRAbWF2aXQub3JnLnVrPg0KRGF0ZTogTW9uLCA4IE1heSAyMDIzIDEx OjI0OjUzICswMTAwDQpTdWJqZWN0OiBbUEFUQ0hdIEFsd2F5cyBkZWZhdWx0 IGVkaWZmLWF1dG8tcmVmaW5lIHRvICdvbg0KDQoqIGxpc3AvdmMvZWRpZmYt ZGlmZi5lbCAoZWRpZmYtYXV0by1yZWZpbmUpOiBhbHdheXMgZGVmYXVsdCB0 byAnb24uDQotLS0NCiBsaXNwL3ZjL2VkaWZmLWRpZmYuZWwgfCAyICstDQog MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0p DQoNCmRpZmYgLS1naXQgYS9saXNwL3ZjL2VkaWZmLWRpZmYuZWwgYi9saXNw L3ZjL2VkaWZmLWRpZmYuZWwNCmluZGV4IDgzMmUzOTMzZGY5Li4wZWU5NzNh NGRlNiAxMDA2NDQNCi0tLSBhL2xpc3AvdmMvZWRpZmYtZGlmZi5lbA0KKysr IGIvbGlzcC92Yy9lZGlmZi1kaWZmLmVsDQpAQCAtMTQyLDcgKzE0Miw3IEBA IGVkaWZmLWRpZmYtc3RhdHVzDQogDQogOzs7IEZpbmUgZGlmZmVyZW5jZXMN CiANCi0oZWRpZmYtZGVmdmFyLWxvY2FsIGVkaWZmLWF1dG8tcmVmaW5lIChp ZiAoZWRpZmYtaGFzLWZhY2Utc3VwcG9ydC1wKSAnb24gJ25peCkNCisoZWRp ZmYtZGVmdmFyLWxvY2FsIGVkaWZmLWF1dG8tcmVmaW5lICdvbikNCiAgICJJ ZiBgb24nLCBFZGlmZiBhdXRvLWhpZ2hsaWdodHMgZmluZSBkaWZmcyBmb3Ig dGhlIGN1cnJlbnQgZGlmZiByZWdpb24uDQogSWYgYG9mZicsIGF1dG8taGln aGxpZ2h0aW5nIGlzIG5vdCB1c2VkLiAgSWYgYG5peCcsIG5vIGZpbmUgZGlm ZnMgYXJlIHNob3duDQogYXQgYWxsLCB1bmxlc3MgdGhlIHVzZXIgZm9yY2Ut cmVmaW5lcyB0aGUgcmVnaW9uIGJ5IGhpdHRpbmcgYConLg0KLS0gDQoyLjQw LjENCg0K ---1463811583-1042395094-1683455828=:3752--