unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: WAROQUIERS Philippe via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "55636@debbugs.gnu.org" <55636@debbugs.gnu.org>,
	"DE BACKER Jurgen \(EXT\)" <jurgen.de-backer.ext@eurocontrol.int>,
	VAN VLIERBERGHE Stef <stef.van-vlierberghe@eurocontrol.int>
Subject: bug#55636: 27.2; etags performance fix when working with very big TAGS files
Date: Thu, 26 May 2022 20:45:08 +0000	[thread overview]
Message-ID: <d7e91e5851bd4c7e922c37d4be659caa@eurocontrol.int> (raw)
In-Reply-To: <83leuonm8m.fsf@gnu.org>

> > So, what we can observe there is that the C function Fexpand_file_name makes 236_905 calls
> >
> > to Ffind_File_name_handler
> >
> > This Ffind_file_name_handler function makes 1.2 million calls to fast_string_match.
> >
> >
> >
> > On this screenshot, we cannot see the CPU directly consumed by the functions,
> >
> > but looking at the direct cpu shows that expand-file-name  cost is mostly due to the fast_string_match closure
>
> The Lisp profile tells quite a different story: according to that,
> expand-file-name is not a hotspot.
>
> So I still don't see  that expand-file-name is the place to optimize
> your use case.
>
> Did you succeed in reproducing the 10-sec delay with the original
> code, and then ten-fold speedup if expand-file-name is called only on
> non-absolute file names?

I have tried to reproduce the 10 seconds delay to no success.
With or without the expand-file-name called only on non absolute file names,
 I now see emacs always using about 4 seconds of cpu to load the TAGS files.

So, at this point:
   * I do not understand why we observed 3 different speed:
      sub-second, 4 seconds and 10 seconds
   * we now see that loading the TAGS files takes around 4 seconds, so is still a heavy
      operation that maybe could be optimised but not clear anymore what is the
      costly part.

Thanks
Philippe

____

This message and any files transmitted with it are legally privileged and intended for the sole use of the individual(s) or entity to whom they are addressed. If you are not the intended recipient, please notify the sender by reply and delete the message and any attachments from your system. Any unauthorised use or disclosure of the content of this message is strictly prohibited and may be unlawful.

Nothing in this e-mail message amounts to a contractual or legal commitment on the part of EUROCONTROL, unless it is confirmed by appropriately signed hard copy.

Any views expressed in this message are those of the sender.





      reply	other threads:[~2022-05-26 20:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 16:04 bug#55636: 27.2; etags performance fix when working with very big TAGS files Jurgen De Backer via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-25 17:16 ` Eli Zaretskii
2022-05-25 20:42   ` VAN VLIERBERGHE Stef via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-26  5:07     ` Eli Zaretskii
2022-05-26 13:50       ` VAN VLIERBERGHE Stef via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-26 14:54         ` WAROQUIERS Philippe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-26 15:09           ` Eli Zaretskii
2022-05-26 17:25             ` WAROQUIERS Philippe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-26 19:10               ` Eli Zaretskii
2022-05-26 20:45                 ` WAROQUIERS Philippe via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7e91e5851bd4c7e922c37d4be659caa@eurocontrol.int \
    --to=bug-gnu-emacs@gnu.org \
    --cc=55636@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jurgen.de-backer.ext@eurocontrol.int \
    --cc=philippe.waroquiers@eurocontrol.int \
    --cc=stef.van-vlierberghe@eurocontrol.int \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).