From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#71727: Deleting TAGS buffer will cause `etags-regen--update-file` doesn't work Date: Thu, 11 Jul 2024 03:50:15 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12155"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 71727-done@debbugs.gnu.org To: Siyuan Chen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 11 02:51:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRi26-000303-8i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jul 2024 02:51:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRi1a-00072y-5b; Wed, 10 Jul 2024 20:51:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRi1X-00072T-PV for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2024 20:51:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRi1X-0004y0-HF for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2024 20:51:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRi1W-0007Pi-GK for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2024 20:51:02 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2024 00:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71727 X-GNU-PR-Package: emacs Mail-Followup-To: 71727@debbugs.gnu.org, dmitry@gutov.dev, chansey97@gmail.com Original-Received: via spool by 71727-done@debbugs.gnu.org id=D71727.172065902728447 (code D ref 71727); Thu, 11 Jul 2024 00:51:02 +0000 Original-Received: (at 71727-done) by debbugs.gnu.org; 11 Jul 2024 00:50:27 +0000 Original-Received: from localhost ([127.0.0.1]:50594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRi0w-0007Ol-HD for submit@debbugs.gnu.org; Wed, 10 Jul 2024 20:50:26 -0400 Original-Received: from fout6-smtp.messagingengine.com ([103.168.172.149]:55255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRi0t-0007OY-Vh for 71727-done@debbugs.gnu.org; Wed, 10 Jul 2024 20:50:25 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 0D6BE138129A; Wed, 10 Jul 2024 20:50:19 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 10 Jul 2024 20:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1720659019; x=1720745419; bh=OR6iEekYIwFc3BooNHK3yRoZ0i/fdDupljDfNYX1API=; b= oHPUATYRm1HUXfzZvaIboFg1BCCNUN69NmCYk7dAcVZC6QOE2R0cMsEWr7DQhv0Z KWdrJPoFbdQJNU7HnGS8oIiuzPlZLWDgjaW0T6mHyJyu4SC9tMW8hvG+LR+VA9n8 uVZHb0KexyV+avIQ5voiHl+bg2ksU6A3rJ41LMHrMFLHXTeZXRbMWcwofS9nK7NT XyekQ9uDoWtZaGJ7pf3n7u9QBxy3Jzk5HFrPew+KN+6LmIOuMSNYI03X7fOShEx+ U8Wr7YmUEQjKDn1zTntui6vu+vM+8hDfo4sDQU57KmrtJ8BQrx1ZApPTF0vc2gNr pKVoq+v/jmPrAGpx/VcRww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1720659019; x= 1720745419; bh=OR6iEekYIwFc3BooNHK3yRoZ0i/fdDupljDfNYX1API=; b=M AS5gSCKzaxcBfFPUKCd3Vm6Pu6Wxei9lfSVDVzLoQMas8UdxA/18ZBWVQt/SdZdt kKtXjeMxaXFIRlqhGEszXmxI8gcdn9+dWK58EV0pwIglZhA9eLWE48uq7VkDpYB7 P4PBB+hpl01XcTjbwacUtQ2m1oGvglb9EowbQePBZxMczT5XnA4dYtlFyXlnxMl1 /L7RUhdrXnLazGQjU0o4T1D/ygIaUzaqCcJMoK39aoOuONlXuub2hEAExomL82Cg o8/Z7NuydEnIXHgVrR2LDfR2IXx5ez7212nBezqAqFprbWiO8kyil2s8uRJ6/qTP jaxBrLcWAWamG+MWmMiNw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrfeefgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffhvfevfhgjtgfgsehtke ertddtvdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhepvdelieejveekjeelffegudeiudejff fhveduudffvdevteekgeevffejgfffleeunecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 Jul 2024 20:50:16 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288706 Archived-At: Now pushed to emacs-30, please report any further problems. On 09/07/2024 05:50, Dmitry Gutov wrote: > On 29/06/2024 14:49, Siyuan Chen wrote: >>  > Is there are particular reason you killed the TAGS buffer? >> >> No. I found this bug is just because I tried to view the TAGS content >> while editing a .c file and then closed it (I am using tab-line-mode >> with tab-line-close-tab-function set to kill-buffer). Since then, I >> have stopped closing the TAGS buffer. > > Thanks for the clarification. > >> Another option is to temporarily add documentation advising users not >> to close the TAGS buffer, because closing it accidentally can result >> in the odd behavior. > > I think actually a simpler approach can suffice: using kill-buffer-hook > in the TAGS buffer. Like this: > > diff --git a/lisp/progmodes/etags-regen.el b/lisp/progmodes/etags-regen.el > index dc778b14061..21ea9bfb8b3 100644 > --- a/lisp/progmodes/etags-regen.el > +++ b/lisp/progmodes/etags-regen.el > @@ -294,7 +294,9 @@ etags-regen--visit-table >    (add-hook 'before-save-hook #'etags-regen--mark-as-new) >    (setq etags-regen--tags-file tags-file >          etags-regen--tags-root root) > -  (visit-tags-table etags-regen--tags-file)) > +  (visit-tags-table etags-regen--tags-file) > +  (with-current-buffer (get-file-buffer tags-file) > +    (add-hook 'kill-buffer-hook #'etags-regen--tags-cleanup nil t))) > >  (defun etags-regen--ctags-p () >    (string-search "Ctags" > @@ -390,7 +392,8 @@ etags-regen--mark-as-new > >  (defun etags-regen--tags-cleanup () >    (when etags-regen--tags-file > -    (let ((buffer (get-file-buffer etags-regen--tags-file))) > +    (let ((buffer (get-file-buffer etags-regen--tags-file)) > +          kill-buffer-hook) >        (and buffer >             (kill-buffer buffer))) >      (tags-reset-tags-tables)