unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: casouri@gmail.com, 71070@debbugs.gnu.org
Subject: bug#71070: 30.0.50; c++-ts-mode namespace wrong fontification.
Date: Sun, 19 May 2024 23:36:41 +0200	[thread overview]
Message-ID: <d7akmu62i2mumejjztwdtgmvktdijbhi4c7fbha5ysb6inagzd@dcxxxncbgnd6> (raw)
In-Reply-To: <86v839aa3a.fsf@gnu.org>

On Sun, May 19, 2024 at 10:13:45PM GMT, Eli Zaretskii wrote:
>> Date: Sun, 19 May 2024 21:00:42 +0200
>> From: Ergus <spacibba@aol.com>
>> Cc: Yuan Fu <casouri@gmail.com>, 71070@debbugs.gnu.org
>>
>> >Why do you think std should be in font-lock-constant-face?  The name
>> >of a namespace is not a constant, it's an identifier.
>>
>> Hi Eli:
>>
>> That's how namespaces are fontified in the c++-mode. Not telling it is
>> correct, wrong or if needs improvement; just that c++-ts-mode is not
>> doing in the same way.
>>
>> Try this:
>>
>> ```main.cpp
>>
>> const std::string a;
>>
>> class myclass {
>> 	std::time::timespec var;
>> };
>>
>> int main()
>> {
>> 	std::string b = 1;
>>
>> 	
>> }
>> ```
>>
>> and then M-x c++-ts-mode you will see the difference.
>
>No one said that what c++-mode does is necessarily correct.  maybe it
>is, maybe it isn't.
>
>How do other C++ IDEs fontify namespace names?

Hi Eli:

Every editor-ide has its own approach for this. But emacs has it own
flavor and the ts-* intention was to keep it as close as possible to the
status-quo; that's why I am reporting it here.

There are many details missing in the c/c++-ts-mode compared to
c-mode... but I understand that some of them are WIP while others are
just too complex to port.

My main concern here is that this seemed like a simple issue considering
that treesitter recognizes the namespace correctly. But the Yuan's fix
didn't work; so maybe there is a detail we are missing here, or that
needs extra documentation? Or in the worst case some detail/issue broken
in the ts api?

Best,
Ergus





  reply	other threads:[~2024-05-19 21:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87h6et6550.fsf.ref@aol.com>
2024-05-19 18:14 ` bug#71070: 30.0.50; c++-ts-mode namespace wrong fontification Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-19 18:36   ` Eli Zaretskii
2024-05-19 19:00     ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-19 19:13       ` Eli Zaretskii
2024-05-19 21:36         ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-20 11:11           ` Eli Zaretskii
2024-05-21 23:27             ` Dmitry Gutov
2024-05-22  6:23               ` Yuan Fu
2024-05-22 12:17               ` Eli Zaretskii
2024-05-22 13:33                 ` Dmitry Gutov
2024-06-06  5:28                   ` Yuan Fu
2024-06-06 20:16                     ` Dmitry Gutov
2024-06-15  8:34                       ` Eli Zaretskii
2024-06-19  6:27                         ` Yuan Fu
2024-06-19 11:52                           ` Eli Zaretskii
2024-06-21  1:53                             ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7akmu62i2mumejjztwdtgmvktdijbhi4c7fbha5ysb6inagzd@dcxxxncbgnd6 \
    --to=bug-gnu-emacs@gnu.org \
    --cc=71070@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).