unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Matthew Dempsky <matthew@dempsky.org>
To: 5030@emacsbugs.donarmstrong.com
Subject: bug#5030: 23.1.50; Unexpected minibuffer tab completion behavior
Date: Tue, 24 Nov 2009 18:24:34 -0800	[thread overview]
Message-ID: <d791b8790911241824w3ed37633w224a63c5d79abed8@mail.gmail.com> (raw)
In-Reply-To: <d791b8790911232209v3b203d78rbb6744ddfe72e63e@mail.gmail.com>

On Mon, Nov 23, 2009 at 10:09 PM, Matthew Dempsky wrote:
> Instead, I expect either for that window to continue showing the
> *Completion* buffer (refreshed to display just the "aaa" and "aab"
> entries) or for that window to be deleted.  (I'd prefer the former
> behavior.)

The last patch I posted achieves the latter behavior.  Combining with
the (proof-of-concept) patch below, I seem to achieve the former
(personally more desirable) behavior.

--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -489,10 +489,11 @@ E = after completion we now have an Exact match.
 					minibuffer-completion-table
 					minibuffer-completion-predicate)))
             (if completed
-                ;; We could also decide to refresh the completions,
-                ;; if they're displayed (and assuming there are
-                ;; completions left).
-                (minibuffer-hide-completions)
+		(cond
+		 (exact (minibuffer-hide-completions))
+		 ((get-buffer-window "*Completions*" 0)
+		  (minibuffer-completion-help))
+		 (t t))
               ;; Show the completion table, if requested.
               (cond
                ((not exact)





  parent reply	other threads:[~2009-11-25  2:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24  6:09 bug#5030: 23.1.50; Unexpected minibuffer tab completion behavior Matthew Dempsky
2009-11-25  1:08 ` bug#5036: " Matthew Dempsky
2009-11-25  1:55   ` bug#5036: marked as done (23.1.50; Unexpected minibuffer tab completion behavior) Emacs bug Tracking System
2009-11-25  2:24 ` Matthew Dempsky [this message]
2009-11-25  8:42   ` bug#5030: 23.1.50; Unexpected minibuffer tab completion behavior Matthew Dempsky
  -- strict thread matches above, loose matches on Subject: below --
2009-11-25  1:09 Matthew Dempsky
2009-11-25  1:23 ` Matthew Dempsky
2009-11-25 16:36   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d791b8790911241824w3ed37633w224a63c5d79abed8@mail.gmail.com \
    --to=matthew@dempsky.org \
    --cc=5030@emacsbugs.donarmstrong.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).