From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#53897: 28.0.91; regression: rcirc overwrites completion-cycle-threshold Date: Wed, 9 Feb 2022 15:18:45 +0100 Message-ID: References: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> <87v8xo2o9q.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17232"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53897@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 09 16:07:56 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHoZY-0004Dt-2S for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Feb 2022 16:07:56 +0100 Original-Received: from localhost ([::1]:33888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHoZV-0000zC-Pi for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Feb 2022 10:07:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHnoI-0004CS-Dc for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 09:19:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56387) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHnoD-0000Ex-VB for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 09:19:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHnoD-0000Ar-N2 for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 09:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Feb 2022 14:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53897 X-GNU-PR-Package: emacs Original-Received: via spool by 53897-submit@debbugs.gnu.org id=B53897.1644416335656 (code B ref 53897); Wed, 09 Feb 2022 14:19:01 +0000 Original-Received: (at 53897) by debbugs.gnu.org; 9 Feb 2022 14:18:55 +0000 Original-Received: from localhost ([127.0.0.1]:50284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHno7-0000AU-LC for submit@debbugs.gnu.org; Wed, 09 Feb 2022 09:18:55 -0500 Original-Received: from server.qxqx.de ([178.63.65.180]:37945 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHno5-0000A5-7y for 53897@debbugs.gnu.org; Wed, 09 Feb 2022 09:18:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BbawT1e/DKU57VtGuvq7K767i7l17Ie/PwjqJ1ag0Lc=; b=P+LtYqBkVaSwVGriZCI3TporKs emq5IODaZDFZWHEHRAl9rGR0otFCL4cKRw/0BUQEhC2iKFnBaWnyto8x+eFgQdW10uPPqr7M8b9vT DYTgwaWaC0oBA0Bjc3cy31eDp5Jbj9txuXEPJ61J53eltWmnBdWPZAjNsKK+Z+G6y77Y=; Content-Language: en-US In-Reply-To: <87v8xo2o9q.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226485 Archived-At: > The change that introduced this was that the custom cycling > implementation was replaced with one based on completion-at-point > (0b367ec), mainly to simplify the code. The reason > `completion-cycle-threshold' is set is to preserve the appearance of the > previous behaviour, as a complete reversion to completion-at-point > seemed like too much of a change. I agree with your change to remove rcirc-complete. I greatly appreciate the simplicity of rcirc and it is good that you try to make it even simpler! But rcirc-completion-at-point was already present as Capf on Emacs 27 and there `completion-at-point` didn't lead to cycling. I would not introduce a user configuration, it is easy enough to set completion-cycle-threshold in a hook. Furthermore there is the alternative to use completion-category-defaults to specify the threshold per completion category. You could add the override there. But personally I would avoid doing that. I usually prefer if packages avoid intrusive and opinionated settings and instead try to ensure consistency across Emacs. > I could imagine introducing a user option to decide what you want to > use. My inclination would be to set it to "cycle by default", but it > doesn't need that way. Perhaps we could test non-cycling (regular capf) > for a while, and see if there are any complaints or other feedback? Yes, I would go with normal Capf behavior, which is the usual behavior across all of Emacs. If a user wants to restore rcirc-complete, it seems easy enough to add this to a user configuration? (defun rcirc-complete () (interactive) (let ((completion-cycle-threshold t)) (completion-at-point))) Thanks!