unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face
@ 2008-10-01  0:01 Chong Yidong
  2008-10-01  8:12 ` Tim Van Holder
  0 siblings, 1 reply; 21+ messages in thread
From: Chong Yidong @ 2008-10-01  0:01 UTC (permalink / raw)
  To: Tim Van Holder; +Cc: 598

Thanks for the backtrace.

Could you go to the third breakpoint, i.e.

  Fset_frame_size (frame=147078268, cols=896, rows=384)

and check the following variables?

n
n
n
n (until f is assigned)
p f->new_text_lines
p f->new_text_cols

Also, could you send me the minimal .emacs and .Xresources required to
reproduce this bug for you?

Thanks.






^ permalink raw reply	[flat|nested] 21+ messages in thread
* bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face
@ 2008-11-03 16:00 Chong Yidong
  2008-11-05 10:06 ` Tim Van Holder
  0 siblings, 1 reply; 21+ messages in thread
From: Chong Yidong @ 2008-11-03 16:00 UTC (permalink / raw)
  To: Tim Van Holder; +Cc: 598

 "Tim Van Holder" <tim.vanholder@gmail.com> writes:

> Unfortunately, even after a maintainer-clean + make bootstrap, the
> issue is not resolved for me.  In fact, the very first run of the new
> emacs resulted in a frame that was 168x61 instead of 132x57 (is that
> 132x60->132x57 as a result of menu/toolbars considered a bug or a
> feature?).

Does the following patch improve matters?

*** trunk/src/xfns.c.~1.727.~	2008-10-28 11:24:26.000000000 -0400
--- trunk/src/xfns.c	2008-11-03 10:33:55.000000000 -0500
***************
*** 3099,3104 ****
--- 3099,3118 ----
    x_default_parameter (f, parms, Qfont, font, "font", "Font", RES_TYPE_STRING);
  }
  
+ DEFUN ("x-wm-set-size-hint", Fx_wm_set_size_hint, Sx_wm_set_size_hint,
+        0, 1, 0,
+        doc: /* Send the size hints for frame FRAME to the window manager.  */)
+      (frame)
+      Lisp_Object frame;
+ {
+   struct frame *f;
+   if (NILP (frame))
+     frame = selected_frame;
+   f = XFRAME (frame);
+   BLOCK_INPUT;
+   x_wm_set_size_hint (f, 0, 0);
+   UNBLOCK_INPUT;
+ }
  
  DEFUN ("x-create-frame", Fx_create_frame, Sx_create_frame,
         1, 1, 0,
***************
*** 5944,5949 ****
--- 5958,5964 ----
    defsubr (&Sx_display_visual_class);
    defsubr (&Sx_display_backing_store);
    defsubr (&Sx_display_save_under);
+   defsubr (&Sx_wm_set_size_hint);
    defsubr (&Sx_create_frame);
    defsubr (&Sx_open_connection);
    defsubr (&Sx_close_connection);
*** trunk/lisp/term/x-win.el.~1.235.~	2008-08-30 19:54:06.000000000 -0400
--- trunk/lisp/term/x-win.el	2008-11-03 10:33:09.000000000 -0500
***************
*** 1540,1545 ****
--- 1540,1548 ----
    ;; Don't let Emacs suspend under X.
    (add-hook 'suspend-hook 'x-win-suspend-error)
  
+   ;; Set wm hints after initialization
+   (add-hook 'after-init-hook 'x-wm-set-size-hint)
+ 
    ;; Turn off window-splitting optimization; X is usually fast enough
    ;; that this is only annoying.
    (setq split-window-keep-point t)






^ permalink raw reply	[flat|nested] 21+ messages in thread
[parent not found: <87k5clg04k.fsf@cyd.mit.edu>]
* bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face
@ 2008-09-28 20:46 Chong Yidong
  2008-09-29  7:34 ` Tim Van Holder
  0 siblings, 1 reply; 21+ messages in thread
From: Chong Yidong @ 2008-09-28 20:46 UTC (permalink / raw)
  To: Tim Van Holder; +Cc: 598

> For a few weeks now (starting around the time of the fix for #47,
> which may or may not be relevant), emacs no longer comes up with the
> correct frame size.
>
> I have it set (to 132x60) in default-frame-alist, but emacs end up
> with varying frame sizes instead - while there seem to be a few that
> it favors, I can't see any real pattern in it.

Do you still see this problem?  I can't seem to reproduce it with latest
CVS.  I have no geometry set in my .Xresources file, and with the
following lines in .emacs:

 (add-to-list 'default-frame-alist '(width . 132))
 (add-to-list 'default-frame-alist '(height . 60))

Emacs seems to start with the appropriate width and height each time.






^ permalink raw reply	[flat|nested] 21+ messages in thread
* bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face
@ 2008-07-23  8:18 Tim Van Holder
  0 siblings, 0 replies; 21+ messages in thread
From: Tim Van Holder @ 2008-07-23  8:18 UTC (permalink / raw)
  To: emacs-pretest-bug


For a few weeks now (starting around the time of the fix for #47, which
may or may not be relevant), emacs no longer comes up with the correct
frame size.
I have it set (to 132x60) in default-frame-alist, but emacs end up with
varying frame sizes instead - while there seem to be a few that it
favors, I can't see any real pattern in it.
The same happens if I remove the width/height settings from
default-frame-alist and use --geometry instead.
"emacs -Q --geometry 132x60" does seem to work 100% of the time.

I tried erasing the font/foundry customization, but that made no
difference; changing the font height, however, did. Emacs seems to
default to a height of 116 while I have mine set to 135 (since with the
font I prefer to use (Terminus), 116 is too small to read comfortably).

So it looks like the frame size is being computed based on the wrong
font sizing.

A few things I noticed while testing this:
- customizing the size of the default font causes emacs to repain its
  frame, and quite often this messes up the scrollbars (which I have
  set to appear on the right). Sometimes there is a black border to
  their right, sometimes they disappear. In either case, manually
  sizing the frame makes them redraw in their correct place.
- after saving the default face with the font and foundry items
  unchecked (i.e. uncustomized), and restarting emacs, it shows the
  font and foundry as customized (using Bitstream Vera Sans Mono)
- the 'foundry' setting was also added fairly recently; how do I find
  out a font's foundry so that I can set it correctly when customizing
  a face? Is there perhaps a font picker available in emacs that would
  allow me to customize a face more effectively?






^ permalink raw reply	[flat|nested] 21+ messages in thread
end of thread, other threads:[~2008-11-05 10:06 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-01  0:01 bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face Chong Yidong
2008-10-01  8:12 ` Tim Van Holder
2008-10-01  8:47   ` martin rudalics
2008-10-01  9:52     ` bug#911: " Tim Van Holder
2008-10-01 13:05       ` martin rudalics
2008-10-01 13:57         ` Tim Van Holder
2008-10-03  8:25   ` Tim Van Holder
  -- strict thread matches above, loose matches on Subject: below --
2008-11-03 16:00 Chong Yidong
2008-11-05 10:06 ` Tim Van Holder
     [not found] <87k5clg04k.fsf@cyd.mit.edu>
2008-10-07 11:25 ` Tim Van Holder
2008-10-07 12:09   ` martin rudalics
2008-10-08  8:15     ` Tim Van Holder
2008-10-08 22:47   ` Chong Yidong
2008-10-09  8:09     ` Tim Van Holder
2008-09-28 20:46 Chong Yidong
2008-09-29  7:34 ` Tim Van Holder
2008-09-29  8:52   ` martin rudalics
2008-09-29  9:13     ` Tim Van Holder
2008-09-29 17:30   ` Chong Yidong
2008-09-30  7:39     ` Tim Van Holder
2008-07-23  8:18 Tim Van Holder

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).