From: "Tim Van Holder" <tim.vanholder@gmail.com>
To: "martin rudalics" <rudalics@gmx.at>
Cc: Chong Yidong <cyd@stupidchicken.com>,
911@emacsbugs.donarmstrong.com, 598@emacsbugs.donarmstrong.com
Subject: bug#911: bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face
Date: Wed, 1 Oct 2008 11:52:47 +0200 [thread overview]
Message-ID: <d69e7f6a0810010252g5ba6c7c8mb90cf1e55d8261be@mail.gmail.com> (raw)
In-Reply-To: <48E3391D.8090701@gmx.at>
On Wed, Oct 1, 2008 at 10:47 AM, martin rudalics <rudalics@gmx.at> wrote:
>> I'm also getting max-specpdl-size exceeded on C-x 5 2, so I cannot check
>> the
>> previously observed behaviour that even when the initial frame is
>> erratically
>> sized, subsequent frames are fine.
>
> That's most likely bug#911 (aka nine-eleven) see
>
> http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=911
>
> Could you try the recipe Chong gave there?
I tried a slightly different recipe (below) and that made the error go away.
I assume Chong's will work as well - I just wanted to set the inhibit
flag as early as possible (and I wasn't 100% sure whether or not the let
would use the defvar'd flag instead of its own scoped var).
--- faces.el.~1.425.~ 2008-09-25 10:49:34.000000000 +0200
+++ faces.el 2008-10-01 11:48:01.000000000 +0200
@@ -1839,10 +1839,13 @@ variable with `setq'; this won't have th
(declare-function x-get-resource "frame.c"
(attribute class &optional component subclass))
+(defvar inhibit-frame-set-background-mode nil)
(defun frame-set-background-mode (frame)
"Set up display-dependent faces on FRAME.
Display-dependent faces are those which have different definitions
according to the `background-mode' and `display-type' frame parameters."
+ (unless inhibit-frame-set-background-mode
+ (setq inhibit-frame-set-background-mode t)
(let* ((bg-resource
(and (window-system frame)
(x-get-resource "backgroundMode" "BackgroundMode")))
@@ -1914,7 +1917,8 @@ according to the `background-mode' and `
;; parameters, unless they have been locally modified.
(dolist (face (face-list))
(unless (memq face locally-modified-faces)
- (face-spec-recalc face frame)))))))
+ (face-spec-recalc face frame))))))
+ (setq inhibit-frame-set-background-mode nil)))
\f
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
next prev parent reply other threads:[~2008-10-01 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 0:01 bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face Chong Yidong
2008-10-01 8:12 ` Tim Van Holder
2008-10-01 8:47 ` martin rudalics
2008-10-01 9:52 ` Tim Van Holder [this message]
2008-10-01 13:05 ` martin rudalics
2008-10-01 13:57 ` Tim Van Holder
2008-10-03 8:25 ` Tim Van Holder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d69e7f6a0810010252g5ba6c7c8mb90cf1e55d8261be@mail.gmail.com \
--to=tim.vanholder@gmail.com \
--cc=598@emacsbugs.donarmstrong.com \
--cc=911@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).