From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#50256: thing-at-mouse Date: Thu, 2 Sep 2021 16:43:02 +0200 Message-ID: References: <87sfys6ubm.fsf@mail.linkov.net> <87eeacdnmg.fsf@gnus.org> <87h7f7z8ui.fsf@mail.linkov.net> <871r6a8ooe.fsf@gnus.org> <87y28i85xi.fsf@mail.linkov.net> <87k0k1o5ks.fsf@mail.linkov.net> <87ilzk6bsr.fsf@mail.linkov.net> <6dcf3191-dbb3-0c6c-2483-0fc05e9ff6e5@gmx.at> <83lf4gqyn9.fsf@gnu.org> <1a65f234-c1ee-ae95-aa05-2e3d9d1e1002@gmx.at> <8335qoqobm.fsf@gnu.org> <7c9cb0a1-b222-cb06-7e7c-7f17231faca3@gmx.at> <83pmtsp4g1.fsf@gnu.org> <831r67ph8d.fsf@gnu.org> <87tuj3bffb.fsf@gnus.org> <83y28fo1xf.fsf@gnu.org> <191e9cc6-7370-5b7d-7777-716b61e0155d@gmx.at> <83pmtrnydh.fsf@gnu.org> <158a8854-f56a-9aaa-3a14-d108e086a24c@gmx.at> <83k0jznms2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4882"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50256@debbugs.gnu.org, larsi@gnus.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 02 16:44:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLnwn-0000yo-Iz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 16:44:09 +0200 Original-Received: from localhost ([::1]:53324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLnwm-0006ad-5N for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 10:44:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLnwg-0006aV-9z for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 10:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLnwg-0006wV-1j for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 10:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLnwf-0004dR-SA for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 10:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Sep 2021 14:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50256 X-GNU-PR-Package: emacs Original-Received: via spool by 50256-submit@debbugs.gnu.org id=B50256.163059379517755 (code B ref 50256); Thu, 02 Sep 2021 14:44:01 +0000 Original-Received: (at 50256) by debbugs.gnu.org; 2 Sep 2021 14:43:15 +0000 Original-Received: from localhost ([127.0.0.1]:41714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLnvv-0004cJ-Ks for submit@debbugs.gnu.org; Thu, 02 Sep 2021 10:43:15 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:58173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLnvr-0004bw-Hm for 50256@debbugs.gnu.org; Thu, 02 Sep 2021 10:43:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1630593784; bh=6VhtAJW+6pv4VIb/npwB857XffHvMS9gXmUTLWWZSmA=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=VI18W1EsYww8B0YujhmdwSbkPGxlpKNjPFhbYiyNcs3f5IGURLqeVfmuIW9wyNFjW a8oeUJbKmy3j58VC0Le1PhMPPnXo2Smm/XHqFyoNSwSRurNe9AdsHAQ5yCISffgzuz ILJroFTvORMJ0OKlOL+4onuluEIbNBim1A578Uxg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([212.95.5.24]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mel3n-1mwFDB1ej7-00anm2; Thu, 02 Sep 2021 16:43:04 +0200 In-Reply-To: <83k0jznms2.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:CcC6qyjsRcygGxQ7E42nC4va5yoIfFadZGUwXA9sh8bbke4GegM ZR51jvr+djfS+bhMYpVBaw4tOuqfAMqm19sTKPP4nk9DHWbbB/tTFfvzKqtJgB5f/z14tbW tvZhI7RNp16xiAiCAVZbPzLEJO9IHXbqMwyTPLwD2xSQLqpnmauUW9Vt9GKeuGw71GdMoqm CF6POI8UieHn+s0r1OnSQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:TR8Nxln9CmY=:Clr1uKa5MpMQOdz/KIRah6 mobt7E4RnHEcPJdX2uvXzXzjQzcBXrLP6hVmSiDPyaI5wxfW1lqnUzP82IqxRCVQi53lzQi/2 KwWPFyN/HxRFXuKucwHmP479qofT1cgF1tCy0jrnA/wqpa7v05gRfXp1Kx4VHE2j9cO8Z1rTt YFDcoFjpymY0ITp0s2GV84CijNZLVgITrAdCMux4dnGsEg9KYNamPQAs3ku0C2fd/4FWKDGnC poiGhjSdLqtOTDqQIj1lGH3GLHCuO3eFj9Tx3yWmHwfsEIIZk9DgNTBiOq0xBWWi244wRCAG9 wGwGClnqijC/JzratrQVv2tbKxBxg6zbeP0N55E+rOdBeXjJkF+gzLZ1gcfkS3g1mdoS1tYAC 0HzIaw8u1hyS2J6ZtCjOKX2lr7Eg7+WOk1TF8j2QXF+gV7yWvcUIrdngIR7Pdca/nVFrzE5mW p7djJhSDdpZ1r8jDHQ8UzF9F+HvEJ+INVGCy++fZReIC7o3x65WvXykw539KAkE0v3k64zoD9 symAq0bOVz0E8bVp6Y+SM2kJqwlopq5XvUAHJS23QiaoZlz2EoxOR7YJPhhvW1abAQ5hzbWpG sVc6UUkKP0GRNyaqbn/GTYF1FGgfJklWNaDCr6EspR2AA7Un3gtGD9nkxEmWBxZThH6iByCm4 YaRFNag7TXZCLGm22N6qgJ5HXBSEOlhAVO0f/RklPLn1xLYYtC/S7hYQxBbVgJQ1tBHKIrI9s QGCgGZuuR/bstXxNfT5DTH+yHgJ8rYR43K/fcP6BK8ReqOK/t9uGftHVmIlf1kbc5I6b5o4B X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213272 Archived-At: >> >> pos_visible_p already does >> >> >> >> if (XBUFFER (w->contents) != current_buffer) >> >> { >> >> old_buffer = current_buffer; >> >> set_buffer_internal_1 (XBUFFER (w->contents)); >> >> } >> > >> > I'm asking if this is the desired behavior, when Lisp runs this inside >> > with-current-buffer? >> >> It is the _necessary_ behavior when WINDOW is not the selected window >> and its buffer is not current. > > But in the case in point, WINDOWS _was_ the selected window. That's > why pos-visible-in-window-p used PT. Which is what you said was the > bug. Or am I missing something? No. The above was meant in response to your earlier: If we want to support the current documentation to the letter, the only way of doing that I know of is to force WINDOW to display the current buffer, at least internally, i.e. to switch to the WINDOW's buffer for the duration of pos-visible-in-window-p. I mean that we needn't do that because pos_visible_p already does it. So I'd just propose to do the trivial (line numbers are not trunk's); diff --git a/src/window.c b/src/window.c index cb8fe5fcdb..bfbed01749 100644 --- a/src/window.c +++ b/src/window.c @@ -2199,8 +2199,6 @@ DEFUN ("pos-visible-in-window-p", Fpos_visible_in_window_p, posint = -1; else if (!NILP (pos)) posint = fix_position (pos); - else if (w == XWINDOW (selected_window)) - posint = PT; else posint = marker_position (w->pointm); martin