unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Bastien <bzg@altern.org>
Cc: 16542@debbugs.gnu.org
Subject: bug#16542: 24.3.50; When finding a file via a bookmark, that file is not part of file-name-history
Date: Mon, 27 Jan 2014 07:11:58 -0800 (PST)	[thread overview]
Message-ID: <d606f170-6626-4277-b8ad-28463f357d29@default> (raw)
In-Reply-To: <87lhy1slx2.fsf@bzg.ath.cx>

> I'm on Drew side here, I think a one-by-one approach is better,
> whether there is a general mechanism or not (yet).
> 
> Since there is no strong objection for fixing the bookmark-jump
> case, and since it's trivial to migrate this fix to a general
> solution when we'll have one, I'm willing to apply the fix if
> no-one objects in a week.

I did not object to the idea out of hand, and I agreed that
there are arguments in its favor (for `bookmark-jump').

However, to be clear: There is no hurry for this command to act
like that, and my preference would be to *not* make this change
now for that one command, and instead to wait until we address
the issue more generally.

E.g., a user option to give users some control over this.
The file-name history is, after all, _their_ history.

Starting down this road is not a great idea without a general
plan.  Until now, minibuffer histories are designed to reflect
only text _actually input from the minibuffer by the user_.

To change that design decision so that it becomes only a
guideline, which gets modulated by other influences (e.g., the
individual command; one or more user options overrule; etc.),
we should have a general plan for where we're headed - a new
design.

So I do not object strongly, but I think it is a bad idea
to set a precedent this way.  It is better to discuss the
general issue on emacs-devel.  And there certainly is no
hurry for this, when it comes to `bookmark-jump'.

If you really want to do this now for `bookmark-jump', then
a compromise could be to add a user option just for that,
i.e., in bookmark.el.  Then, if and when a more general
design is adopted, that option could be removed in favor of
a more general option.

That would let users retain the current `bookmark-jump'
behavior or not, as they prefer.





  reply	other threads:[~2014-01-27 15:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 21:45 bug#16542: 24.3.50; When finding a file via a bookmark, that file is not part of file-name-history Bastien Guerry
2014-01-25  8:19 ` Dani Moncayo
2014-01-25  8:42   ` Drew Adams
2014-01-27 11:29     ` Bastien
2014-01-27 15:11       ` Drew Adams [this message]
2014-01-27 15:26         ` Bastien
2014-01-27 17:31           ` Drew Adams
2014-01-28  7:28             ` Juri Linkov
2014-01-28 13:28               ` Stefan Monnier
2014-01-29  9:10                 ` Juri Linkov
2014-01-29 10:43                 ` Bastien
2014-01-29 13:58                   ` Stefan Monnier
2014-01-28 16:20               ` Drew Adams
2020-08-25 10:57 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d606f170-6626-4277-b8ad-28463f357d29@default \
    --to=drew.adams@oracle.com \
    --cc=16542@debbugs.gnu.org \
    --cc=bzg@altern.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).