From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#25875: 26.0.50; Hang logging out of MS-Windows Date: Sun, 26 Feb 2017 18:38:19 -0500 Message-ID: References: <83lgsuqacv.fsf@gnu.org> <83efylq7m4.fsf@gnu.org> <834lzgreqq.fsf@gnu.org> <3f07808e-ab1c-d6b5-9ea0-dfc4c6fd6fc9@cornell.edu> <8337f0rbz6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1488152352 11121 195.159.176.226 (26 Feb 2017 23:39:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 26 Feb 2017 23:39:12 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 Cc: rcopley@gmail.com, 25875@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 27 00:39:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ci8PD-0002GZ-9w for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Feb 2017 00:39:07 +0100 Original-Received: from localhost ([::1]:48981 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ci8PH-00069D-Pp for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Feb 2017 18:39:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ci8PC-000697-7P for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2017 18:39:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ci8P8-0001IR-9t for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2017 18:39:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58989) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ci8P8-0001IN-7E for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2017 18:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ci8P7-0002AS-VF for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2017 18:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Feb 2017 23:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25875 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25875-submit@debbugs.gnu.org id=B25875.14881523118291 (code B ref 25875); Sun, 26 Feb 2017 23:39:01 +0000 Original-Received: (at 25875) by debbugs.gnu.org; 26 Feb 2017 23:38:31 +0000 Original-Received: from localhost ([127.0.0.1]:57188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ci8Od-00029f-7e for submit@debbugs.gnu.org; Sun, 26 Feb 2017 18:38:31 -0500 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:40522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ci8Ob-00029S-Ev for 25875@debbugs.gnu.org; Sun, 26 Feb 2017 18:38:30 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v1QNcNPY015487; Sun, 26 Feb 2017 18:38:23 -0500 Original-Received: from [192.168.1.6] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v1QNcL3l025882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 26 Feb 2017 18:38:22 -0500 In-Reply-To: <8337f0rbz6.fsf@gnu.org> X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129850 Archived-At: On 2/26/2017 2:25 PM, Eli Zaretskii wrote: >> Cc: rcopley@gmail.com, 25875@debbugs.gnu.org >> From: Ken Brown >> Date: Sun, 26 Feb 2017 13:58:23 -0500 >> >>> I think the problem in this particular scenario is not that the input >>> thread sleeps too long, it's that whenever it finishes sleeping and >>> returns, Emacs will be killed, so the WM_ENDSESSION message that was >>> posted to the main thread will never have a chance to be processed, >>> and thus orderly shutdown will never happen. >>> >>> That is why I thought about using SendMessageTimeout in the main >>> thread: what we really want is to cause the main thread to wake up and >>> process the WM_ENDSESSION message. Right? >> >> Yes, that would obviously be better. > > OK. Can you propose a patch that Richard could try? Here's a quick and dirty attempt. If I haven't made a mistake, it replaces every relevant call to SendMessage by a call to SendMessageTimeout with a 100ms timeout. --- a/src/w32term.c +++ b/src/w32term.c @@ -537,6 +537,15 @@ x_update_begin (struct frame *f) } +#undef SendMessage +#define SendMessage DebugSendMessage + +static LRESULT WINAPI +DebugSendMessage (HWND hWnd, UINT Msg, WPARAM wParam, LPARAM lParam) +{ + return SendMessageTimeoutA (hWnd, Msg, wParam, lParam, 0, 100, NULL); +} + /* Start update of window W. */ static void Ken