unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Jaros?aw Rzeszótko" <sztywny@gmail.com>, 16192@debbugs.gnu.org
Subject: bug#16192: hl-line-mode: Current line highlighting takes precedence over region highlighting
Date: Tue, 17 Jun 2014 07:30:25 -0700 (PDT)	[thread overview]
Message-ID: <d5735514-8915-4c86-a1e0-026aa3cb6c4a@default> (raw)
In-Reply-To: <bcaf51ae-dec7-4ac3-87f8-0142ababbc9c@default>

Assigning the priority of the hl-line overlay as -50 breaks Emacs
convention and flies in the face of overlay behavior as documented.
(elisp) `Overlay Properties' says:

 If you want to specify a priority value, use either `nil' (or zero),
 or a positive integer.  Any other value has undefined behavior.
      ^^^^^^^^           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Maybe that policy and guideline needs to be modified in light of the
chosen fix for bug #16192?  Maybe it should now say what negative
values mean (what the behavior is).

Note that not only has Emacs Dev violated this past guideline, but
3rd-party code will now do the same.  To fix precisely this bug in
hl-line+.el, for example, I had to follow suit.

[Again, instead of reducing the priorities of multiple overlays case
by case as bugs are noticed, a better fix would be to raise the
region priority.  If the other, pre-existing overlays already have
priorities that make sense relative to each other, then it is only
the priority of the new, region overlay that needs to be established.]





  parent reply	other threads:[~2014-06-17 14:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 11:38 bug#16192: hl-line-mode: Current line highlighting takes precedence over region highlighting Jarosław Rzeszótko
2013-12-19 14:02 ` Stefan Monnier
2013-12-19 14:19   ` Jarosław Rzeszótko
2013-12-19 16:43   ` Drew Adams
2013-12-19 17:41     ` Jarosław Rzeszótko
2013-12-19 19:27       ` Eli Zaretskii
2013-12-19 19:47         ` Jarosław Rzeszótko
2013-12-19 20:31           ` Stefan Monnier
2013-12-19 18:02     ` Stefan Monnier
     [not found]       ` <bcaf51ae-dec7-4ac3-87f8-0142ababbc9c@default>
2014-06-17 14:30         ` Drew Adams [this message]
2014-06-17 15:07         ` Stefan Monnier
2013-12-19 16:38 ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5735514-8915-4c86-a1e0-026aa3cb6c4a@default \
    --to=drew.adams@oracle.com \
    --cc=16192@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=sztywny@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).