From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#73723: 31.0.50; Add copy/kill/mark commands to isearch Date: Fri, 11 Oct 2024 01:10:28 +1300 Message-ID: References: <194a0202fd0c9b752d2f6e4f3ff642d8@webmail.orcon.net.nz> <86r08o36np.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34790"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: 73723@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 10 14:11:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sys0j-0008lu-UX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Oct 2024 14:11:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sys0K-0002QY-FG; Thu, 10 Oct 2024 08:10:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sys0I-0002Px-UC for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2024 08:10:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sys0I-0007ya-Lf for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2024 08:10:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:MIME-Version:To:Subject; bh=w9JsqOjSPQ/bj3zmRSP2X09cOGFSJg6/L46oQ5Ji5iM=; b=AJKS8wuyzZuL+Hwq0E1s/WQ/CReHQ01su/3rjAOZAsCkIQ6f35sHWJahSI0Oefv7C9IiwC2596M8U9vQk6Zmv6w6FPorZYHJD4da7RVW+uD37p9h32zakNW2AiJq/FC+gT7LOJVAf79xauoElyAbSJEqg2b50fvlXzMlIM7Anfi7PmICmO2LCnzgp0klLZfuUaS2SokaCLFnl5zvSuubcMTUFFFCPjWw3Qy2XafLO7oJlG+bSMA5iqBSOOgSOhYrIejVDPww/JXYGlr97bNybgxSnySLHpaJTljkOtBOo97unw4xV5kbW1p8Uzkuk2J3NNqt8e0UjbU+WWRIWu6N/Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sys0T-00063c-UL for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2024 08:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Oct 2024 12:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73723 X-GNU-PR-Package: emacs Original-Received: via spool by 73723-submit@debbugs.gnu.org id=B73723.172856225823275 (code B ref 73723); Thu, 10 Oct 2024 12:11:01 +0000 Original-Received: (at 73723) by debbugs.gnu.org; 10 Oct 2024 12:10:58 +0000 Original-Received: from localhost ([127.0.0.1]:58937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sys0M-00063E-6j for submit@debbugs.gnu.org; Thu, 10 Oct 2024 08:10:58 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:48035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sys0J-000635-59 for 73723@debbugs.gnu.org; Thu, 10 Oct 2024 08:10:52 -0400 Original-Received: from [10.253.37.70] (port=44970 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1syrzx-00057k-0j; Fri, 11 Oct 2024 01:10:35 +1300 Original-Received: from ip-116-251-164-139.as55850.net ([116.251.164.139]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 11 Oct 2024 01:10:28 +1300 In-Reply-To: <86r08o36np.fsf@gnu.org> X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293280 Archived-At: On 2024-10-10 17:48, Eli Zaretskii wrote: >> Date: Thu, 10 Oct 2024 09:33:41 +1300 >> From: Phil Sainty >> (define-key isearch-mode-map (kbd "M-s M-w") #'isearch-copy-match) >> (define-key isearch-mode-map (kbd "M-s C-w") #'isearch-kill-match) >> (define-key isearch-mode-map (kbd "M-s C-SPC") #'isearch-mark-match) >> (define-key isearch-mode-map (kbd "M-s C-@") #'isearch-mark-match) > > Sounds useful, but "M-x M-w" is already taken, unfortunately. "M-s M-w" does have a binding to `eww-search-words' in the global keymap, but I'm not sure that needs to prevent us using it here? Certainly `eww-search-words' doesn't react to the current isearch match, so I think there's not currently a particular reason why one would invoke the global binding whilst isearching. (You *could* set the mark and then search to extend the region before calling `eww-search-words' for that region; but you could trivially still do that simply by exiting the isearch explicitly.) > For isearch-kill-match, should there also be a command to kill _all_ > the matches? Potentially, although there's a library iedit.el which provides that kind of functionality. It has an `iedit-mode-from-isearch' command to invoke iedit on the matched text. (Although to specifically kill all matches, it looks like you'd need to follow that command by restarting the isearch and *then* call `isearch-kill-match'. -Phil