From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#54025: 27.2; dired-do-find-regexp skips occurences Date: Wed, 23 Feb 2022 04:38:17 +0200 Message-ID: References: <611521ae-42d4-6584-915e-243060de536e@yandex.ru> <831qzwx5a6.fsf@gnu.org> <967624c188c942ff8ecbf23bd6be46d0@pay-lab.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9574"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: "54025@debbugs.gnu.org" <54025@debbugs.gnu.org> To: =?UTF-8?Q?=D0=9F=D0=B5=D1=82=D1=80=D0=BE=D0=B2_?= =?UTF-8?Q?=D0=90=D0=BD=D0=B4=D1=80=D0=B5=D0=B9?= , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 23 03:39:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMhYe-0002IL-8y for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Feb 2022 03:39:12 +0100 Original-Received: from localhost ([::1]:38166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMhYd-0000wW-6Y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Feb 2022 21:39:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMhYW-0000wO-0i for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 21:39:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMhYT-0008DV-Mc for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 21:39:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMhYT-0000RV-JT for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 21:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Feb 2022 02:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54025 X-GNU-PR-Package: emacs Original-Received: via spool by 54025-submit@debbugs.gnu.org id=B54025.16455839081653 (code B ref 54025); Wed, 23 Feb 2022 02:39:01 +0000 Original-Received: (at 54025) by debbugs.gnu.org; 23 Feb 2022 02:38:28 +0000 Original-Received: from localhost ([127.0.0.1]:43292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMhXw-0000Qb-2s for submit@debbugs.gnu.org; Tue, 22 Feb 2022 21:38:28 -0500 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:46831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMhXu-0000QM-AM for 54025@debbugs.gnu.org; Tue, 22 Feb 2022 21:38:26 -0500 Original-Received: by mail-wr1-f43.google.com with SMTP id j22so10928648wrb.13 for <54025@debbugs.gnu.org>; Tue, 22 Feb 2022 18:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sm82bHDvL2ZCsyH1QIYrrcygfUxAdOUNYxaLAm4cjj4=; b=FHlWNcvCzO1moOOrQ961Od2fUtqUvg5Ja0+zN41SG2kcsFkym26jsm49yN3tkJOKuF ajfWyN7b8DwGD/h4J7FdBaE91SHMOF/IdC0vEHO9h8BRg2NSYWALa6ruHZsZ9c9RrxQ4 LpO7RJrjJ4WGhAU7MHnNK3SKyGTclz2oRbztgRAN7V3PgQWKl58QmfCbEf/wgLlyClHC osIYIdGuNd5G2a/dNboeh3yV4Yc8hj55tbVsK/Mvr0UzScfTKVo2iEWq9ucClVAzjxGk YxhP7NY3fjiT3EUqvDp3wjdhUz8ixw16KP/GFV7zXjmv5yMHSZWfnzCKZnefmzDxic9L aM5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sm82bHDvL2ZCsyH1QIYrrcygfUxAdOUNYxaLAm4cjj4=; b=UwLzotYfbM1FbRU+hh/j2RSp4Mvzesepm6ItfV+FumK5VDfLvzEK/G2ljX7epdCxSO 5vf6wrnPn1R1A/4ZLtO/sDPaz7HunZUq0tCefKbnty2aQugmo3ke2Iq7+RWTpFbZ9VvU sNw7tPZvEK5r3kW+HIS8C/lLeqlAmIlRsX5SpUxIueXIkCRCUK/jtaIZEfaKykJWJDt6 7ISADR+hGrpTaJ5TurNizG8wEooaYQOi4I2jh7ycHfCMp68N5VkgC6o/li+ORuRl/j/A WJww3mF+yYTDMPhQr2s/ZJg6pCgQReVVgc7oTbWxk4dSgbegdqZfti2qopeq9FRKqyST opGw== X-Gm-Message-State: AOAM532z0N0UBaaeOP3dpfbWy/ovpEE0pjRt79nJ5pGT3zPPpnVyQwSH s+WltYz5CIqR4UH/0AybImqnXDgxgJE= X-Google-Smtp-Source: ABdhPJxBLVN0l3i3Dp/Nv7sxIuFKHnOoEDdilYaCoqKELhDHZl+HmZN+CQzmqbLNvmlVjsEYWUtl6A== X-Received: by 2002:a05:6000:11c9:b0:1ed:b92d:8c68 with SMTP id i9-20020a05600011c900b001edb92d8c68mr62672wrx.692.1645583900409; Tue, 22 Feb 2022 18:38:20 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p7sm31549902wrr.95.2022.02.22.18.38.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 18:38:20 -0800 (PST) Content-Language: en-US In-Reply-To: <967624c188c942ff8ecbf23bd6be46d0@pay-lab.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227473 Archived-At: On 21.02.2022 09:00, Петров Андрей wrote: > I think it is convenient to ask user to save some buffers (like `rgrep' do) if the search algorithm implementation requires all files to be saved. Optionally modified buffers can be skipped with appropriate logging into messages buffer. How about this? diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index 56897826cb..16094f4551 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -3272,6 +3272,7 @@ dired-do-find-regexp (require 'xref) (defvar grep-find-ignored-files) (declare-function rgrep-find-ignored-directories "grep" (dir)) + (save-some-buffers) (let* ((marks (dired-get-marked-files nil nil nil nil t)) (ignores (nconc (mapcar #'file-name-as-directory diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 880c5b5517..f772871f72 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -834,6 +834,7 @@ project-or-external-find-regexp nil))) (defun project--find-regexp-in-files (regexp files) + (save-some-buffers) (unless files (user-error "Empty file list")) (let ((xrefs (xref-matches-in-files regexp files))) diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index aa98aa89f1..ae19632974 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -273,6 +273,7 @@ xref-backend-references The default implementation uses `semantic-symref-tool-alist' to find a search tool; by default, this uses \"find | grep\" in the current project's main and external roots." + (save-some-buffers) (mapcan (lambda (dir) (message "Searching %s..." dir) @@ -2013,7 +2014,9 @@ xref--find-file-buffer (setq xref--last-file-buffer ;; `find-buffer-visiting' is considerably slower, ;; especially on remote files. - (cons file (get-file-buffer file)))) + (cons file (get-file-buffer file))) + (when (buffer-modified-p (cdr xref--last-file-buffer)) + (message "Buffer %s has unsaved changes" (cdr xref--last-file-buffer)))) (cdr xref--last-file-buffer)) (provide 'xref)