From: Steve Yegge <steve.yegge@gmail.com>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: bug-gnu-emacs <bug-gnu-emacs@gnu.org>
Subject: bug#4130: issues with js2-mode faces
Date: Tue, 11 Aug 2009 22:50:59 -0700 [thread overview]
Message-ID: <d494cb8f0908112250i36e5ddb6jf522603aa6daa0c8@mail.gmail.com> (raw)
In-Reply-To: <200908091800.n79I0KLn016605@godzilla.ics.uci.edu>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Sun, Aug 9, 2009 at 11:00 AM, Dan Nicolaescu <dann@ics.uci.edu> wrote:
>
> js2-mode uses -face suffix for faces.
>
> We are not using this suffix anymore and the tree has been cleaned up of
> such with backward compatibility code added. This is new code, so
> there's little point in having the suffix...
>
Agree; I'll fix it. The docs (info pages) are incorrect on a relevant
point,
incidentally; they claim that defining variables whose value is set to the
face of the same name is popular but obsolete; the reality is that
font-lock-add-keywords requires the variable definitions.
>
> Also, instead of defining a new js2-error-face why not just use
> font-lock-warning-face?
>
Why not just define a font-lock-error-face instead? Other modes
(such as compilation) define their own error faces. Fix it in Emacs
and the modes will follow.
-steve
[-- Attachment #2: Type: text/html, Size: 1354 bytes --]
next prev parent reply other threads:[~2009-08-12 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-09 18:00 bug#4097: issues with js2-mode faces Dan Nicolaescu
2009-08-12 5:50 ` Steve Yegge [this message]
2009-08-12 7:00 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d494cb8f0908112250i36e5ddb6jf522603aa6daa0c8@mail.gmail.com \
--to=steve.yegge@gmail.com \
--cc=4130@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
--cc=dann@ics.uci.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).