From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces Date: Wed, 22 Mar 2023 14:22:45 -0700 Message-ID: References: <875yatpclo.fsf@gmail.com> <83y1no6dtd.fsf@gnu.org> <13910d348d640c50ebdc@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35753"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Trent W. Buck" , 62370@debbugs.gnu.org To: Gregory Heytings , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 23 00:36:56 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pf80l-0009A5-SI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Mar 2023 00:36:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pf7Zo-0001Un-N4; Wed, 22 Mar 2023 19:09:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pf7Zn-0001Ue-AJ for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 19:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pf7Zn-0001rl-4d for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 19:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pf7Zm-0007FG-Dm for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 19:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Mar 2023 23:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62370 X-GNU-PR-Package: emacs Original-Received: via spool by 62370-submit@debbugs.gnu.org id=B62370.167952648227733 (code B ref 62370); Wed, 22 Mar 2023 23:09:02 +0000 Original-Received: (at 62370) by debbugs.gnu.org; 22 Mar 2023 23:08:02 +0000 Original-Received: from localhost ([127.0.0.1]:36884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf7Yo-0007D3-77 for submit@debbugs.gnu.org; Wed, 22 Mar 2023 19:08:02 -0400 Original-Received: from mail-oa1-f41.google.com ([209.85.160.41]:42644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf7Ym-0007Cb-HZ for 62370@debbugs.gnu.org; Wed, 22 Mar 2023 19:08:00 -0400 Original-Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-17aceccdcf6so20967853fac.9 for <62370@debbugs.gnu.org>; Wed, 22 Mar 2023 16:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679526474; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=4gkbqAaYsGsWlZUrvnn3tMy9TKyLj7Zv7hZX6oznJWM=; b=kmIJYPsHIsKG6cIi//e8oS1D6ilv58MC6QwcUz+ZFcXHGGX5lP7Z4moozES4OpfabY Dgnf7rlfYUqejQYRLjkTH1N5QGxMoIbNdCh0sMVLzff+mOEBml6VAiIdzOTjwZstEFpO K09jmXlM0CryFBHAH0790qIkypb/LjPtXFH6ka7N/0l3J0Kj0y+hq17ZI4EOOF5sx3Um kHq0a8jpMmm3bwaNrNeS12pUb7+TDX4iv0LFC2RNrIBTTleVgQB8RJqR8b6aQj4wb3Dq tNs0rRjkEpBHLNqmPDl0f5YxJghwpsacXxwKo43Mzs7QrSJh/flWVuNML7UMwqPQdygc lbfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679526474; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4gkbqAaYsGsWlZUrvnn3tMy9TKyLj7Zv7hZX6oznJWM=; b=qjQbMlW+8aZv37InSb9JhrQjTkhNzwhDQCgYtG4OQa04Ciabxgezm0TEALRQA8obKI 5GF8EVnLZND9bGvxq2eQi4uqPCzKJHVOXj+XpjYoFmufM7n1NlWwlxgAUW7iUATeQgUz kF07alZ0FOgVsNUFclkd2N50P8xHfWZTSsXWd8Xdqw4a5TgcYkcIXSvGNLNKDdZAAbUr R2h2BjbqFBCbJv2fbC2S5KNpjIeX2s1IKUyge4KihVMBG9UKzGe341f/N8EhTcwiAozj z/5OKJON56NyxEga1IVyY/4TlQwcN4rRBlsDkX9lV+8cOu6v8gYAclQzwBFdmnwRYtIq fYcA== X-Gm-Message-State: AAQBX9ef5NodlUaG+OGIqCK2RzKmgnUfTrmbDGeI2wnLLAM6VGz5fDAh TrHP5F7kzX04JSYo/vHotvrdPNE8N6E= X-Google-Smtp-Source: AK7set9FfG+wp9Lq3vLjTuYSRT1S8jZeZZ7dD+DGzBDF70+O1K8kbjP1zoJoxdT1e0Fa2hJc93x9Cg== X-Received: by 2002:a17:903:22c6:b0:19c:ff35:35d1 with SMTP id y6-20020a17090322c600b0019cff3535d1mr5104538plg.6.1679520167031; Wed, 22 Mar 2023 14:22:47 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id y6-20020a170902b48600b001a1ea1d6d6esm2855430plr.290.2023.03.22.14.22.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 14:22:46 -0700 (PDT) Content-Language: en-US In-Reply-To: <13910d348d640c50ebdc@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258416 Archived-At: On 3/22/2023 1:10 PM, Gregory Heytings wrote: > But the sieve-* faces have existed for twenty years, so it's now too > late to change them. I think it might actually be ok to change this: the face attributes for each of the 'sieve-*' faces closely correspond to one of the 'font-lock-*-face' faces. They're not *identical*, but the differences are very slight. The mapping is: sieve-control-commands -> font-lock-builtin-face sieve-action-commands -> font-lock-function-name-face sieve-test-commands -> font-lock-constant-face sieve-tagged-arguments -> font-lock-keyword-face (Note that this is a different mapping from Trent's proposal.) If we mapped the 'sieve-*' faces like that, I doubt anyone using the default theme would notice. Likewise, anyone using a theme that customizes the 'sieve-*' faces wouldn't notice, since they're already explicitly-themed. The only users who would see an impact would be those using non-default themes that *didn't* have definitions for 'sieve-*' faces, and they'll arguably have improved visuals: with the change, 'sieve-mode' will look consistently-themed with the rest of Emacs. Since there's such a close correspondence to the font-lock faces, I'd (weakly) advocate for inheriting from them.