From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Date: Sun, 12 Dec 2021 12:27:34 -0800 Message-ID: References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22432"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52293@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 12 21:28:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwVS6-0005f8-20 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 21:28:10 +0100 Original-Received: from localhost ([::1]:44384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwVS4-0001v3-9G for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 15:28:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwVRy-0001uZ-AS for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 15:28:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwVRy-0003zf-2T for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 15:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwVRx-0002a8-MU for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 15:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 20:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16393408639900 (code B ref 52293); Sun, 12 Dec 2021 20:28:01 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 20:27:43 +0000 Original-Received: from localhost ([127.0.0.1]:53256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwVRf-0002Zc-DU for submit@debbugs.gnu.org; Sun, 12 Dec 2021 15:27:43 -0500 Original-Received: from mail-pj1-f41.google.com ([209.85.216.41]:53982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwVRd-0002ZP-I1 for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 15:27:41 -0500 Original-Received: by mail-pj1-f41.google.com with SMTP id iq11so10469792pjb.3 for <52293@debbugs.gnu.org>; Sun, 12 Dec 2021 12:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Hi+RtPjh8w8hD8TuC4TK0sIpWM9uT7WUxS1/xOVBr/A=; b=pUnTO7odDABPuFz8lim5YW/FMX1HA54OfTGDYU2zcibwNYCGIoWxmCu5HR4v+1Ubtl Tqq5eEb3blC8LUrhjDVkL6GfVT0J2GJh8e+B4AgA2LeR5qjCjitKh12TzSshVo2dpUY0 cZuqrXqhjzy5uTRPafzHB+jCpwV8jVKLw20vQ1WoGN8By6Jvo/XV6QKT7Dp7g0bqbCgN Q6O5fNRtHbLCnLX4G9n7YgqznV0MdXNibTl6hhZH/QpynFM/0vawaCJimwLS3/yQf2dP xZN0nkKb3uSEBclhMkE8tD29frkeO+MESnEmgeNbRO5cuStrokLTqvXflVTa/pjeFBs1 0j4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Hi+RtPjh8w8hD8TuC4TK0sIpWM9uT7WUxS1/xOVBr/A=; b=s3aBh7HQ9Cq7iP23BBR+aplEhyv9knwRQwJ1WvmzHwo+xGexocu6AFbpGEmPpU/2H3 34hvhkneU3VSjD7HcExx9qBC+N9S1zGjspegAushJtvpKkeRMQXKRS6fsczqESzLn5ri Hi4MYAXS1wgGmZvsaDIAhH9BJ7dPe2lCmg7LUOTjnyYWixAScK/pcc+3EBzsDHlAbgtI 9woJW37wcFphqI/Za0Qj7SfZbdPYVa0V4kfDmGNBQEkGCJULVccPV2GoHhCfyzKD82xI N0pshnkGydpH/8c2HfrRczTYP8o+gXLqh/AKOX6CpDFSdS7xD43Ta3muqbd0TZ7nCVIA h7Qg== X-Gm-Message-State: AOAM531uztOnmTBIrdYRvLVlBtaUoCsl3WAJMpIoJsx6tw6AyIkCbOmF M2IGXqR7y9kOGGh7cBMj+PU= X-Google-Smtp-Source: ABdhPJyxIojpA95gJufYipbCwOsXbd7FeiqV5nZ2xpVTP1yWy5dRcSKyRFaQYP9BKFadjvP6fUcHzg== X-Received: by 2002:a17:90a:1919:: with SMTP id 25mr40431411pjg.154.1639340855748; Sun, 12 Dec 2021 12:27:35 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id j190sm7714739pge.70.2021.12.12.12.27.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 12:27:35 -0800 (PST) In-Reply-To: <83o85mpaqb.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222267 Archived-At: On 12/11/2021 11:02 PM, Eli Zaretskii wrote: > Are you saying that we will be recommending a convention for separator > names only for menus popped up in context-menu-mode? Does it make > sense to have such a specialized convention? Isn't it possible to > show context menus outside of the context-menu-mode? No, I think this convention should be recommended for separators used anywhere in Emacs going forward. I'm focusing mostly on context-menu-mode simply because it's pretty new, so there won't be much third-party code that relies on the old (`separator-foo') naming convention yet; it shouldn't be too risky to change this now. On the other hand, separators in the menu-bar (for example) have been around for longer, so I think it's probably too late to change those. Overall, my guideline would be: use `foo-separator' when adding a new separator to Emacs, unless that part of the code consistently uses the `separator-foo' naming convention. In that case, it's probably best to stick with the existing scheme in those parts in order to be more internally-consistent.