From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#24784: 26.0.50; JSON strings with utf-16 escape codes Date: Wed, 26 Oct 2016 10:37:41 -0700 (PDT) Message-ID: References: <63b3b672-f91c-f1b9-46e5-8f6dd8636714@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1477504033 24198 195.159.176.226 (26 Oct 2016 17:47:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 26 Oct 2016 17:47:13 +0000 (UTC) Cc: Philipp Stephani , 24784@debbugs.gnu.org To: Helmut Eller , Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 26 19:47:09 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzSI6-0005Ni-6M for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Oct 2016 19:47:06 +0200 Original-Received: from localhost ([::1]:36421 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzSI8-0003n4-Ex for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Oct 2016 13:47:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzS9O-0004MS-Lr for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2016 13:38:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzS9K-0005Fs-S3 for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2016 13:38:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42412) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bzS9K-0005Fo-OS for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2016 13:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bzS9K-0003bF-DU for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2016 13:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Oct 2016 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24784-submit@debbugs.gnu.org id=B24784.147750347113820 (code B ref 24784); Wed, 26 Oct 2016 17:38:02 +0000 Original-Received: (at 24784) by debbugs.gnu.org; 26 Oct 2016 17:37:51 +0000 Original-Received: from localhost ([127.0.0.1]:57811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzS99-0003aq-CP for submit@debbugs.gnu.org; Wed, 26 Oct 2016 13:37:51 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:45185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzS97-0003ac-Rm for 24784@debbugs.gnu.org; Wed, 26 Oct 2016 13:37:50 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u9QHbhxA014569 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Oct 2016 17:37:43 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id u9QHbhJl023584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Oct 2016 17:37:43 GMT Original-Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u9QHbgLG032388; Wed, 26 Oct 2016 17:37:42 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125041 Archived-At: > >> +(defsubst json--decode-utf-16-surrogates (high low) > > > > IIRC, there might be no actual benefit from making it a defsubst. > > If someone could benchmark it, I'd like to see the result. >=20 > I guess it doesn't hurt but I also doubt that it makes a measurable > difference as utf-16 surrogates are rarely needed. IMO, we should never, ever use defsubst nowadays. Unless you can come up with a REALLY good rationale. Every time defsubst is used it throws a monkey wrench in the ability of users to extend and modify Emacs behavior. And nothing is really gained. Just one opinion.