From: Drew Adams <drew.adams@oracle.com>
To: Helmut Eller <eller.helmut@gmail.com>, Dmitry Gutov <dgutov@yandex.ru>
Cc: Philipp Stephani <p.stephani2@gmail.com>, 24784@debbugs.gnu.org
Subject: bug#24784: 26.0.50; JSON strings with utf-16 escape codes
Date: Wed, 26 Oct 2016 10:37:41 -0700 (PDT) [thread overview]
Message-ID: <d4073d8f-ed31-41d7-88a8-6bdb1a5cc70e@default> (raw)
In-Reply-To: <m2funjoyhu.fsf@gmail.com>
> >> +(defsubst json--decode-utf-16-surrogates (high low)
> >
> > IIRC, there might be no actual benefit from making it a defsubst.
> > If someone could benchmark it, I'd like to see the result.
>
> I guess it doesn't hurt but I also doubt that it makes a measurable
> difference as utf-16 surrogates are rarely needed.
IMO, we should never, ever use defsubst nowadays. Unless you can
come up with a REALLY good rationale.
Every time defsubst is used it throws a monkey wrench in the ability
of users to extend and modify Emacs behavior. And nothing is really
gained.
Just one opinion.
next prev parent reply other threads:[~2016-10-26 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 18:06 bug#24784: 26.0.50; JSON strings with utf-16 escape codes Helmut Eller
2016-10-24 19:57 ` Philipp Stephani
2016-10-24 23:19 ` Dmitry Gutov
2016-10-26 16:39 ` Helmut Eller
2016-10-26 17:37 ` Drew Adams [this message]
2016-12-31 16:53 ` Philipp Stephani
2017-01-01 0:45 ` Dmitry Gutov
2017-01-01 12:26 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4073d8f-ed31-41d7-88a8-6bdb1a5cc70e@default \
--to=drew.adams@oracle.com \
--cc=24784@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eller.helmut@gmail.com \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).